yegappan / lsp Goto Github PK

I tried adding eslint language server as below but it seems not supported yet.

let lspServers = [
		\     {
		\	'filetype': ['javascript', 'typescript', 'javascriptreact'],
		\	'path': 'path/to/typescript-language-server',
		\	'args': ['--stdio']
		\     },
		\     {
		\	'filetype': ['javascript', 'typescript', 'javascriptreact'],
		\	'path': 'path/to/vscode-eslint-language-server',
		\	'args': ['--stdio']
		\     },
		\   ]
call lsp#addServer(lspServers)

Error I get:

Error: LSP server does not support getting list of symbols
Error: Unsupported request message received from the LSP server (<path to server>), message = {'id':
 0, 'jsonrpc': '2.0', 'method': 'workspace/configuration', 'params': {'items': [{'section': '', 'scopeUri': '<path>'}]}}

I am not sure if this is a language server limitation or this plugin.

For files that are opened from command line (e.g. vim src/main.cpp) the LSP isn't properly loaded when using Plug and the VimEnter autocommand. After vim is opened the LSP isn't active. When re-loading the file with :e the LSP is activated. I suppose the VimEnter autocommand is executed too late in this case.

Edit: Adding through lsp#lsp#AddServer() works btw.

How i can use snippets with this lsp ?

chg from pr ea1020b :
autoload/handlers.vim
line#138
label = sig.parameters[result.activeParameter].documentation

E1012: Type mismatch; expected string but got special

// by the way: the doc about 'setOption', the key should add quote.
line# 252 and 259
e.g
call lsp#setOptions({showSignature: v:false})

Maybe it's a common knowledge among language server users, but in case of clangd, I discovered that rename seems to work with once opened files.
So the trick is to do LspShowReferences on the particular target and then call LspRename to refactor all other files, and then you can just do :wqa or :wa.

Would it be maybe possible to make LspRename work like that by default or provide new command like LspRenameAll?

I have a simple vimrc vim9script config for python:

vim9script
plug#begin()
...
Plug 'yegappan/lsp'
plug#end()
...
var lspServers = [
    {
        'filetype': ['python'],
        'path': '/usr/bin/pylsp',
        'args': []
    }
]
call LspAddServer(lspServers)
...

Vim version:
VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Feb 24 2022 18:41:57)
Included patches: 1-4464

I was able to run call LspAddServer() after opening a *.py file, LspShowServers shows that pylsp was added, but is currently stopped:

python    not running    /usr/bin/pylsp

But when i try to restart it with LspServerRestart i get:

Error: LSP server for "test.py" is not found

Apparently jdt-ls extends lsp and return jdt:// URI for compiled libraries. And I'm assuming it's not support by this lsp
Nvim looks like they let another plugin to handle this.
https://github.com/mfussenegger/nvim-jdtls

example lsp config (excerpt)

# work dir for jdtls(it has to be outside the project source)
var lsp_work_dir = $HOME .. "/.cache/lsp/" .. getcwd()

# lsp config for java
# get tgz from https://download.eclipse.org/jdtls/snapshots/?d and add bin to $PATH for jdtls command(python script)
            \ { 'filetype': ['java'],       'path':  "jdtls", 'args': ["-data", lsp_work_dir] },


# Opening example project
git clone https://github.com/eclipse/eclipse.jdt.ls.git --depth=1
cd eclipse.jdt.ls
./mvnw compile
vim org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/LanguageServer.java

# jdt:// stuff are most likely raising error(cannot be resolved), after finish loading completely. 

Other than external,standard libraries, this amazing lsp plugin works perfectly. :)

Selected function How Auto-complete bracket

i saw this plugin used to use window jump per winid..
it probably good for 'save-id -> do-something -> jump-back-To-saved-id' this style.
But:

• var wid: number = fname->bufwinid()
  • perhaps there were many same fname opened there, including current one also is..........
  • but such would get only the first found. mostly jump is Not wanted when/if current one also is.
• wid->win_gotoid()
  • Specially such jump would over 'Tabs', that may looks mess, user perhaps used to focus on cur tab.
  • BTW: latest win_gotoid() func had 'bug': it can escape from popup/terminal window, that may happen unexpected issue.

// I suggest to add a judgement for above case:

• if cur one is same 'fname', then donot jump.
• jump should not over Tabs, if winid not in cur tab, then give-up. try cur tab first.

Hi @yegappan, thanks for creating this plugin, that's what I am looking for, but why do not use lsp as the default namespace, and put all files under autoload/lsp directory. currently using top namespace, for example buffer#... and util#... will break users's config.

hanlders.vim :

def ProcessSignaturehelpReply(lspserver: dict<any>, req: dict<any>, reply: dict<any>): void
  signature.SignatureDisplay(lspserver, reply.result)
enddef

|| E1013: Argument 2: type mismatch, expected dict<any> but got special

most compl looks set icase=1 or had option to set it,
and/or i remember you added 'matchfuzzy' func into vim, how about add this to filter, perhaps that's a good feature as well.

Problem

I'd received the feature request for supporting yegappan/lsp on vim-vsnip and vim-vsnip-integ.
I'd add the support but yegappan/lsp does not provide the way to turn on snipptSupport=true.

Solution

Provide the global configuration option to snippetSupport = true.

I think it should use in

Apply clang-format of totally different format like llvm in vim project.
Undo the change, vim will completely get blocked with 100% usage for a while.

1. Check out some git project.
2. Open test.c (assuming lsp, clangd, futigive installed and configured).
3. Gtabedit some_branch:test.c (some_branch must have the test.c file)
4. Do some lsp commands like finding references on the branch file. (file in a .git dir)
5. Go back to the test.c file and you can't do any lsp calls unless you restart the whole vim process.

Hi, I'm having a hard time trying to use this the lsp package.

Here is my Vim version (I'm using MacVim):

VIM - Vi IMproved 9.0 (2022 Jun 28, compiled Jul 25 2022 08:23:04)
macOS version - arm64
Included patches: 1-65

I made a small test vim rc:

$ cat ~/thing.vim
packadd lsp
let lspServers = [ { 'filetype': ['c', 'cpp'], 'path': '/usr/local/bin/clangd', 'args': ['--background-index'] } ]
call LspAddServer(lspServers)

I installed the plugin as the readme shows:

$ ls $HOME/.vim/pack/downloads/opt/lsp
lsp/
$ ls $HOME/.vim/pack/downloads/opt/lsp/lsp
LICENSE    README.md  autoload/  doc/       plugin/    test/

When I start Vim I get this error:

$ vi -u ~/thing.vim
Error detected while processing /Users/aaron/thing.vim:
line    3:
E117: Unknown function: LspAddServer

This error is similar to #61, but none of the workarounds in #61 would work for me. I'm not sure what I'm doing wrong.

  for symbol in reply.result
    if !symbol->has_key('location')

of processWorkspaceSymbolReply, that reply.result maybe a special type, but here needs a list<any>. so E1012.

// actually, perhaps better check all those funcs in ProcessReply, check their type, not only if empty().

  if lsp_reply_handlers->has_key(req.method)
    lsp_reply_handlers[req.method](lspserver, req, reply)
  else

of def ProcessReply, perhaps can check there in totally, that replay.

  var ch = lspserver.job->job_getchannel()
  ch->ch_sendraw(msg)

of s:sendMessage, looks not right, ch maybe not open, closed or buffered, then 'E906', cannot send.

// this happened when trying with ts lsp server.

I am getting this error here in combination with the vim-language-server when I execute the omni complete mapping without any preceding characters, seems like it tries to send some empty variables to the LSP.

Error(LSP): request textDocument/completion failed (Request textDocument/completi... arguments[[object Object], [object Object], undefined, undefined], code = -32603)

I'm looking for a solution to format files before writing.

autocmd BufWritePre *.c,*.cpp,*.h :LspFormat

The problem is that :LspFormat is asynchronous and the buffer gets written before formatting.

Moreover, sometimes I get corrupted buffer content. It seems that the formatting happens while the buffer is being written.

var symTbl: list<dict> = popupID->getwinvar('LspSymbolTable')
// popupID->getwinvar('LspSymbolTable') maybe empty.

For anyone interested in testing and helping improving this - I created a small adapter for the mattn/vim-lsp-settings plugin to make it easier to install LSP servers for this plugin.

You can install it from https://github.com/normen/vim-lsp-settings-adapter

I haven't found a condition when it happens but sometimes fixing the clangd(clang-tidy) warning, highlight doesn't disappear. The only way to fix it is to restart the vim completely (e! doesn't help).

I'll update this issue as soon as I found the exact condition to reproduce this.

a headsup notice:

var content = lspserver.data[idx : idx + len - 1]
var msg = content->json_decode()

looks sometime ‘lsp.data->len - idx < len’ such judgement not good enough or somehow, that process json decode would raised e488 err,
But cannot solid reproduced, just a note...

I tried following config with this lsp. And simply jumping to the function in the same file stops working, when the file name isn't .sh.
error message:

Error(LSP): request textDocument/definition failed (Request textDocument/definition failed with message: Cannot read properties of undefined (reading 'rootNode'), code = -32603)

relevant config

            \ { 'filetype': ['sh'],         'path': 'bash-language-server', 'args': ['start'] },
            \ { 'filetype': ['bash'],         'path': 'bash-language-server', 'args': ['start'] },
            \ { 'filetype': ['zsh'],        'path': 'bash-language-server', 'args': ['start'] },

In vim-lsc, any filename with shebang #!/bin/sh works with a configuration like this.

packadd vim-lsc
g:lsc_auto_map = true
set completeopt-=preview
g:lsc_server_commands = {
    'sh': 'bash-language-server start',
}

It maybe a vim9script bug?

Hi,

it seems the openscad-lsp reports a {} for the completionProvider variable instead of true which later gets recognized as false here:

When removing or changing the above check as below the LSP provides completion as expected.
if !lspserver.caps->has_key('completionProvider')

This is the debug output of LspDebug while initializing the openscad-lsp:

Sent [11/06/22 17:17:19]: {'method': 'initialize', 'params': {'rootUri': 'file:///Users/normenhansen/Documents/OpenSCAD/raumschiff/', 'workspaceFolders': [{'uri': 'file:///Users/normenhansen/Documents/OpenSCAD/raumschiff/', 'name': 'raumschiff'}], 'rootPath': '/Users/normenhansen/Documents/OpenSCAD/raumschiff', 'clientInfo': {'version': '9000800', 'name': 'Vim'}, 'processId': 48342, 'trace': 'off', 'capabilities': {'workspace': {'workspaceFolders': true, 'applyEdit': true}, 'window': {}, 'general': {}, 'textDocument': {'foldingRange': {'lineFoldingOnly': true}, 'documentSymbol': {'symbolKind': {'valueSet': [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25]}, 'hierarchicalDocumentSymbolSupport': true}, 'completion': {'completionItem': {'snippetSupport': false, 'resolveSupport': {'properties': ['detail', 'documentation']}, 'documentationFormat': ['plaintext', 'markdown']}, 'completionItemKind': {'valueSet': [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25]}}, 'hover': {'contentFormat': ['plaintext', 'markdown']}}}}}
Received [11/06/22 17:17:19]: {'id': 1, 'jsonrpc': '2.0', 'result': {'capabilities': {'hoverProvider': true, 'documentFormattingProvider': true, 'documentSymbolProvider': true, 'definitionProvider': true, 'completionProvider': {}, 'textDocumentSync': 2}}}
Received [11/06/22 17:52:05]: {'method': 'textDocument/publishDiagnostics', 'jsonrpc': '2.0', 'params': {'diagnostics': [], 'uri': 'file:///Users/normenhansen/Documents/OpenSCAD/raumschiff/switch.scad', 'version': 4}}

I'm not quite sure if this can be put down as a bug in the LSP server as it works fine in other contexts (VSCode etc).

Hey,

to display the error count in my lightline status line I am using lsp#lsp#ErrorCount which basically works but the status line isn't updated when the LSP detects new errors. I have to do some action like LspOutline to update the status line.

The vim-lsp plugin solves this by having an autocmd called lsp_diagnostics_updated which is executed when the LSP changes so I can update the status line like shown below. Maybe something like that could be added to this plugin.

autocmd User lsp_diagnostics_updated call lightline#update()

Cheers!

lsp/autoload/handlers.vim[22]..function diag#DiagNotification:
line   24:
E117: Unknown function: UpdateDiags

recently vim and this changed much, not some err not very sure what happened... :-)

Hi, first of all thanks for this lightning fast vim LSP server! This is a gamechanger.

While setting up my environment I noticed that when autocomplete is enabled and I manually set the omnifunc to LspOmniFunc it won't work. Is there any way to enable autocomplete and still have the omni func?

Please add support for clangd's 'textDocument/switchSourceHeader'.

Alternatively, please expose API for sending custom requests to LSP server.

I have noticed odd behaviours while using autocompletion. I'm running vim 9.0.809 and I am using tsserver for an lsp.

1. If you type one new character on a new line the results in the completion menu will not be filtered down by the characters already typed. For example if you have foo and bar in scope and you type the letter 'f' your first result will be bar. Any more key presses filters down the list.

2. If you have already typed foo and press backspace the current list in the completion menu is removed and a new list is added to the completion menu. this list is also not filtered by what you have inserted so far.

I have looked at how autocompletion is implemented in this plugin and noticed that it only fetches the autocompletion results when the completion menu is closed and a valid key is pressed. And I have also noticed that the completion results from the lsp are not filtered down, I think that vims completion menu implementation filters this list down itself.

For the first scenario I think the following is happening. Because the result from the lsp for autocompletion is asynchronous we have to wait for the suggested results. The problem is the vim completion menu only filters down the results on key press, so we are only given the full list from the lsp.

For the second scenario I'm not completely sure what is going on. We already have the results from the lsp, we shouldn't need to fetch those results a second time but we do. This isn't the usual behaviour of the completion menu, usually on backspace the completion menu stays visible. I could see fetching on backspace covering some edge cases though.

The line lsp.vim:47
set ballooneval balloonevalterm

makes buffer scroll up whenever the mouse is moved.

This does not happen in gvim.

Reproduction steps:

1. Open any registered lsp filetype so function lspInitOnce is executes.
2. Go to last line.
3. First line of file must not be visible for next step to happen.
4. Move mouse.

These steps cause buffer to scroll up until first line is visible.

This also causes not to show the balloon when it should (again only in vim).

In case it is relevant:

• Using Arch Linux kernel 5.13.13-arch1-1
• urxvt-unicode 9.26-2
• VIM - Vi IMproved 8.2 (2019 Dec 12, compiled May 28 2021 06:58:52) - Included patches: 1-2891

By the way, very nice piece of code.
I'm using it everyday (but it've disabled balloonevalterm due to the scrolling).

Would it be possible to add a such feature? vim-lsc had it and it was useful for re-reading compile commands json with clangd.

Every LspGoto* command creates a window split instead of reusing the current window. Please add <mods> support for such commands, so the user can specify whether to use split or not.

Error(LSP): request workspace/executeCommand failed (No delegateCommandHandler for java.apply.workspaceEdit, code = -32601)

code action not impl yet, for now just a list of code action hint.

those lsp server were implemented variedly, due to some reason :-) may had to delay init lsp#addServer after vimenter,
// or whatever that may happen in user side anyhow......

if so, looks lsp would not startup IF startup vim with a fs argument.
e.g 'vim x.sh', and check by 'LspShowServers', server is Not running..

looks haveNot impl method: ‘workspace/didChangeConfiguration’ yet
supposed you knew, but for a mark, so opening this ticket...

While i using typescript language server and accessing to the properties, autocomplete is overwriting even a dot. But when i using rust-analyzer, it doesn't autocompleting like typescript lang server. It works properly.
Seems like rust-analyzer's autocomplete is not activated with dot key input, but typescript does.

Temporary i'm adding below codes after this block and it seems like working properly with other language servers.

if matchstr(getline('.'), '\%' .. (col('.') - 1) .. 'c.') == '.'
  start_col += 1
endif

Or is there any option to handle this?

I suggest replace such functions with capital first letter and prepend export.
I'm not sure if vim8 vimrc will need to call import to call lsp#setOptions.
It might be a good idea to migrate to global variable based config like the old times, as it is bit awkward to call import during configuration.

prop_type_add('LspOutlineHighlight', {bufnr: bufnr(), highlight: 'Search'})
// when/if opened a outline already -but to open another in another tab.
// 'Property type LspOutlineHighlight already defined'

g:markdown_fenced_languages = ['help', 'python', 'bash=sh', 'vim', 'rust'] # add as needed
g:markdown_syntax_conceal = 1

set completeopt=menuone,popup,noinsert,popuphidden
def MarkdownPopup()
  w:vim9lsp_md_applied = get(w:, 'vim9lsp_md_applied', 0)
  var win = popup_findinfo()
  if w:vim9lsp_md_applied == 0
    var buf = winbufnr(win)
    if !!buf && buf != 1
      setwinvar(win, "&conceallevel", 3)
      setbufvar(buf, "&number", "0")
      setbufvar(buf, "&filetype", "markdown")
      w:vim9lsp_md_applied = 1
    endif
  endif
  popup_show(win)
enddef
autocmd CompleteChanged * MarkdownPopup()

I've been working on getting markdown syntax into the popup like the other lsp clients. I ended up using a similar strategy to how
complete-popuphidden does it, to integrate with vim's own complete() function and complete_info(dict)

There is still some things I'd like to improve. vim-lsp, for example unbinds the default markdown syntax regions (in the complete-popup that is) to achieve an even higher level of cleanliness. Mainly what it does is that it joins ``` lang markdown-tokens (or code-fences) so they conceal on the same line (not leaving an empty line where ``` was concealed). Also it defines its own fenced_languages, so your g:markdown_fenced_languages can stay agnostic and unassuming to your own .md-filetype preferences. I like this, I have already done it and saved lines that I can add to this function later, goes something like this

syntax sync clear
unlet g:markdown_fenced_languages
runtime! syntax/markdown.vim
let g:markdown_fenced_languages = ['help']
syntax clear markdownCodeBlock | syntax clear markdownCode
syntax region markdownCode matchgroup=Conceal start=/\%(``\)\@!`/ matchgroup=Conceal end=/\%(``\)\@!`/ containedin=TOP keepend concealends
syntax clear markdownEscape
syntax region markdownEscape matchgroup=markdownEscape start=/\\\ze[\\\x60*{}\[\]()#+\-,.!_>~|"$%&'\/:;<=?@^ ]/ end=/./ containedin=ALL keepend oneline concealends

Try it out and see if you encounter issues.

Would you prefer this as a PR for the README.md as customization or would you like me to attempt to integrate it with an option? Both are equally viable I guess, as there is no way to prematurely spice the complete-popup anyways without autocmd (that I know of).

PS.
I'm also going to attempt to make a function that searches root_uri-detecting files like Cargo.toml, package.json in parent-dirs when you open a file like vim src/rust/test/test.rs instead of cd src/rust/test && vim test.rs or vim, :cd src/test and :e test.rs (Notice the LSP server does not initialize properly without cd to workspace-dir first)

Opening vim I get this below error, I'm using the git clone https://github.com/yegappan/lsp method to install
Error: LSP server /usr/local/bin/clangd is not found