yammer / mcrouter-build-docker Goto Github PK

Hi,

I am running => docker build -t mcrouter:test .

It runs and fails with this error:

• make install
  [100%] Built target double-conversion
  Install the project...
  -- Install configuration: ""
  -- Installing: /tmp/mcrouter-build/install/lib/CMake/double-conversion/double-conversionConfig.cmake
  -- Installing: /tmp/mcrouter-build/install/lib/CMake/double-conversion/double-conversionConfigVersion.cmake
  -- Installing: /tmp/mcrouter-build/install/lib/CMake/double-conversion/double-conversionLibraryDepends.cmake
  -- Installing: /tmp/mcrouter-build/install/lib/CMake/double-conversion/double-conversionLibraryDepends-noconfig.cmake
  -- Installing: /tmp/mcrouter-build/install/lib/libdouble-conversion.so.1.0.0
  -- Installing: /tmp/mcrouter-build/install/lib/libdouble-conversion.so.1
  -- Installing: /tmp/mcrouter-build/install/lib/libdouble-conversion.so
  -- Installing: /tmp/mcrouter-build/install/include/double-conversion/bignum.h
  -- Installing: /tmp/mcrouter-build/install/include/double-conversion/cached-powers.h
  -- Installing: /tmp/mcrouter-build/install/include/double-conversion/diy-fp.h
  -- Installing: /tmp/mcrouter-build/install/include/double-conversion/double-conversion.h
  -- Installing: /tmp/mcrouter-build/install/include/double-conversion/fast-dtoa.h
  -- Installing: /tmp/mcrouter-build/install/include/double-conversion/fixed-dtoa.h
  -- Installing: /tmp/mcrouter-build/install/include/double-conversion/ieee.h
  -- Installing: /tmp/mcrouter-build/install/include/double-conversion/strtod.h
  -- Installing: /tmp/mcrouter-build/install/include/double-conversion/utils.h
• export 'LDFLAGS=-L/tmp/mcrouter-build/install/lib -ldl -ljemalloc -Wl,-rpath=/usr/local/lib/mcrouter/'
• LDFLAGS='-L/tmp/mcrouter-build/install/lib -ldl -ljemalloc -Wl,-rpath=/usr/local/lib/mcrouter/'
• export 'CPPFLAGS=-I/tmp/mcrouter-build/install/include '
• CPPFLAGS='-I/tmp/mcrouter-build/install/include '
• cd /tmp/mcrouter-build/pkgs/folly/folly/
• autoreconf --install
  configure.ac:90: warning: PKG_PROG_PKG_CONFIG is m4_require'd but not m4_defun'd
  m4/fb_check_pkg_config.m4:1: FB_CHECK_PKG_CONFIG is expanded from...
  configure.ac:90: the top level
  configure.ac:114: warning: PKG_PROG_PKG_CONFIG is m4_require'd but not m4_defun'd
  m4/fb_check_pkg_config.m4:1: FB_CHECK_PKG_CONFIG is expanded from...
  configure.ac:114: the top level
  configure.ac:120: warning: PKG_PROG_PKG_CONFIG is m4_require'd but not m4_defun'd
  m4/fb_check_pkg_config.m4:1: FB_CHECK_PKG_CONFIG is expanded from...
  configure.ac:120: the top level
  configure.ac:147: warning: PKG_PROG_PKG_CONFIG is m4_require'd but not m4_defun'd
  m4/fb_check_pkg_config.m4:1: FB_CHECK_PKG_CONFIG is expanded from...
  configure.ac:147: the top level
  configure.ac:90: warning: PKG_PROG_PKG_CONFIG is m4_require'd but not m4_defun'd
  m4/fb_check_pkg_config.m4:1: FB_CHECK_PKG_CONFIG is expanded from...
  configure.ac:90: the top level
  configure.ac:114: warning: PKG_PROG_PKG_CONFIG is m4_require'd but not m4_defun'd
  m4/fb_check_pkg_config.m4:1: FB_CHECK_PKG_CONFIG is expanded from...
  configure.ac:114: the top level
  configure.ac:120: warning: PKG_PROG_PKG_CONFIG is m4_require'd but not m4_defun'd
  m4/fb_check_pkg_config.m4:1: FB_CHECK_PKG_CONFIG is expanded from...
  configure.ac:120: the top level
  configure.ac:147: warning: PKG_PROG_PKG_CONFIG is m4_require'd but not m4_defun'd
  m4/fb_check_pkg_config.m4:1: FB_CHECK_PKG_CONFIG is expanded from...
  configure.ac:147: the top level
  libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, build-aux'. libtoolize: copying filebuild-aux/config.guess'
  libtoolize: copying file build-aux/config.sub' libtoolize: copying filebuild-aux/install-sh'
  libtoolize: copying file build-aux/ltmain.sh' libtoolize: putting macros in AC_CONFIG_MACRO_DIR,m4'.
  libtoolize: copying file m4/libtool.m4' libtoolize: copying filem4/ltoptions.m4'
  libtoolize: copying file m4/ltsugar.m4' libtoolize: copying filem4/ltversion.m4'
  libtoolize: copying file `m4/lt~obsolete.m4'
  configure.ac:90: warning: PKG_PROG_PKG_CONFIG is m4_require'd but not m4_defun'd
  m4/fb_check_pkg_config.m4:1: FB_CHECK_PKG_CONFIG is expanded from...
  configure.ac:90: the top level
  configure.ac:114: warning: PKG_PROG_PKG_CONFIG is m4_require'd but not m4_defun'd
  m4/fb_check_pkg_config.m4:1: FB_CHECK_PKG_CONFIG is expanded from...
  configure.ac:114: the top level
  configure.ac:120: warning: PKG_PROG_PKG_CONFIG is m4_require'd but not m4_defun'd
  m4/fb_check_pkg_config.m4:1: FB_CHECK_PKG_CONFIG is expanded from...
  configure.ac:120: the top level
  configure.ac:147: warning: PKG_PROG_PKG_CONFIG is m4_require'd but not m4_defun'd
  m4/fb_check_pkg_config.m4:1: FB_CHECK_PKG_CONFIG is expanded from...
  configure.ac:147: the top level
  configure.ac:90: warning: PKG_PROG_PKG_CONFIG is m4_require'd but not m4_defun'd
  m4/fb_check_pkg_config.m4:1: FB_CHECK_PKG_CONFIG is expanded from...
  configure.ac:90: the top level
  configure.ac:114: warning: PKG_PROG_PKG_CONFIG is m4_require'd but not m4_defun'd
  m4/fb_check_pkg_config.m4:1: FB_CHECK_PKG_CONFIG is expanded from...
  configure.ac:114: the top level
  configure.ac:120: warning: PKG_PROG_PKG_CONFIG is m4_require'd but not m4_defun'd
  m4/fb_check_pkg_config.m4:1: FB_CHECK_PKG_CONFIG is expanded from...
  configure.ac:120: the top level
  configure.ac:147: warning: PKG_PROG_PKG_CONFIG is m4_require'd but not m4_defun'd
  m4/fb_check_pkg_config.m4:1: FB_CHECK_PKG_CONFIG is expanded from...
  configure.ac:147: the top level
  configure:16306: error: possibly undefined macro: AC_MSG_NOTICE
  If this token and others are legitimate, please use m4_pattern_allow.
  See the Autoconf documentation.
  autoreconf: /usr/bin/autoconf failed with exit status: 1
  The command '/bin/sh -c mkdir /tmp/mcrouter-build && ./scripts/install_ubuntu_12.04.sh /tmp/mcrouter-build' returned a non-zero code: 1

Any idea why ?

I'm working on this right now.

The only weird thing is that in order to keep the same configuration options for ENV variables in the configuration file, I have to do something like this, where RELEASE is a configurable variable just like MCROUTER_VERSION and MCROUTER_SHA:

Dockerfile:

FROM ubuntu:__RELEASE__
# [..snip..]
ENV RELEASE 14.04

But, since FROM has to be the first line of the Dockerfile, we have to use a "templated" variable (__RELEASE__) that we replace in the Makefile:

Makefile:

# [..snip..]
RELEASE = `grep "ENV RELEASE" Dockerfile | cut -f3 -d' '`

.PHONY: all build cp

all: build cp

build:
        sed "1 s/__RELEASE__/${RELEASE}/" Dockerfile | docker build -t mcrouter -
# [..snip..]

I don't know if there's a cleaner way to do this. The above should work but it's kind of hacky. Perhaps a wrapper script for the whole process? I was avoiding that because I thought your use of a Makefile was a clever way to handle the whole build + docker orchestration and wanted to stick to that.