yammer / circuit-breaker-js Goto Github PK

I would like to use it in my node/express REST app. Unfortunately at the moment I can't see the way to do it, the library seems to me focused on browser usage only. Would you accept a pull request that fixes this and adds server-side module.exports functionality?

Hello,

As PR #10 has been merged last month, is it possible to publish a new version on NPM ?

Thanks in advance.

@rlayte @unindented

I wanted to potentially use this module or something similar, however it appears no activity has been made on this project for awhile.

Has this module been official abandoned?

Thanks!

I recently discovered my implementation was throwing an exception before calling the success or failure methods. Personally I'd expect that circuit-breaker would take that to mean failure. How to reproduce:

var breaker = new CircuitBreaker();
breaker.run(function(success, failed) {
  throw new Error("uncaught error");
});

How I'm fixing this now:

var breaker = new CircuitBreaker();
breaker.run(function(success, failed) {
  try {
    throw new Error("example");
  } catch (e) {
    failed();
  }
});

Would it make sense to add this behavior to the circuit-breaker library?

Hello.

First thank you very much for implementing this library!

I would like to discuss the use case that I have: I set a timeout on the request and abort the request when it occurs, then I count such error to be a failure, so I don't really need timeoutDuration from the library.

I plan to set timeoutDuration to be 1 second later than my socket timeout, so it won't be triggered, but it seems to be a hack.

The api for run as it stands is equivalent to accepting a constructor of a promise. Would you be open to a PR which allows for accepting a promise as well?