yahooarchive / daytona Goto Github PK

Ability for framework owner to transfer test details and logs from one daytona instance to another.

A security researcher discovered that an authenticated user (including a newly registered guest) could import a Zip file containing framework data. Although the extracted Zip file data is not stored in the web server document root, symbolic links created during the web app installation for "test_data" allow for PHP execution.

Steps to Reproduce
Important: Make sure to use a test account when reproducing these steps!

1. Export the DaytonaSampleFramework to a zip file under the user dropdown box -> Import/Export page.
2. Add a PHP file to the Zip archive as test.php in the DaytonaSampleFramework directory.
3. Import the Zip archive under the Import/Export page.
4. Browse to http://127.0.0.1/test_data/DaytonaSampleFramework/test.php and notice the uploaded PHP file is interpreted.

We have uncovered some security vulnerabilities in Daytona (SQL Injection and few other issues) and we are in the process of addressing these issues. Standard security practices (strong password for Daytona UI and hardening Daytona host) should help in protecting against these issues for now.

Merge imported arguments during test comparison, right now we display each imported argument from each test on new line

number of test allowed for comparison:
Desktop - 4
Mobile - 2

Not sure where this is supposed to come from; it looks like Scheduler+Agent/daytona_sarmonitor was removed in commit 136341b but the docker scripts are still referencing it.

While I appreciate the do-everything scripts that are provided, they are rarely appropriate except for a bare machine that is going to be provisioned purely for daytona. It would be extremely helpful to have the necessary daytona-specific install/config steps listed, with prereqs (but no need for prereq install instructions). For example, where to configure the db name, set up the default schema; what directories should be exposed via php, where the config is for the php files, etc.