yahoo / appdevkit Goto Github PK

Hi, thank you for the awesome AppDevKit.
According to the speak at MOPCON 2017 - AppDevKit x CameraKit
The ADKOpenGLImageView seems to be the rescue for the image rendering performance, will it be available soon ?
Thank you

Need some info in readme about difference between this library and UIAppearance

AppDevKit-1.2.2

• ADKColorWithHexString: handles formats like #RRGGBB, RRGGBB and also 0xRRGGBB (because of NSScanner)
• ADKInitWithHexString: handles the same set of formats

AppDevKit-1.3.0

• ADKColorWithHexString: handles formats like #RRGGBB, RRGGBB, #RGB, RGB
• ADKInitWithHexString: handles formats like #RRGGBB, RRGGBB, 0xRRGGBB

These two methods should align with each other. But not sure how many formats should they support.

• Proposal 1: make both methods support #RRGGBB, #RGB, RRGGBB, RGB salagadoola/AppDevKit@4e72b97...282ef99
• Proposal 2: make both methods support #RRGGBB, #RGB, RRGGBB, RGB, 0xRRGGBB salagadoola/AppDevKit@4e72b97...c69840d

2 category "UIScrollView+ADKInfiniteScrollingView.m" and "UIScrollView+PullToRefreshView.m"
have selector named - (void)willRemoveSubview:(UIView *)subview
it will cause one of them no be called, system will just choose 1 selector to send message

Test code: [[theValue([[UIColor whiteColor] ADKIsEqualToColor:[UIColor colorWithRed:1 green:1 blue:1 alpha:1]]) should] beTrue];

Above test passes when running iOS 9.3 simulator, but fails for iOS 11 simulator.

It is because UIColor creates colors in extended color space (instead of device-dependent RGB) since iOS 10.

如果有一些与众不同的功能，才有动力去用