Code Monkey home page Code Monkey logo

phd's People

Contributors

bradfier avatar kseistrup avatar xvxx avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

phd's Issues

Paths to a .gph not properly routing when arguments are included

When running the current HEAD of master (0.1.13-dev), it appears that some of the examples don't properly work:

Perhaps curl is passing these arguments incorrectly, but I'm also not seeing the arguments properly route when using elinks and sacc either

gopher% cat figlet.gph
#!/bin/sh
echo "hi"
figlet $1
gopher% curl "gopher://localhost:7070/1/figlet"
ihi	(null)	gopher.brokenco.de	70
gopher% curl "gopher://localhost:7070/1/figlet?hi gopher"
3Not Found: /figlet?hi gopher	/	none	70
gopher%

\

cargo install phd fails

when running cargo install phd it fails to build with

error[E0283]: type annotations needed
   --> /home/pi/.cargo/registry/src/github.com-1ecc6299db9ec823/phd-0.1.14/src/server.rs:413:23
    |
413 |             let ord = alphanumeric_sort::compare_os_str(a.path().as_ref(), b.path().as_ref());
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^          ------ type must be known at this point
    |                       |
    |                       cannot infer type of the type parameter `A` declared on the function `compare_os_str`
    |
    = note: multiple `impl`s satisfying `PathBuf: AsRef<_>` found in the `std` crate:
            - impl AsRef<OsStr> for PathBuf;
            - impl AsRef<Path> for PathBuf;
help: consider specifying the generic arguments
    |
413 |             let ord = alphanumeric_sort::compare_os_str::<&T, &T>(a.path().as_ref(), b.path().as_ref());
    |                                                        ++++++++++

For more information about this error, try `rustc --explain E0283`.
error: could not compile `phd` due to previous error
warning: build failed, waiting for other jobs to finish...
error: failed to compile `phd v0.1.14`, intermediate artifacts can be found at `/tmp/cargo-installdyNlCV`

but when building the application from source using cargo build it works perfectly

Allow for disabling colors in log output

Since phd is logging to syslog, the color codes being inserted into the log stream make things very difficult.

I can probably submit a pull request to change this, but to do it sanely, I believe I would want to replace src/colors.rs with https://github.com/ogham/rust-ansi-term and perhaps do some refactoring to allow for color toggling.at runtime.

Are you particularly partial to how colors are logged, or would pretty_env_logger be sufficient for you?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.