xt0rted / block-autosquash-commits-action Goto Github PK

We've been using this action successfully for a while now, and as far as I know, it has always worked just fine for us, but we pretty much only use fixup! commits. Today I added two squash! commits to a PR, and to my surprise the check passed rather than failing as expected.

UPDATE: I added an empty fixup! commit, just to double check that the action would fail, but it didn't. So there may be an issue with the number of commits in the PR (currently at 42) (we don't normally have this many commits in a PR, this is an outlier). We haven't previously had to add the read permission, as outlined in the readme, but I'll try that too, just in case something changed very recently.

UPDATE 2: Nope, still fails with read-permission set explicitly.

Here's a link to the run: https://github.com/Lundalogik/lime-elements/pull/1297/checks?check_run_id=3122228255

As you can see from these screenshots, we're running v2.1.0 of the action, and the two last commits where squash! commits:

This is the section of the workflow file that concerns this job:

name: Pull Request Checks
on: [pull_request]

jobs:

# …snip…

  autosquash:
    name: Block Autosquash Commits
    runs-on: ubuntu-latest
    steps:
      - name: Block Autosquash Commits
        uses: xt0rted/[email protected]
        with:
          repo-token: ${{ secrets.GITHUB_TOKEN }}

# …snip…

Hey @xt0rted , would it be possible to release new version and tag the repo, so we don't need to use @master, which may change possibly every day?

Hey Brian,

first thank you for this action! It is a really useful feature and very easy to use without manually digging into this. ❤️

I just recognized i sometimes use commit-prefixes as 'donotmerge!' to store some dirty stuff, that i don't want to get merged, but that even is no fixup (as there is no base-commit to squash into). So i thought it would be cool, if one could configure somehow for user-specific strings, that do additionally block the PR to get merged!?

Greets! :)
Jonas

Dependabot couldn't find a .yml for this project.

Dependabot requires a .yml to evaluate your project's current Github_actions dependencies. It had expected to find one at the path: /.github/workflows/<anything>.yml.

If this isn't a Github_actions project, or if it is a library, you may wish to disable updates for it from within Dependabot.

You can mention @dependabot in the comments below to contact the Dependabot team.

We have a use case where we consider every commit of a pull request after the first one an autosquash commit, regardless if it has !fixup or !squash. The idea here is we want each pull request to only have a single associated commit, and it is difficult for us to enforce that pull requests always use --fixup or --squash correctly.

Thoughts on adding an optional parameter that changes the behavior so that if a pull request has more than one commit, regardless if it contains !fixup or !squash, that too is considered an error and they must be squashed?