Code Monkey home page Code Monkey logo

Comments (7)

tofi86 avatar tofi86 commented on July 24, 2024

Also, the <test:ws> elements shouldn't be visible, right?

from oxygen-xml-editor-xspec-support.

AlexJitianu avatar AlexJitianu commented on July 24, 2024

Also, the test:ws elements shouldn't be visible, right?

I'm not sure what to do with them... They look like they contain the original spacing/indent but if that's the case I would have expected them to appear for each indent. If I look inside the intermediate *-result.xml file I see one such test:ws element between each two tags from the x:expect element, but in the x:result one there are text:ws elements missing (for example between the and element).

do you have any suggestions? Should I remove, unwrap or keep them as the only indent (and discard the other indent nodes).

from oxygen-xml-editor-xspec-support.

tofi86 avatar tofi86 commented on July 24, 2024

I'm not sure what to do with them... They look like they contain the original spacing/indent

That's what it is indeed: xspec/xspec#227 (comment)
But I also had to learn it in first place...

So what to do? I'm undecided... From a technical point I understand why it's important to have this information around, but from a UX perspective I was (and still am) a bit confused to see it...

Removing all other textnodes and unwrapping the original whitespace nodes seems like a nice idea...

@cirulls @AirQuick do you have an idea? Or should @AlexJitianu just leave the diff as is? I would be fine with it now that I know what the test:ws elements are for... but I could also image the solution mentioned above...

from oxygen-xml-editor-xspec-support.

AirQuick avatar AirQuick commented on July 24, 2024

The whitespace-only text node in test:ws is significant. So it shouldn't be removed.

We could just unwrap it. But the screenshot suggests that the problem happens on oXygen Diff, right? Then I recall that oXygen Diff has Format and Indent Both Files button (which itself is quite useful). If the user hits the button, I'm afraid the unwrapped whitespace-only text node is lost.

Another option might be unwrapping test:ws and replacing its whitespace-only text node with a string just like the HTML report does. In this case, the user may still wonder what this \n\r\t. string is... But I guess at least it isn't too ugly nor lost by Format and Indent.

from oxygen-xml-editor-xspec-support.

neeraj0015 avatar neeraj0015 commented on July 24, 2024

Hi,
For ignoring to test:ws you have to remove extra line and remove new line your input[wrap input element].

from oxygen-xml-editor-xspec-support.

neeraj0015 avatar neeraj0015 commented on July 24, 2024

Also, the <test:ws> elements shouldn't be visible, right?

Hi,
For ignoring to test:ws you have to remove extra line and remove new line your input[wrap input element].

from oxygen-xml-editor-xspec-support.

AlexJitianu avatar AlexJitianu commented on July 24, 2024

I've followed @AirQuick's suggestions and I've replaced test:ws with a string just like the HTML report does. The next plugin build will contain the fix.

from oxygen-xml-editor-xspec-support.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.