Code Monkey home page Code Monkey logo

Comments (7)

AlexJitianu avatar AlexJitianu commented on July 24, 2024

It is something that I've introduced in: Issue 17. I've overridden the template name generation so I can control which templates are invoked through a driver XSLT that imports the compiled XSLT. When I closed the issue I said "the chances for two scenarios to have the same name are pretty slim so I've decided to leave it like this for now". Boy, was I wrong!!!

By the way, is this something that happens quite often? Leaving the same label for multiple scenarios? Or was it just an intermediate step? I know that the label is hardly an ID but I was hoping people treat it a bit like one.

from oxygen-xml-editor-xspec-support.

nkutsche avatar nkutsche commented on July 24, 2024

Ok, I understand. :-)

Well, I think it is not a bad requirement to have unique labels, but:

  1. I took a while, until I found the reason for the duplicated templates. So at least a (Schematron) validtion would help. I think it can happen very easy, during dirty work on your XSpec script (just copy a scenario, make some changes, try it out - and fail, because you didn't change the label...)

  2. In my case I have two scenarios as Test groups and inside I test similar stuff with different sub scenarios. So the sub scenarios have unique labels inside of the group, but not in the whole sheet:

<x:scenario label="group 1">
	<x:scenario label="test 1">...</x:scenario>
	<x:scenario label="test 2">...</x:scenario>
</x:scenario>
<x:scenario label="group 2">
	<x:scenario label="test 1">...</x:scenario>
	<x:scenario label="test 2">...</x:scenario>
</x:scenario>

So one (simple i hope) enhancement would be, to take the nested scenario labels into account for the template names.

from oxygen-xml-editor-xspec-support.

AlexJitianu avatar AlexJitianu commented on July 24, 2024

Both of these points are valid.

  1. I'm sorry for the wasted time... I supposed I could also analyze the exceptions and if the "XTSE0660" code is present I could give a hint about the possible cause.
  2. Yes, I can definitely take the labels of the ancestors into account when generating the ID.
    I'll do these as soon as I have some spare time.

from oxygen-xml-editor-xspec-support.

nkutsche avatar nkutsche commented on July 24, 2024

Thanks Alex! Don't worry about my time. It is normal for me to I try to understand an error, before I post it somewhere. I just wanted to point out, how helpful a validation or a concrete error message would be for this issue.

from oxygen-xml-editor-xspec-support.

nkutsche avatar nkutsche commented on July 24, 2024

Hi Alex,

just an annotation to this. I run in the same problem, if I use x:like for one scenario, which contains other scenarios.

Example:

<x:scenario label="Shared" shared="yes">
	<x:scenario label="Sub scenario">
		<x:expect label="copy">
			<table/>
		</x:expect>
	</x:scenario>
</x:scenario>
<x:scenario label="Scenario 1">
	<x:context>
		<table class="xyz"/>
	</x:context>
	<x:like label="Shared"/>
</x:scenario>
<x:scenario label="Scenario 2">
	<x:context>
		<table class="abc"/>
	</x:context>
	<x:like label="Shared"/>
</x:scenario>

Scenario 1 and 2 are using the scenario "Shared", "Shared" contains other scenarios.

With the Ant XSpec framework it works, with the plugin I get the Duplicate named template error.

Maybe, this should be respected during the fix. I think this is a real case, though it is special. My use case: I have a complex test scenario tree and want to test two different context variants. The differences shouldn't have an influence of the tests.

Best Regards,
Nico

from oxygen-xml-editor-xspec-support.

AlexJitianu avatar AlexJitianu commented on July 24, 2024

It took a lot longer than anticipated but I finally managed to fix (hopefully) the template ID generation.
@nkutsche, if you feel lucky, you can update to the new version :) . If you go to Help->Check for addons updates... you should be able to install the new version. The new version is available at the same update site:
https://raw.githubusercontent.com/xspec/oXygen-XML-editor-xspec-support/master/build/update_site.xml

from oxygen-xml-editor-xspec-support.

nkutsche avatar nkutsche commented on July 24, 2024

Hi Alex,

thanks for the fix! I definitly will update it after my vacation.

Best Regards,
Nico

from oxygen-xml-editor-xspec-support.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.