xsokev / dojo-bootstrap Goto Github PK
View Code? Open in Web Editor NEWAn implementation of the Twitter Bootstrap framework using Dojo.
Home Page: http://xsokev.github.io/Dojo-Bootstrap/
License: Apache License 2.0
An implementation of the Twitter Bootstrap framework using Dojo.
Home Page: http://xsokev.github.io/Dojo-Bootstrap/
License: Apache License 2.0
Please remove references to ../dtk/ in deps
Would it be possible to remove the src
directory so all the relevant scripts are in the root? Then place any build scripts, etc in a build
directory that is ignored in the build profile. It would make it nice and easy to clone dojo-bootstrap directly into my dojo src directory, rather than having to clone, then copy or symlink the src. Keeps it all in once nice structure for easy module loading.
Test in multiple browsers and in non-browser environment.
When choosing a year in the DatePicker module, the value for the year is getting set to zero. This appears to only happen in Firefox so far.
I think it would be great for dojo-bootstrap to be a part of dojo foundation
Would you mind if we tagged a new version on master? v1.0 is quite old now.
Hello,
I downloaded 1.2 version from the site. It does not work. No clue.
The latest code cloned from Git also does not work, with Dojo 1.9.
The examples on the site work. I made a copy of Tab.js and Modal.js from your examples site. Then, my code works perfectly. I believe there is some mismatch with the working copy you have in the site and what is hosted in Git and the tar-ball you have for download.
Can you look into this. I was going to use this seriously, and may have to drop the idea and stick to pure Dojo. I hate to loose the simplicity of bootstrap.
Line 88 in reset of Collapse:
this.domNode.offsetWidth;
is removed with the closure compiler during a dojo build. Assigning it to something would fix that like
this._uselessvalue = this.domNode.offsetWidth;
Without the line the collapse will flickr on chrome and only work once on firefox or IE
Instead of using parser to attach themselves to dom node, it appears that widget modules initialize onDomReady instead trying to sniff out where they should place themselves.
This is not the dojo way of doing things and it prevents doing something like.
Carousel(config, 'foo_node') to create carousel dynamicly.
Everything appears to extend NodeList and mimics jquery behavior instead.
While this project is great and i started using it in errormator.com - long term this approach will get everyone into trouble i fear.
In Typeahead module, the keyup and keydown events don't appear to be firing after he list is displayed. Typing a letter filters the list but the arrow keys do not work.
When hovering over a tooltip for the first time it shows. Each consecutive time, an error message is generated which states, "lastChild" is null or not an object - dojo.js - Line: 15, Char: 93496
I think the postCreate
in Alert.js
should read:
if(!support.falsey(this.timeout) && typeof parseInt(this.timeout, 10) === "number"){
I think it's missing a !
, since it will close if timeout is false.
When a PopOver is used in a Modal widget with a 'click' trigger, it doesn't display on first click again after the Modal dialog is closed and opened again without first closing the PopOver.
See tests/test_Modal.html.
May be a problem with the implementation since the remote is loaded on each button click and the PopOver is set only once.
Hi,
im using dynamic adding for inputs, so will be nice can using "live" events for Datepicker - because now works only with first rendered dom content..
you now what i mean ?
example in pseudocode
not
on('element', 'click', function(){});
but
on(document, 'element:click', function(){});
The data-items attribute is not respected. Using items property when calling typeahead in javascript works fine. Based on the code, the data attributes are not getting passed in as options.
The backdrop appears but the modal dialog doesn't display.
Dropdowns don't dismiss properly when a choice is selected.
I noticed a comment in the code acknowledging this, but I thought an issue might help it from falling through the cracks.
See: https://github.com/xsokev/Dojo-Bootstrap/blob/master/Dropdown.js#L128
Great library, by the way. I started a similar project a while ago and did only enough for the site I was working on. I switched my config to use this one without having to change a single line of client code! I think that is a great endorsement of AMD generally and this library specifically.
Test in IE versions 8+
I tested bootstrap-dojo from their website but I have run the examples. For one example, http://dojobootstrap.com/tooltip# do not appear in tooltips.
I remember more or less a month ago and had tested worked well but not now.
I use Chrome on Linux, Debian 7.
TypeError: setting a property that has only a getter
http://dojobootstrap.com/js/bootstrap/Carousel.js
Line 110
TypeError: setting a property that has only a getter
http://dojobootstrap.com/js/bootstrap/Tab.js
Line 80
This is the behavior in the twitter bootstrap as well.
When viewing a page with the Datepicker module in IE, an exception is thrown upon load.
"Unknown runtime error" line 291, Char 13
The following line of code doesn't appear to work well in IE:
query('.datepicker-days tbody', this.picker)[0].innerHTML = html.join('');
When dropdown is used in Firefox and the arrow keys are used to select items, every other item is selected.
The carousel appears to scroll but not consistently like in other browsers. Appears to be triggered by mouseover instead of pausing on mouseover.
When trying to close an alert in IE, an error message is generated which states,
"'support.trans.end' is null or not an object" Alert.js Line: 65, Char: 13
In my fork I've removed the dojo vendor submodules, because it makes it really difficult to incorporate Dojo-Bootstrap into an existing dojo project.
Usually you'd have a project structure like:
I know it might make the quick-start a little less convenient, but for actual project work the dojo submodules get in the way. Many dojo-bootstrap users are likely to already have a dojo checkout and can symlink it to an appropriate location, or better yet, use a CDN distribution for test & quick-start instead of a submodule.
Let me know if this is acceptable, and I'll create a pull request.
Change dojo.hitch to lang.hitch in Typeahead.js
I'd like to use dojobootstrap instead of jquery for handling bootstrap UI, but I can't get it working. Having in haml :
.nav-collapse.collapse # - tag with menu
and
%a.dropdown-toggle{"data-toggle" => "dropdown", :href => "#"}
Then on the bottom :
:javascript
var dojoConfig = {
async: true,
packages: [
{ name: "bootstrap", location: "/javascripts/vendor/dojo-bootstrap-1.2" }
]
}
= javascript_include_tag "//ajax.googleapis.com/ajax/libs/dojo/1.8.3/dojo/dojo.js"
= javascript_include_tag "site"
Then in site.coffee file
require ["dojo", "bootstrap/Collapse", "dojo/parser", "dojo/domReady!"],
(dojo, Collapse) ->
console.log Collapse # getiing correct class here, but UI doesn't work
Hi,
It appears that no dojo infrastructure for widget control is used in this project at all.
There is no programmatic way of declaring things present.
When using a popover inside of a tooltip, the popover is offset based on the page scrollheight.
Object doesn't support this property or method in IE 8
Typeahead.js Line 213, Char 13
Is there support for the Navbar? Usually it's just CSS but the menu icon that appears when you reduce the width of the screen doesn't pull down the menu items.
When implementing a drop down menu the following Javascript error keeps coming up.
Uncaught ReferenceError: _Dropdown is not defined
After selecting a tab, the content area fail to display.
Bootstrap modal added this functionality in implementation of modal.
Original issue - twbs/bootstrap#531
Original commit - twbs/bootstrap@2f3d04b
I wanted to make a pull request, but accidentally committed changes to event bubbles, and do not know how to make a clean pull request now :-(
My commit is here - gavrilyak@2a78d33
A recent change to add the typeahead dropdown after the input produces a bug if the input is inside a container that has position: relative
. eg
<div style="position: relative;">
<input type="text" data-provide="typeahead">
</div>
I'm not sure the reasoning for moving the dropdown after the input (possibly semantic?), but is it possible we switch back to appending it to the end of the body? That way it isn't under the same influence of relative containers and we don't need "hacks" so that dojo compensates it's positioning.
dojo/on supplies element that matched selector as "this". e.target remains the original target. So e.target will not with inner elements of matched selector.
Twitter bootstrap uses $(this) correctly in such cases.
Fiddle to demonstrate possible issue:
When clicking on "inner" e.target will be "inner" and not "outer" as wanted by selector.
"this" will work correctly in both cases.
is remote modal really working ?
are these lines ok ?
https://github.com/xsokev/Dojo-Bootstrap/blob/master/Modal.js#L52 really know this.element ?
https://github.com/xsokev/Dojo-Bootstrap/blob/master/Modal.js#L223
Hi,
there is a nice list of javascript/jquery components for bootstrap
http://www.bootstraphero.com/the-big-badass-list-of-twitter-bootstrap-resources
maybe will be as inspiration for new components :)
TypeError: setting a property that has only a getter
http://dojobootstrap.com/js/bootstrap/Modal.js
Line 141
the footer of http://dojobootstrap.com/ makes it look like the original bootstrap authors wrote this library.
even the issues link points to their repo and not this project's one.
could you update that footer to point out that dojo-bootstrap is not a twitter project and is maintained by you?
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.