Code Monkey home page Code Monkey logo

Comments (7)

xqms avatar xqms commented on August 26, 2024

Sounds like a good idea. Maybe it could even be the default behavior?

I actually don't like auto-starting the roscore, because it often creates confusion ("Will the roscore still be running if I close this roslaunch instance?"). Keeping the user in explicit control of the roscore avoids these issues. That's why I never got around to implementing an auto-start feature and will probably never do it :-)

Anyway, can you think of some existing application that would break if we would simply wait for the roscore instead of exiting? I think nobody uses rosmon for testing if the roscore is up, so we should be fine...

from rosmon.

romainreignier avatar romainreignier commented on August 26, 2024

from rosmon.

xqms avatar xqms commented on August 26, 2024

I merged #62 which implements exactly this.

from rosmon.

amilcarlucas avatar amilcarlucas commented on August 26, 2024

How do I start a roscore in the launch file. This simple information is messing from the README

I know you feel like it should be done manually by the user. But then please add that information to the README

from rosmon.

xqms avatar xqms commented on August 26, 2024

Hey amilcarlucas,

thanks for your comment. This is a very old issue, it's often better to create a new issue rather than answering to a closed one. I only saw your message by chance.

How do I start a roscore in the launch file. This simple information is messing from the README

The README points to the ROS wiki page, where this is clearly mentioned (differences to roslaunch). And rosmon prints roscore is not runnning. Waiting until it is up (abort with CTRL+C)... during startup to make it clear that nothing is going to happen until someone starts a roscore.

from rosmon.

amilcarlucas avatar amilcarlucas commented on August 26, 2024

My main problem was that by reading the README I got the impression that I could start a roscore by adding a line in the launch file. That is not possible, I now know that. But the information on the README lead me in that direction. IMHO the README can be more explicit regarding that.

from rosmon.

xqms avatar xqms commented on August 26, 2024

@amilcarlucas Since I'm always interested in improving the documentation, can you be more explicit what exactly you misunderstood in the README?

from rosmon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.