Code Monkey home page Code Monkey logo

Comments (2)

xoseperez avatar xoseperez commented on August 16, 2024

Original comment by pjz (Bitbucket: pjz, GitHub: pjz):

I presented you with my first PR ( https://bitbucket.org/xoseperez/hlw8012/pull-requests/2 ), but you wanted a different API than I proposed. I tried to fix it in another PR ( https://bitbucket.org/xoseperez/hlw8012/pull-requests/3 ) but you again expressed dissatisfaction with that API. Could you please present an API you'd be happy with, and I'd be happy to write the code for it? I'd like to get this fixed.

from hlw8012.

NdK73 avatar NdK73 commented on August 16, 2024

Just found a nice device that uses hardwired SEL and ignores CF1: shelly1pf (from shelly.cloud ).
What about just passing an invalid pin (42? :) ) as CF1 pin and SEL pin? Should require minimal changes. Obviously some methods will be useless: is it better to return 'invalid' values or an exception?

from hlw8012.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.