xolox / python-rsync-system-backup Goto Github PK

The actual content of the /usr/sbin/process-vps-backups example file is not shown.
What should be contained in this file?

First of all, thanks for this tool, this is a really convenient way of getting sane backups working quickly :).

I have one suggestion and would send a PR if you agree with the addition: I'd like the datetime format that is used as the directory name of the snapshot to be configurable from the cli. The reason for this is that I am using this on a pretty basic NAS system that exposes the backup folders read only as samba shares, but windows does not allow the colon character in file or directory names that is used as an hour/minutes separator by this script. If this where customizable to e.g. dash then the backups could be directly accessed via SMB. Because this is a NAS system with some weird busybox distribution, this change seems like the most straightforward and maybe others would like to be able to customize the format as well.

If you agree I would add a config option to override the strftime call in

Would you be willing to consider such a PR?

I am not sure whether this is a bug in the code or in the documentation (or both 😅).

This is more or less what I did:

$ mount /dev/sdb1 /data
$ mount /dev/sdc1 /mnt/external
$ rsync-system-backup /data /mnt/external

The "backup" step worked fine. Then the script tried to create a snapshot under /mnt/2017-12-05 15:24:47/, and I get tons of errors like this, since /mnt/external and /mnt/2017*` are on two different disks:

cp: cannot create hard link '/mnt/2017-12-05 15:24:47/...' to '/mnt/external/...': Invalid cross-device link

In general, I'd say that creating the snapshots in the parent directory of the destination is a bit confusing: or, at least, it's not what I'd expect. Maybe it would be better to create them under a special /mnt/external/snaphosts folder, or similar?

Upon installation, the command line interface does not work due to '/proc' missing. I have the proc directory as well.

The error resides in
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/proc/core.py", line 693, in find_processes

Should note that this installation was done by pip install

Hi, this looks great, but when I tried to use it I realised that I needed --copy-dirlinks in there too. And I imagine other people will want other features. So it struck me that a way to pass arbitrary options down to rsync would be nice.

Also, it would be good if the docs included some reference to your python-rotate-backups project - it wasn't until I read that that I understood what was happening.