xmubingo / webp Goto Github PK

It's good news that I get a no-bug webp encoder and decoder for Mac OS 10.5 
today, which I reported its bug on Jan 09 2011.

I'm looking forward to getting the decoders for mobile phones, for I'm willing 
to use webp instead of jpg to transfer image data from server to client.

I've downloaded source codes for unix and windows. But after taking a simple 
look, I thought it seems not easy to transplant to mobile platforms such as 
Android, windows mobile or Iphone for it used libjpeg.

Maybe it's very easy to build a decoder for mobiles, but I haven't found any 
guide docs to do such things.

Could you please tell us whether you have such plan to publish decoders for 
mobiles?
Or could you publish some document to guide us to transplant decoders to mobile 
platforms?

A really bold suggestion, but seeing that GIF had transparency 21 years ago and 
WebP is "something new", I think it's not a bad thing to have share my thoughts 
about it.

I'd like to propose to include a channel for translucency.

What I mean by this is to gain the ability to render the given color on the 
surface diffusely rather than using an opacity, making the underlying surface 
unclear and/or blurry.

To my knowledge this is not yet possible for web-based image formats, and I 
believe it's something which certainly could add value to the web. Right now an 
effect like this could be simulated using, for example, the HTML5 <canvas> 
element.

What steps will reproduce the problem?
1. webpconv -quality 68 bug_padding_byte.png
2.
3.

What is the expected output? What do you see instead?
filesize should 1864, based on the chunk size in the RIFF info.
Actual size is 1863, since it's missing the trailing '0' padding
byte (albeit the RIFF info is correct)

Please use labels and text to provide additional information.

What is the expected output? 
an api

Currently, people have to do bit manipulation

What steps will reproduce the problem?
1. put the libvpx and leptonica files in a directory that contains at least one 
blank
2. follow procedure explained at 
http://code.google.com/speed/webp/download.html#installing
3. watch for the errors to arrive

What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?

libvpx 0.9.2
libleptonica 0.0.2
Windows 7 / Cygwin

Please provide any additional information below.

What steps will reproduce the problem?
1. Build libwebp (in this case)
    $ ./configure
    $ make
2. Decode webp:
    $ examples/dwebp examples/test.webp -o foo.ppm
    Saved file foo.ppm
    Decoded examples/test.webp. Dimensions: 128 x 128.
3. Inspect foo.ppm (attached).

What is the expected output? What do you see instead?
- An image matching supplied test_ref.ppm. Instead, I see a completely garbled 
image.

What version of the product are you using? On what operating system?
- commit f09f96ee3fa24696fd7eb00bd9455c98ed3ca7c6
  Date:   Tue Oct 19 17:16:49 2010 -0400
- OS X 10.5.8, gcc version 4.0.1

If webpconv is built with msys, it requires 2 DLL's
libgcc_s_dw2-1.dll
libjpeg-62.dll

Can webp package be changed to statically link these?

What steps will reproduce the problem?
1. Create a source image with an odd width
2. Attempt to decode with dwebp
3.

What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?
g280c365

Please provide any additional information below.
This change modified VP8Init to use VP8GetByte to read the first 2 bytes from 
the bitstream. This alone looks correct, but has the side effect of setting 
eof_ on the bit reader.
The check in ParseFrame:
 if (dec->br_.eof_ || token_br->eof_) {
will fail on token_br->eof_ with the attached file.

What steps will reproduce the problem?
1. timex webpconv bryce_big.jpg

What is the expected output?
encode roughly same speed as other encoders. ie a few seconds at most

What do you see instead?
93 seconds

timex webpconv bryce_big.jpg
processing bryce_big.jpg
Output file bryce_big.webp
Used quality=85
timex 93936.50ms

Please use labels and text to provide additional information.
webpconv 0.0.5
windows7, nehalem, 32 bit msys exe built with gcc 4.5.0

The current tool webpconv works on linux only. Please provide a version of the 
tool that will work on Windows.

What steps will reproduce the problem?
1. Encode image, e.g. test_ref.ppm
2. Decode resulting WebP file, e.g. mytest.webp (attached)

What is the expected output? What do you see instead?
- On other platforms (e.g. any Intel), libwebp correctly decodes the file.
- On PowerPC, the program executes an Abort trap.
However, on PPC, the same program DOES correctly decode test.webp from the 
distributed examples, but not streams that I encode myself.

What version of the product are you using? On what operating system?

OS X 10.5.8, PowerPC, gcc version 4.0.1

My program (encoding and decoding):
URL: http://www.telegraphics.com.au/svn/webpformat/trunk
Revision: 17

libvpx:
commit 0684c647ef38e81396567720e6fe5a1190e3c103
Date:   Fri Oct 29 11:07:31 2010 -0400

libwebp:
commit f09f96ee3fa24696fd7eb00bd9455c98ed3ca7c6
Date:   Tue Oct 19 17:16:49 2010 -0400


Please provide any additional information below.

The program is a plugin running in Photoshop CS3 PowerPC.

Exception Type:  EXC_CRASH (SIGABRT)

Thread 0 Crashed:
0   libSystem.B.dylib               0x9514fb50 __kill + 12
1   libSystem.B.dylib               0x951eabfc abort + 84
2   libSystem.B.dylib               0x951ddc0c __assert_rtn + 108
3   com.telegraphics.WebPFormat     0x22aa1e18 Transform + 456
4   com.telegraphics.WebPFormat     0x22aa4a18 VP8ReconstructBlock + 632
5   com.telegraphics.WebPFormat     0x22aa7d34 VP8Decode + 2612
6   com.telegraphics.WebPFormat     0x22aa8084 DecodeInto + 436
7   com.telegraphics.WebPFormat     0x22aa8110 WebPDecodeRGBInto + 64

I used this image 
http://www.profiphotos.com/blog/photos/articles/Untersberg/Panorama-BG.jpg (it 
is just random big file from Internet). It have 12830 x 3206, in JFIF 1.02 
format and have 9MB. Uncompressed to PNG it have 46MB.

When trying to convert it to WEBP, webpconv consumes about 1.5GB (gigabytes) of 
RAM, severly slowing my computer (it is 2GB RAM, so started significantly 
swaping).

Config: 32-bit, i386, pentium-m 1.7GHz, Debian Linux/GNU unstable, kernel 
2.6.36-rc5. gcc 4.5.1.

Windows is a high-priority platform requirement
Please provide a downloadable executable for Windows

What steps will reproduce the problem?
1. Follow the instructions
2.
3.

What is the expected output? What do you see instead?
First of all leptonica needs to run ./configure before src/make
After make lib/nodebug is empty which leads to the following error for libwebp
make: *** No rule to make target `../leptonlib-1.066/lib/nodebug/liblept.a', 
needed by `webpconv'.  Stop

What version of the product are you using? On what operating system?

OS X 10.6.4 x86_64

Please provide any additional information below.

I use MacPorts so libvpx is in /opt/local/lib and not /usr/local/lib

What steps will reproduce the problem?
1. type in name of webp in the omnibox

What is the expected output?
see the webp
What do you see instead?
downloads it

chrome currently relies on mimetype, or extension.
Other formats in chrome have a 'sniffer' that looks for a signature.
That should be added to chrome as well for webp.

What steps will reproduce the problem?
1. Figure out how to compile liblept...
2. run 'make' in libwebp/
3. Push button, receive butthurt

What is the expected output? What do you see instead?

Make succeeding.

What version of the product are you using? On what operating system?

Make fails because ld fails:

g++ -Werror -fPIC -o webpconv webpconv.o 
../leptonlib-1.066/lib/nodebug/liblept.a -ljpeg -lpng -lz -lm libwebp.o -lvpx 
-lpthread
webpconv.o: In function `main':
webpconv.c:(.text+0x4a9): undefined reference to `pixReadWebP'
webpconv.c:(.text+0x5c3): undefined reference to `pixWriteWebP'
webpconv.c:(.text+0x9db): undefined reference to `pixWriteWebPwithTargetPSNR'
collect2: ld returned 1 exit status
make: *** [webpconv] Error 1

I'm running a nearly fresh Squeeze installation, with all the libs and dev 
stuff built and installed.

this however is a sign someone's compiling C like its C++!

Please provide any additional information below.

I had to copy .../leptonlib-.../src/liblept.a to lib/nodebug/ to keep the make 
from barking at me.

MaxST compares:
http://img408.imageshack.us/img408/6503/santaorig.png
http://img405.imageshack.us/img405/6784/santawebp90.png

What is the expected output? What do you see instead?
says Monty Montgomery:
The Webp decoder is using chroma pixel doubling for expansion
(which is wrong) instead of proper resampling, which makes it even
worse.

Please use labels and text to provide additional information.

skal says:
the decoder chroma upsampling could be made better, pretty much like the 
-fancy_upscaling mode in jpeg6b

What steps will reproduce the problem?

webpconv duerer.jpg

What is the expected output?
Should work

What do you see instead?
Error in pixWriteWebPwithTargetPSNR: bad or empty input pix

Please use labels and text to provide additional information.
webpconv 0.0.3 on Windows
these converters work:
djpeg -bmp -outfile duerer.bmp duerer.jpg
ffmpeg -i duerer.jpg duerer.png

But these files (which view okay), still fail
c:\work>webpconv duerer.png
processing duerer.png
Output file duerer.webp
Error in pixWriteWebPwithTargetPSNR: bad or empty input pix
pixWriteWebPwithTargetPSNR Failed. See previous error messages. Turn on debug 
build if you aren't seeing enough detailed error messages

c:\work>webpconv duerer.bmp
processing duerer.bmp
Output file duerer.webp
Error in pixReadStreamBmp: invalid imagebytes
Error in pixReadStream: bmp: no pix returned
Error in pixGetInputFormat: pix not defined
Error in pixRead: image not returned
Failed to read image

The image is grey scale
Stream #0.0: Video: png, gray, 90x128

so the bug likely relates to handling of 8 bit images that are not palletized.
converting to rgb first is a work around
ffmpeg -i duerer.jpg -pix_fmt bgr24 duerer.png
c:\work>webpconv duerer.png
processing duerer.png
Output file duerer.webp
Used quality=84

What steps will reproduce the problem?
1. cd /usr/ports/graphics/webp
2. make install
3.

What is the expected output? What do you see instead?

webp to compile and install

compile stops and gives

webpconv.c:265: error: ‘pixWriteWebPwithTargetPSNR’ was not declared in 
this scope

What version of the product are you using? On what operating system?

FreeBSD 8.1 webp 0.4

Please provide any additional information below.

Patch to environ.h required (#include <stdlib.h>: 
http://www.mail-archive.com/[email protected]/msg181428.html

What steps will reproduce the problem?
1. ./configure libwebp on msys

What is the expected output?
configure command should complete, like it does for libwebm

What do you see instead?
Bit9 prevents a.exe from running during the configure.

What version of the product are you using?
git head

On what operating system?
windows7, msys32, gcc 4.2

Please provide any additional information below.
cd /c/src
git clone git://review.webmproject.org/libwebp.git
cd /c/src/libwebp
./configure
$ ./configure
checking for a BSD-compatible install... /bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking build system type... i686-pc-mingw32
checking host system type... i686-pc-mingw32
checking for style of include used by make... GNU
checking for gcc... gcc
checking for C compiler default output file name... a.exe
checking whether the C compiler works... configure: error: cannot run C 
compiled programs.
If you meant to cross compile, use `--host'.
See `config.log' for more details.

What steps will reproduce the problem?
1. remove autom4te.cache files
2. try bz2 instead of gz
3.

What is the expected output? What do you see instead?

Reduction in size of the tar ball, faster download


Please use labels and text to provide additional information.

We need simple and effective smoke test.

Take the official test vectors, extract the first frames,
verify the decoded output sagainst a golden hash values.

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?
'webpconv -ver' can be supported to spit out version number. This helps in 
identifying the binary.

Please use labels and text to provide additional information.

The build instructions:
http://code.google.com/speed/webp/download.html
have not been updated and will not work for Cygwin or Msys if you have Visual 
Studio installed.  Which is typically the case for Windows developers.

For msys
step 4 and 5 require
CXX=mingw32-g++ ./configure -prefix=/mingw

Can you make the webpconv tool allow the output file name to be specified?

Currently, we always set filter to level=0
Would like to have a command-line option to set it to something different.
Default should still be 0

Can you remove the dependency on pthreads?

Windows is a high-priority platform requirement
Please provide a downloadable executable for Windows

What steps will reproduce the problem?
1.  webpconv -format PNG bryce_big.webp
2.
3.

What is the expected output? What do you see instead?
Getting following error trace:

webpconv -format PNG bryce_big.webp
Output format png
processing bryce_big.webp
Output file bryce_big.png
Error in pixReadStreamWebP: WebP decode failed
Error in pixReadWebP: image not returned
Failed to read image

Please use labels and text to provide additional information.

What steps will reproduce the problem?
1. download zip file of sample WebP images
2. unzip in your Picasa image directory
3. attempt to view ... 

What is the expected output? What do you see instead?
I see the .png and .jpg originals 

What version of the product are you using? On what operating system?
Picasa on Linux (Fedora release 13 (Goddard); Picasa 3.0.0 for linux 

Please provide any additional information below.
Thanks...

While working on the javavp8decoder it's useful to be able to get output from 
libwebp/dwebp with no 'loop filtering' applied.

I can imagine a few other situations where this might be useful, such as when 
the output is to be downscaled to generate previews/thumbnails etc where speed 
is important.

It could also provide a set of tests that isolate the filter code.

Are there any plans to add this functionality to the official api?

My current patch is attached.

If you have libgif.a installed, leptonica detects it and makes use of GIF.
But webpconv tool does not link -lgif and produces errors.
Add -lgif to the makefile and it works
Affects cygwin, but could affect any platform that has gif

What steps will reproduce the problem?
1. Follow the instructions
2.
3.

What is the expected output? What do you see instead?
First of all leptonica needs to run ./configure before src/make
After make lib/nodebug is empty which leads to the following error for libwebp
make: *** No rule to make target `../leptonlib-1.066/lib/nodebug/liblept.a', 
needed by `webpconv'.  Stop

BTW. I use MacPorts so libvpx is in /opt/local/lib and not /usr/local/lib

What version of the product are you using? On what operating system?

OS X 10.6.4 x86_64

Please provide any additional information below.

Get msys
http://sourceforge.net/projects/mingw/

attempt to build webpconv tool
$ make
Making all in src
make[1]: Entering directory `/c/src/webp/libwebp/src'
source='webpimg.c' object='webpimg.o' libtool=no \
        DEPDIR=.deps depmode=none /bin/sh ../depcomp \
        g++ -Werror -DPACKAGE_NAME=\"libwebp\" -DPACKAGE_TARNAME=\"libwebp\" -DP
ACKAGE_VERSION=\"0.0.1\" -DPACKAGE_STRING=\"libwebp\ 0.0.1\" -DPACKAGE_BUGREPORT
=\"http://www.http://code.google.com/p/webp\" -DPACKAGE=\"libwebp\" -DVERSION=\"
0.0.1\" -DHAVE_DIRENT_H=1 -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_
H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DH
AVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_STDLIB_H=1 -DHAVE_ST
RING_H=1 -I. -I/usr/local/include -I/usr/local/include/liblept -I/usr/local/incl
ude -I/usr/local/include/liblept  -Wall -O2 -g -O2 -c webpimg.c
../depcomp: ../depcomp: cannot execute binary file
make[1]: *** [webpimg.o] Error 126
make[1]: Leaving directory `/c/src/webp/libwebp/src'
make: *** [all-recursive] Error 1

Provide a binary exe for windows conversion

What steps will reproduce the problem?
1. go to http://code.google.com/speed/webp

What is the expected output? What do you see instead?
information about the compression benefit of WebP

Please provide any additional information below.
pull some text from the blog post and put it there

webpconv.exe nightearth_15000x7500.jpg nightearth_15000x7500.webp

processing nightearth_15000x7500.jpg
Output file nightearth_15000x7500.webp
Error in pixWriteWebPwithTargetPSNR: WebPEncode failed
pixWriteWebPwithTargetPSNR Failed. See previous error messages. Turn on debug 
build if you aren't seeing enough detailed er
processing nightearth_15000x7500.webp
Output file nightearth_15000x7500.webp
Error in fopenReadStream: file not found
Error in pixReadWebP: image file not found
Failed to read image


What version of the product are you using?
0.0.3
On what operating system?
Windows7

webp has link errors against libm.a
There are 2 libm.a: one in mingw and one in msys

c:\MinGW\lib  (/mingw/lib)
03/06/2010  06:31 PM               420 libm.a

c:\MinGW\msys\1.0\lib (/usr/lib)
09/28/2010  04:08 PM         1,269,438 libm.a

Changing
AM_LDFLAGS = -L/usr/X11R6/lib -L/usr/local/lib -L/usr/lib
to
AM_LDFLAGS = -L/usr/X11R6/lib -L/usr/local/lib

in webp\libwebp\src\Makefile.am and webp\libwebp\src\Makefile.in makes it work.

Please fix this in a future release

I understand the statement in the summary is more like opinion, but currently 
webp software package is a total mess from distribution packaging point of 
view. There is no possibility to build libwebp as shared library and in fact 
leptonica depends on it, while on the other hand webpconv depends on leptonica. 
Thus, in order to get things well done the one had to:

1. Build only libwebp as shared library (and eventually distribute it as a 
package);
2. Patch leptonica with the modifications found in the webp package and rebuild;
3. Build only webpconv and link it against the patched leptonica lib.

What steps will reproduce the problem?
n/a

What is the expected output? What do you see instead?
 - Having libwebp, leptonica patch and webpconv utility distributed separately;
 - Having libwebp properly built as static, shared or both libraries, proper check for dependencies and link to libvpx;
 - Having leptonica patch include detection of libwebp (in configure) and build related changes accordingly;
 - Having webpconv properly build as dynamic executable, linking to libweb and leptonica.

What version of the product are you using? On what operating system?
webp-0.0.1 and webp-0.0.2 on Slackware Linux 13.1

Please provide any additional information below.
I've already done some build scripts tweaking and could provide my patches. I'm 
also able to help with other tasks, such writing builds scripts, modifying 
sources and configure scripts.

What steps will reproduce the problem?
1. webpconv -format PNG abc.webp
2.
3.

What is the expected output? What do you see instead?
The expect3ed output is the converted image in PNG format

Get error:
Error in pixReadStream: Unknown format: no pix returned
Error in pixGetInputFormat: pix not defined
Error in pixRead: image not returned
Failed to read image


Please use labels and text to provide additional information.

Can you provide a Visual C build of webpconv?
This would produce a faster executable, allow debugging with Visual Studio, and 
providing binaries that run natively on Windows without cygwin or msys 
(libgcc_s_dw2-1.dll) DLLs.

What steps will reproduce the problem?
1. cd webp/libwebp/src
2. ./webpconv -quality 42 /images/*.jpg
3. the jpg files are about 200k, and the webp files are about 2m,which are 
about ten times bigger than the jpg files.

What is the expected output? What do you see instead?
I want to get smaller webp files than jpg. Does webpconv support jpeg files?

What version of the product are you using? On what operating system?
webp-leptonica-0.0.5.tar.gz, Mac OS 10.5

Please provide any additional information below.
My test jpeg images are 2048*1024 pixels, and has compressed 40% from png. I 
have attached one file -- test.jpg.

What steps will reproduce the problem?
1. webpconv -format WEBP abc.png
2.
3.

What is the expected output? What do you see instead?
if abc.webp is already present, we get following message:

webpconv abc.png
processing abc.png
Output file abc.webp
Output file exists. You may change the output_dir

Please use labels and text to provide additional information.

What steps will reproduce the problem?
1. Go to http://wvnvaxa.wvnet.edu/vmswww/bmp.html
2. pick a bmp image that is not 1 bit or 32 bit bmp
3. run webpconv to convert the bmp image to WEBP

What is the expected output? What do you see instead?

Expected is conversion succeeds. But actually the conversion fails.

Please use labels and text to provide additional information.

$ tar xf webp-leptonica-0.0.2.tar.gz
tar: webp/libwebp/depcomp: Cannot create symlink to 
`/usr/share/automake-1.10/depcomp': No such file or directory
tar: webp/libwebp/install-sh: Cannot create symlink to 
`/usr/share/automake-1.10/install-sh': No such file or directory
tar: webp/libwebp/missing: Cannot create symlink to 
`/usr/share/automake-1.10/missing': No such file or directory
tar: Error exit delayed from previous errors


$cd /c/src/webp/libwebp
$ ./configure
configure: error: cannot find install-sh or install.sh in "." "./.." "./../.."

Example:

   cwebp bad.png -o foo.webp

where 'bad.png' is an erroneous file (doesn't exist, isn't PNG, etc.) 

One shouldn't create a foo.webp empty file
Instead: foo.webp is created and has a size of 0.

What steps will reproduce the problem?
1. Follow the instructions
2.
3.

What is the expected output? What do you see instead?
First of all leptonica needs to run ./configure before src/make
After make lib/nodebug is empty which leads to the following error for libwebp
make: *** No rule to make target `../leptonlib-1.066/lib/nodebug/liblept.a', 
needed by `webpconv'.  Stop

What version of the product are you using? On what operating system?

OS X 10.6.4 x86_64

Please provide any additional information below.

I use MacPorts so libvpx is in /opt/local/lib and not /usr/local/lib

What steps will reproduce the problem?
YUV420toRGBA() creates a RGBA bitmap with the alpha channel set to 0x00.  If 
the alpha channel is respected, the image is wholly transparent.

What is the expected output? What do you see instead?
Expected an RGBA image, get nothing visible.

What version of the product are you using? On what operating system?
Initial release of libwebp compiled for AmigaOS 4.1 (PowerPC)

Please provide any additional information below.
The below shows my fix for this issue, to set the alpha channel to 0xff instead 
of 0x00.
Diff against original webpimg.c:

--- Copy_of_webpimg.c   2010-10-02 13:46:53 
+++ webpimg.c   2010-10-02 13:46:39 
@@ -150,7 +150,7 @@ static void ToRGB(int y, int u, int v, u
   const int r = kClip[y + r_off - RGB_RANGE_MIN];
   const int g = kClip[y + g_off - RGB_RANGE_MIN];
   const int b = kClip[y + b_off - RGB_RANGE_MIN];
-  *dst = (r << RED_SHIFT) | (g << GREEN_SHIFT) | (b << BLUE_SHIFT);
+  *dst = (r << RED_SHIFT) | (g << GREEN_SHIFT) | (b << BLUE_SHIFT) | (0xff << 
ALPHA_SHIFT);
 }

 static inline uint32 get_le32(const uint8* const data) {

In my opinion, webp is most useful on mobile network application, for the 
wirlesss network speed is so low.

But it seems not easy to implement decoding on Java platform such as j2me for I 
haven't found anything about Java version of VP8 decoder.

Is there anyone know more about it? 

Thank you for your advice in advance.

Implement a WIC component so Windows Explorer and various tools can decode WebP