Code Monkey home page Code Monkey logo

isbnlib-loc's People

Contributors

dependabot[bot] avatar xlcnd avatar

Stargazers

 avatar

Watchers

 avatar  avatar

isbnlib-loc's Issues

Possible improvement: use marcxml or mods schema instead of dc

Hello,
I have not done any extensive testing, but with the three ISBNs provided in the test_metadata.py file, only one returns a complete result:

9780321534965 --> ok! all fields are found
9781118241257 --> no publisher nor year (ok if we use goob)
9780425284629 --> no publisher nor year (no publisher if we use goob)

Indeed, I checked that in _loc.py the SERVICE_URL asks for &recordSchema=dc and the info returned does NOT contain the publisher/date fields for those two ISBNs!
9781118241257 with dc
9780425284629 with dc
It's not that the parser is failing: the record is incomplete!

However, if you ask for &recordSchema=marcxml, both entries contain the publisher and year.
9781118241257 with marcxml
9780425284629 with marcxml

Again, I don't know how often this is a problem, or if there any deeper reasons to use the dc schema, but perhaps it deserves another look to consider changing the schema and parser.
There is a pymarc project in PyPi that maybe could be used to parse the marcxml result.
The LoC also offers the newer MODS schema that contains all the info correctly in the examples above. So that could be used if it is preferred over MARCXML.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.