There seems to be a problem with Vaadin 24:
When the datepicker is clicked the underlying dialog is instantly closed, which will result in not setting the date

Related to #54
Clarifies that the value is used once initially.

The default implementation of clear in HasValue uses the default getEmptyValue, which is null. I am not sure what should happen if clear is called, but a NPE should never occur. I think it should jump back to the defaultModel.

java.lang.NullPointerException: null
	at software.xdev.vaadin.daterange_picker.ui.DateRangePicker.tryFixInvalidModel(DateRangePicker.java:355) ~[vaadin-date-range-picker-2.0.0.jar:2.0.0]
	at software.xdev.vaadin.daterange_picker.ui.DateRangePicker.updateFromModel(DateRangePicker.java:333) ~[vaadin-date-range-picker-2.0.0.jar:2.0.0]
	at software.xdev.vaadin.daterange_picker.ui.DateRangePicker.setValue(DateRangePicker.java:501) ~[vaadin-date-range-picker-2.0.0.jar:2.0.0]
	at software.xdev.vaadin.daterange_picker.ui.DateRangePicker.setValue(DateRangePicker.java:63) ~[vaadin-date-range-picker-2.0.0.jar:2.0.0]
	at com.vaadin.flow.component.HasValue.clear(HasValue.java:179) ~[flow-server-2.4.2.jar:2.4.2]

Hey,
Currently, for the SimpleDateRange Quarter, it is not possible to select a start date which is after the current quarter. This can only be done through the end date. I think for usability it should be possible to select the quarter also over the start date.
I don't know if this is limited by the 'calcForFunc' which only uses one date and not both.

Related to #48

Currently the Vaadin Datepicker is very limited.
For example it doesn't support a date format → vaadin/flow-components#911

However there are some solutions for this problem:

• EnhancedDatePicker which like the normal Datepicker also extends from GeneratedDatePicker (and is now licensed under Apache 2)
• https://cookbook.vaadin.com/date-picker-pattern

To make them work a supplier (with GeneratedDatePicker) or two - for start and end - is required.

While working with the JAR I noticed that it has >3MB.

After further investigation I found out that the META-INF/VAADIN folder is huge (unpacked 12MB!)

There are similar add-ons that ignore this complete folder and work fine:
https://github.com/syampillai/SOCharts/blob/4209566c3ea431cda30e1e305966b5defa6a1869/pom.xml#L234

Is this intended that the latest release is not published?
Maybe related: https://github.com/xdev-software/vaadin-date-range-picker/actions/runs/6107939550

Hey,
The DateRangePicker could implement the HasValue interface. Some methods for it are already implemented. The get/setValue methods can apply to the current DateRangeModell.

Hey,
While working with the component I discovered some typos. I am not sure If there are more of them, but it should be checked:

• Model is spelled with only one L in English.
  

  vaadin-date-range-picker/vaadin-date-range-picker/src/main/java/software/xdev/vaadin/daterange_picker/buisness/DateRangeModell.java

  Line 33 in 06fb526

  public class DateRangeModell<D extends DateRange> implements DateRangeActions<D, DateRangeModell<D>>

• Missing T for settable (variable is named correctly)
  

  vaadin-date-range-picker/vaadin-date-range-picker/src/main/java/software/xdev/vaadin/daterange_picker/buisness/AbstractDateRange.java

  Line 108 in 06fb526

  public SELF withSetable(final boolean settable)

Hi XDEV,
I have tested today your component. First of all, it's great!

But while developing I discovered some problems with translating the component:

1. If I apply another dateRangeLocalizerFunction, it is never called. The set of the LabelGenerator is called in initUI of DateRangePickerOverlay, which is called on constructor invocation. So the change afterward doesn't have any effect.
   

   vaadin-date-range-picker/vaadin-date-range-picker/src/main/java/software/xdev/vaadin/daterange_picker/ui/DateRangePickerOverlay.java

   Line 95 in 06fb526

   this.cbDateRange.setItemLabelGenerator(this.dateRangePicker.getDateRangeLocalizerFunction());

It should be applied like the translation for the DatePickers in the AttachEvent.
I could create a pull request for this.

2. I think there could be a more uniform way to access the labels of the DatePickers and the Combobox. This is only a suggestion. I discovered these while using this component. Some documentation/tutorial could also help here.

I am also from Germany, so we could communicate in german. Feel free to contact me.

Best regards,
Dario

Provide a live online demo

Hey,
The dark theme support for lumo seems to be broken:

Hey,
I was searching for a way to set the default DateRange. With the way, I was thinking, I ended up with getting the current model and setting the DateRange to it. Now I was digging through the code and saw the method which (I think) is meant to be used for this setModellForTodayAndByDateRange. The first time I saw this method, it was curious to me. I would simply name the method 'setDateRange' and maybe overload it with a version to supply the LocalDate by yourself. The explanation should be done with some JavaDoc.

A faster accessor for the current DateRange would be also nice. So you can call it simply at the DateRangePicker to get the current value. In general, it may make sense to pass through the accessor methods of the model. It's just an idea, I am happy to discuss this.

Firstly, thanks for the fixes and updates to the DateRangePicker. I really appreciate it 👍.

Description

The DRP overlay closes if you are clicking out of the DatePicker overlay back into the DRP overlay or on another component. This does not happen if it is closed with a selection or close action.

GIF