Code Monkey home page Code Monkey logo

ha-samsungtv-custom's Issues

invalid syntax

Hi,

When using your solution or trying it out, it throws the following error:

Logger: homeassistant.core
Source: custom_components/samsungtv_custom/media_player.py:14
First occurred: 15:52:16 (1 occurrences)
Last logged: 15:52:16

Error executing service: <ServiceCall homeassistant.restart (c:6eef5718ccf37a926aaa64f9d6679f14)>
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/core.py", line 1504, in catch_exceptions
    await coro_or_task
  File "/usr/src/homeassistant/homeassistant/core.py", line 1523, in _execute_service
    await handler.job.target(service_call)
  File "/usr/src/homeassistant/homeassistant/components/hassio/__init__.py", line 449, in async_handle_core_service
    errors = await conf_util.async_check_ha_config_file(hass)
  File "/usr/src/homeassistant/homeassistant/config.py", line 885, in async_check_ha_config_file
    res = await check_config.async_check_ha_config_file(hass)
  File "/usr/src/homeassistant/homeassistant/helpers/check_config.py", line 204, in async_check_ha_config_file
    platform = p_integration.get_platform(domain)
  File "/usr/src/homeassistant/homeassistant/loader.py", line 499, in get_platform
    cache[full_name] = self._import_platform(platform_name)
  File "/usr/src/homeassistant/homeassistant/loader.py", line 504, in _import_platform
    return importlib.import_module(f"{self.pkg_path}.{platform_name}")
  File "/usr/local/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 783, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/config/custom_components/samsungtv_custom/media_player.py", line 14, in <module>
    from samsungtvws import SamsungTVWS
  File "/usr/local/lib/python3.8/site-packages/samsungtvws/__init__.py", line 22, in <module>
    from .remote import SamsungTVWS
  File "/usr/local/lib/python3.8/site-packages/samsungtvws/remote.py", line 147
    header={"connection": "Upgrade"}
    ^
SyntaxError: invalid syntax

Not seeing TV as an entity | Channel up and channel down by default

As per the title, the TV is not seen as a device in home assistant, you can see it as a media player through the special card but it would be better to have it as a device in my opinion.
This brings me to the second problem, which is that you don't have direct control of the channels through special buttons in the media player.
I believe that the media player card does not support the channel changing function, so it would be nice to have an appropriate car with the main TV controls:

- power on / power off
- volume up / volume down
- mute
- channel up / channel down
- info
- Backwards
- play / pause / forward / backward
- arrows dial
- enter button
- source change

https://github.com/marrobHD/tv-card
This would be a card I could draw on.

Thank you for your attention

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.