xavier / european_vat Goto Github PK

Hi there,

it seems like there is a mix-up with the way must_charge_vat? works (or at least the way it’s described in your Readme):
You write:

# Buyer and seller in different EU countries, VAT number present
EuropeanVat.must_charge_vat?("NL", "BE", "BE0829071668")
# true

# Buyer and seller in different EU countries, no VAT number
EuropeanVat.must_charge_vat?("NL", "BE", nil)
# false

Actually the opposite is true. If buyer and seller are in different EU countries and they are both businesses (i.e. have a VAT number), no VAT has to be charged. EuropeanVat.must_charge_vat?("NL", "BE", "BE0829071668") should thus return false.
If, on the other hand, the buyer is an end-customer (i.e. with no VAT number) from another country, their local VAT rate has to be applied; EuropeanVat.must_charge_vat?("NL", "BE", nil) should return true.

To quote from the EU website:

If you sell goods to another business and these goods are sent to another EU country, you do not charge VAT - if the customer has a valid VAT number.

Thanks for sharing this code!

I wondered: are you still actively using this code in production for VAT calculations? Is the code mostly up-to-date?

Many thanks!