xapi-project / xcp-rrd Goto Github PK

It seems xcp-rdd package outdated in https://github.com/ocaml/opam-repository/tree/master/packages/xapi-rrd

The interface between this library and other libraries and programs is currently unclear. I suggest we start fixing this by:

• auto-generate an .mli
• move the obviously .mli comments from the .ml into the .mli
• experimentally hide functions and see if opam downstream packages still build, hide function if so
• study code and cook up some docs for the remaining undocumented functions
• review the result and see if it needs further refactoring

Building xcp-rrd from master branch failed with:

File "lib/rrd.ml", line 61, characters 4-17:
61 | let cf_init_value = function
^^^^^^^^^^^^^
Error (warning 32): unused value cf_init_value.
File "lib/rrd.ml", line 436, characters 32-33:
436 | rrd_rras = Array.mapi (fun i rra ->
^
Error (warning 27): unused variable i.

xapi-rdd.log