The source code for the trade tariff is now managed by HMRC.

https://github.com/trade-tariff/trade-tariff-backend

https://govuk-digital-services.herokuapp.com/projects/trade-tariff

Looks like id attributes are missing from the relevant headings on the home page.

Would it be possible to add a tab alongside the current "By Organisation" which allows the user to filter and/sort results by the service lifecycle types, i.e. Discovery, Alpha, Beta, Live including those that are inactive (paused), e.g. Clinically Extreme Vulnerable People Service or fully decommissioned.

👀

The list of categories has been unchanged for many many years (apart from the addition of covid), and needs a review. It’s mainly based on the GOV.UK taxonomy, but there's a been a few tweaks to that. It could either get updated base on the GOV.UK one, or we could deviate.

Be nice if the numbering on this list matched that on the original list.

I remembered that we added a /services finder to GOV.‌UK site search in 2019, which lists ~7,300 services currently. Should this list be reviewed at some point for possibly adding to the x-gov list?

This is more of a discussion than an issue, sorry @frankieroberto!

The data page links to a JSON representation of all the data, but it'd also be useful to link to a CSV version, to make it easier to import into a spreadsheet.

Where there can be multiple values (eg synonyms, organisations, start pages, etc), we’ll have to decide between:

• creating separate columns (eg org1, org2, org3) and accepting that some of these will often be blank
• using a separate like | or a ; to separate multiple values within a column

Thoughts welcome!

Problem

1. It’s not clear how screenshots should be added. Digging into the npm scripts you can find a script called screenshots, and running that you get help about the sub commands.

2. To take a screenshot for 1 service, it looks like you can use npm run screenshots <filename>, but it's not clear what filename should be. Should it be npm run screenshots sorn, or npm run screenshots /app/services/sorn or something else?

3. Running the command to either update screenshots for all services or 1 service produces an error:

   /Users/paulrobertlloyd/Sites/govuk-services/node_modules/puppeteer-core/lib/cjs/puppeteer/util/assert.js:28
           throw new Error(message);
                 ^
   
   Error: An `executablePath` or `channel` must be specified for `puppeteer-core`
       at assert (/Users/paulrobertlloyd/Sites/govuk-services/node_modules/puppeteer-core/lib/cjs/puppeteer/util/assert.js:28:15)
       at ChromeLauncher.computeLaunchArguments (/Users/paulrobertlloyd/Sites/govuk-services/node_modules/puppeteer-core/lib/cjs/puppeteer/node/ChromeLauncher.js:79:36)
       at async ChromeLauncher.launch (/Users/paulrobertlloyd/Sites/govuk-services/node_modules/puppeteer-core/lib/cjs/puppeteer/node/ProductLauncher.js:83:28)
       at async /Users/paulrobertlloyd/Sites/govuk-services/tasks/screenshot-services.js:84:19

4. Looks like there are some additional dependencies on the project which are not documented. Digging into tasks/screenshot-services.js, the script is looking for GOOGLE_CHROME_PATH environment variable. Where should this be set? What should it point to?

5. Are any further settings needed for the screenshot scripts to work?

Solution

• List project dependencies, and how to install
• Document screenshot commands in the README, and provide relevant examples
• Is the above an error, or a problem with not having everything set up correctly?
• Provide an example of what value to provide for GOOGLE_CHROME_PATH, and how to set it. Perhaps add a project like dotenv and add an example .env.example file.

Currently we have a check which makes sure the JSON files are valid JSON and tidied, but no schema. This means that typos can creep in. There’s also no consistent order to the keys in the JSON files.

Ideally there would be some kind of schema, and then a check would run against it when opening PRs. The keys could be automatically re-ordered to be consistent too.

A simple search box could let you quickly find a service, also using the synonyms, with an autocomplete. Something similar to the one on the Design System website?