wuvt / jtr Goto Github PK
View Code? Open in Web Editor NEWJack the Ripper Interface
jtr's People
Contributors
Watchers
jtr's Issues
client: fix "minor error" report timeout
it takes 1-2 minutes before whipper starts doing something interesting; sleep at least that long rather than gratuitiously reporting "minor error"
client: report error on inaccurate rips
need to parse that last secion reporting tracks after whipper exits
Using configured read offset 12
Checking device /dev/sr0
Reading TOC...
CDDB disc id: 8b08990a
MusicBrainz disc id Kk9PG7qexqJGSVb.8lW3NosBWQA-
MusicBrainz lookup URL https://musicbrainz.org/cdtoc/attach?toc=1+10+165260+150+15655+29055+39427+50695+68375+85820+96715+118177+145280&tracks=10&id=Kk9PG7qexqJGSVb.8lW3
NosBWQA-
Disc duration: 00:36:41.466, 10 audio tracks
Matching releases:
Artist : Vampire Weekend
Title : Contra
Duration: 00:36:41.184
URL : https://musicbrainz.org/release/936707a6-3095-38cb-9261-329e0e246fd4
Release : 936707a6-3095-38cb-9261-329e0e246fd4
Type : Album
Barcode : 634904042929
Cat no : XL CD 429
creating output directory /home/ladmin/be76108f-fb30-4a48-ac02-5c7dec85ed1c/album/Vampire Weekend - Contra
Ripping track 1 of 10: 01. Vampire Weekend - Horchata.flac
<!--snip-->
track 1: rip NOT accurate (max confidence 200) v1 [b478c13a], v2 [b2f4ff09], DB [dd7163f1]
track 2: rip NOT accurate (max confidence 200) v1 [35c8e12c], v2 [23a325ca], DB [6447118d]
track 3: rip NOT accurate (max confidence 200) v1 [19b2830d], v2 [6fbb0ace], DB [bbc0fc6e]
track 4: rip accurate (confidence 2 of 200) v1 [c90a8d32], v2 [ff73842a], DB [c90a8d32]
track 5: rip NOT accurate (max confidence 200) v1 [e88f4a26], v2 [8ca43311], DB [ac99e11b]
track 6: rip accurate (confidence 2 of 200) v1 [802049d6], v2 [15d340c3], DB [802049d6]
track 7: rip NOT accurate (max confidence 200) v1 [7a68154d], v2 [8a8af49e], DB [61bfe43a]
track 8: rip accurate (confidence 2 of 200) v1 [d25d622a], v2 [2efb103f], DB [d25d622a]
track 9: rip NOT accurate (max confidence 200) v1 [8bde388c], v2 [3db82dbe], DB [3bf7b26d]
track 10: rip NOT accurate (max confidence 200) v1 [d0f7e793], v2 [ed4f756b], DB [9bb62c5e]
cd-paranoia+whipper will happily keep reading for hours. This is a huge loss in efficiency
cd-paranoia+whipper will happily keep reading for hours if the disc has too many "correctable" errors (even if a pure CD player will happily play it). This is a huge loss in efficiency. We should put in a timeout and exit with an error encouraging re-rip.
server: fix single-page issue; reload shouldn't cause a re-post of data
when I hit f5 with the main page of the server open, my webbrowser tries to repost the data. it shouldn't do this. suggested solution is to accept post at a different endpoint and redirect
more supported error codes
types of errors:
- innacurate rip (acceptable)
- CRC checks failed: incomplete rip (possibly acceptable; re-rip)
- Rip timeout: incomplete rip (possibly acceptable; re-rip) (depends on #8 )
- drive failure -- not experienced
- uncategorised whipper failure (e.g. #2 )
We should probably have the client detect, log, and report each of these differently. This will require an API change
make a readme
should cover basic setup, and what this does
CSRF everywhere
All POST endpoints are vulnerable to cross-site request forgery. You should mandate that an additional header such as X-Requsted-With to be added to every request and check that it is present when processing.
client: report error for whipper failure
e.g. we found a CD that triggers whipper-team/whipper#215; should report "error"
in design discussions, we said we wouldn't make barcode unique. this implementation does enforce that as a constraint
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.