Feature request: optional domain attribute to tag, or as a configuration parameter about wro4j-runtime-taglib HOT 11 CLOSED

I'm not sure that I understand but it seems to me that built-in wro4j model interpolation might be exactly what you are looking for.

from wro4j-runtime-taglib.

That one would allow me to prefix included resources in a group to load them from different places, but what I need is to have output from the Script/StylesheetTag like

<script src='//keycdn-14576.keycdn.com/resources/core-52b380f59cd70730bccbf2da93a87595.js'>  
</script>

if I use the script tag like

<c:set var="cdn" value="//keycdn-14576.keycdn.com" />
<!-- spring profile dependent -->
<wro:script group="core" prefix="${cdn}" />

from wro4j-runtime-taglib.

Does it make sense to make it application-wide or you need a more fine-grained control over your resources?
e.g. I might support something like

resourceDomain=//keycdn-14576.keycdn.com

in wro.properties. This would affect all resources though

from wro4j-runtime-taglib.

This would be sufficient in my case, since we load all css/js resources from the cdn.

from wro4j-runtime-taglib.

Alright, changes are on resourceDomain branch. Tests are green but I didn't have a chance to test it on actual CDN so I would keep it there for a while.

from wro4j-runtime-taglib.

Ok, it works well, if configured in the wro.properties file. However, when configuring through spring, wro.properties might be loaded from elsewhere, eg. if using a different wro.properties file depending on the deployment profile.

See eg. https://groups.google.com/forum/#!msg/wro4j/GUQ9zmDDVbw/E0VzlrC7dEUJ

I'm not sure what's the best approach here. Would it be possible to retrieve the configuration properties from the wroManagerFactory?

from wro4j-runtime-taglib.

You might override ConfigurableWroManagerFactory#newConfigProperties.
e.g. you may store common properties in wro.properties and put all environment-specific properties in wro-{environment}.properties. Then you might load them based on current spring environment profile

from wro4j-runtime-taglib.

True, but I still can't override resourceDomain only for the production environment, since it's loaded using ServletContextPropertyWroConfigurationFactory which fetches the wro.properties file from a hardcoded location.

from wro4j-runtime-taglib.

Right, I forgot that there is no such thing as single source of properties in wro4j.
I should probably introduce something like Wro4jManagerFactory to taglib.
In the mean time, you might fallback to something like this.

from wro4j-runtime-taglib.

Ok, I might use a workaround for now. The current setup I've got is pretty good at the moment.

from wro4j-runtime-taglib.

Closing this one for now as I'm going to include current implementation in 0.2.0 release. Feel free to reopen it

from wro4j-runtime-taglib.