Comments (5)
lifus
commented on July 1, 2024
TaglibContext is not designed for extension. I would rather use some DI framework than make TaglibContext non-final.
Anyway, what dependencies do you want to inject into TaglibContext? Is it connected to #2?
from wro4j-runtime-taglib.
tveimo
commented on July 1, 2024
Yes, #2. I currently need to call TaglibContext.initialize() since the tag classes uses TaglibContext and it can't be subclassed.
Did you get any further on #2 (comment) ? That would solve my issue I guess.
I currently call TaglibContext.initialize() in my WroManagerFactory spring bean method, and have a locally patched ResourceUriCacheInitializer to use my local OptimizedResourcesRootProvider.
I can't currently use the TaglibContextListener as it gets activated too early before spring has set everything up.
I can provide more details if you like.
from wro4j-runtime-taglib.
lifus
commented on July 1, 2024
Did you get any further on #2 (comment) ?
Yes, It's already on master branch. I updated README accordingly. Patching shouldn't be required anymore for the future versions. If it works for you, I would probably release v0.2.0 sometime soon.
from wro4j-runtime-taglib.
tveimo
commented on July 1, 2024
Yes this works very well!
from wro4j-runtime-taglib.
lifus
commented on July 1, 2024
Great, I'm closing this one for now then.
from wro4j-runtime-taglib.
Related Issues (9)
- Add Maven Central badge to README HOT 1
- Configure taglib with spring HOT 10
- Initialisation fails when WroFilter is not of type ro.isdc.wro.http.WroFilter HOT 1
- recurring no context problem HOT 3
- Track code coverage with codecov
- Update dependencies for 0.2.0 release HOT 1
- Feature request: optional domain attribute to tag, or as a configuration parameter HOT 11
- hash not updating when css content changes HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wro4j-runtime-taglib.