wrenger / schiller-lib Goto Github PK

When somebody is adding a user, automatically look if that user is a iServ account. When it is not, don't let to add the user (maybe give a list with similar iserv users). (Students are getting their iServ account directly when enrolling in school)

The frontend sends too many and duplicate/unneeded requests on fast list scrolling, here a Pic:

(The rows with the same color are duplicate/unneeded requests)

Sadly, I cannot really recall in your code whats causing this but I think this should be fixed.

We should think about crash consistency for the in-memory database. This requires atomic file updates which can be achieved by writing to a tempfile and atomically renaming it to our real file, overwriting it.

See: https://docs.rs/tempfile/latest/tempfile/struct.NamedTempFile.html#method.persist

Automatically delete Users that don't have iServ accounts.

Convert the Project to Godot 4.

I think we're pretty finished with the rework, only the README isn’t finished yet. We should be making the rework branch the default and the main the old/deprecated branch and shouldn't be merging rework into main. What do you think?

A lot of younger students are using ä, ü and ö. We have to auto convert them when somebody creates a user because iServ uses ae, ue and oe for umlauts.

All dates are shown in US format even on German Systems.

The benutzer.txt file was read wrongly and the user's was updated(Grade) wrongly. Has something with the formatting of the benutzer.txt.

The Update User Roles doesn't work correctly. Please fix (idk why).

I am getting an error when I want to send mails using the "/api/notify" route:

The data which I am sending:

{
    "account":"nils.wrenger",
    "subject":"'\"... und mich - mich ruft das Flügeltier\"' ist nun verfügbar!",
    "body":"Hallo Nils Wrenger,\nDu hast dich für das Buch '\"... und mich - mich ruft das Flügeltier\"' interessiert.\nDas Buch war ausgeliehen und liegt nun wieder in der Schülerbücherei.\nWenn du willst, kannst du es jetzt ausleihen.\n\nViele Grüße vom Schülerbüchereiteam."
}

The console of the Server:

2023-11-02T18:06:46.739156Z  INFO schiller_lib::db::structure: Start migration of 0.8.3
2023-11-02T18:06:46.739262Z  INFO schiller_lib::db::structure: Applying patch 0.8.4
2023-11-02T18:06:46.741374Z ERROR schiller_lib::server::auth: SECURITY: Missing OAuth configuration!
2023-11-02T18:10:44.205167Z ERROR schiller_lib::mail: Invalid Mail Address InvalidUser
2023-11-02T18:10:44.205269Z ERROR tower_http::trace::on_failure: response failed classification=Status code: 500 Internal Server Error latency=0

The Server response to the client:

Arguments

which is equal to Error::Arguments

I would like to have the total count of the elements in server requests for arrays, which also can be limited. For example for the book list so that I can display something like: Loaded 250 of 2291 Results.

The current way of fetching user data from a large CSV file (generated by ISERV) might not be sufficient for a web server anymore.

We could use the ISERV API directly to fetch usernames and emails. However, we then would specifically depend on ISERV, and schools without ISERV couldn't use this project.

The alternative would be to keep the CSV import and specify a path for this file when starting the webserver. In the UI, we only need a button to update all roles from the user file.

Can the Server please send on errors fitting data for translations, the current translations can be found here: locales.

A lot of users are confused about the dates, which are English dates. We have to add German dates.