We just need to run chmod +x frccode2020 on the frccode file in Git.

Currently, its not selectable, which means it might download to the ISO directory on windows, or the app directory on mac, which is a problem.

Stacktrace:

System.TypeLoadException
   at MessageBox.Avalonia.Views.MsBoxStandardWindow.!XamlIlPopulate(IServiceProvider , MsBoxStandardWindow )
   at MessageBox.Avalonia.Views.MsBoxStandardWindow.!XamlIlPopulateTrampoline(MsBoxStandardWindow )
   at MessageBox.Avalonia.Views.MsBoxStandardWindow.InitializeComponent()
   at MessageBox.Avalonia.Views.MsBoxStandardWindow..ctor(Style style)
   at MessageBox.Avalonia.MessageBoxManager.GetMessageBoxStandardWindow(MessageBoxStandardParams params)
   at MessageBox.Avalonia.MessageBoxManager.GetMessageBoxStandardWindow(String title, String text, ButtonEnum enum, Icon icon, Style style)
   at WPILibInstaller.ViewModels.VSCodePageViewModel.SkipVsCodeFunc()

Reproduction steps:

1. when asked to select how to install VS Code (the first screen after start), select Skip installing VS Code.

-rwxr--r-- 1 joe joe 1086704 Nov 2 23:03 libHarfBuzzSharp.so
-rwxr--r-- 1 joe joe 920882 Nov 2 23:03 libMonoPosixHelper.so
-rwxr--r-- 1 joe joe 8541744 Nov 2 23:03 libSkiaSharp.so
-rwxr--r-- 1 joe joe 2416513 Nov 2 23:03 System.Reactive.xml

Feedback from post6733

The latest LTS release of AdoptOpenJDK 11 for macOS is also codesigned with hardened runtime and will notarize correctly.

The continue button moves around. It should always be in the bottom right. In the example below, the continue button is replaced by the back button.

The scripts for SetupTools and CleanMavenMetadata are called as executables -- this doesn't work on Mac.

https://github.com/wpilibsuite/WPILibInstaller-Avalonia/blob/master/WPILibInstaller-Avalonia/ViewModels/InstallPageViewModel.cs#L456

My temporary workaround (needs to be more robust to various python installations):

private Task<bool> RunScriptExecutable(string script, params string[] args)
{
    ProcessStartInfo pstart;
    if (script.Contains(".py"))
    {
        pstart = new ProcessStartInfo();
        pstart.FileName = "/usr/bin/python3";
        pstart.Arguments = script;
    }
    else
    {
        pstart = new ProcessStartInfo(script, string.Join(" ", args));
    }
    var p = Process.Start(pstart);
    return Task.Run(() =>
    {
        return p!.WaitForExit(5000);
    });
}

https://github.com/wpilibsuite/WPILibInstaller-Avalonia/blob/master/WPILibInstaller-Avalonia/ViewModels/InstallPageViewModel.cs#L674

The old NI installer used one progress bar for overall status (ie 1 of 7 items installed) and a second to show the status within the current item.

When installing on macOS, the VSCode Zip file is not cleaned up after extraction.

Useful for IT departments who want to install on a bunch of devices at once.

We should hide some of the installation paths and user options to avoid confusion about what is needed. This path would automatically install everything and download a single instance of VS Code. We can create an advanced button on the start page that then allows users to select what they want to install.

This is spawned from feedback in post6706.

.desktop file, figure out how to do this.

See: wpilibsuite/RobotBuilder#259

Because RobotBuilder is going to be publishing both an old and a new version, the installer should grab and install both versions with different names. That way teams can choose the version appropriate for them.

Only windows terminals are set currently.

When I tried to install with single VS Code, the installer failed with:

System.ComponentModel.Win32Exception (2): No such file or directory
   at System.Diagnostics.Process.ForkAndExecProcess(String filename, String[] argv, String[] envp, String cwd, Boolean redirectStdin, Boolean redirectStdout, Boolean redirectStderr, Boolean setCredentials, UInt32 userId, UInt32 groupId, UInt32[] groups, Int32& stdinFd, Int32& stdoutFd, Int32& stderrFd, Boolean usesTerminal, Boolean throwOnNoExec)
   at System.Diagnostics.Process.StartCore(ProcessStartInfo startInfo)
   at System.Diagnostics.Process.Start()
   at System.Diagnostics.Process.Start(ProcessStartInfo startInfo)
   at WPILibInstaller.ViewModels.InstallPageViewModel.RunScriptExecutable(String script, Int32 timeoutMs, String[] args) in /Users/runner/work/WPILibInstaller-Avalonia/WPILibInstaller-Avalonia/WPILibInstaller-Avalonia/ViewModels/InstallPageViewModel.cs:line 497
   at WPILibInstaller.ViewModels.InstallPageViewModel.RunToolSetup() in /Users/runner/work/WPILibInstaller-Avalonia/WPILibInstaller-Avalonia/WPILibInstaller-Avalonia/ViewModels/InstallPageViewModel.cs:line 514
   at WPILibInstaller.ViewModels.InstallPageViewModel.RunInstall() in /Users/runner/work/WPILibInstaller-Avalonia/WPILibInstaller-Avalonia/WPILibInstaller-Avalonia/ViewModels/InstallPageViewModel.cs:line 103
   at WPILibInstaller.ViewModels.InstallPageViewModel.<>c__DisplayClass16_0.<<-ctor>g__installFunc|0>d.MoveNext() in /Users/runner/work/WPILibInstaller-Avalonia/WPILibInstaller-Avalonia/WPILibInstaller-Avalonia/ViewModels/InstallPageViewModel.cs:line 67

When I tried with skip VS code, it failed with

System.TypeLoadException: Could not load type 'Avalonia.Markup.Xaml.MarkupExtensions.BindingExtension' from assembly 'Avalonia.Markup.Xaml, Version=0.10.0.0, Culture=neutral, PublicKeyToken=null'.
   at MessageBox.Avalonia.Views.MsBoxStandardWindow.!XamlIlPopulate(IServiceProvider , MsBoxStandardWindow )
   at MessageBox.Avalonia.Views.MsBoxStandardWindow.!XamlIlPopulateTrampoline(MsBoxStandardWindow )
   at MessageBox.Avalonia.Views.MsBoxStandardWindow.InitializeComponent()
   at MessageBox.Avalonia.Views.MsBoxStandardWindow..ctor(Style style)
   at MessageBox.Avalonia.MessageBoxManager.GetMessageBoxStandardWindow(MessageBoxStandardParams params)
   at MessageBox.Avalonia.MessageBoxManager.GetMessageBoxStandardWindow(String title, String text, ButtonEnum enum, Icon icon, Style style)
   at WPILibInstaller.ViewModels.VSCodePageViewModel.SkipVsCodeFunc() in /Users/runner/work/WPILibInstaller-Avalonia/WPILibInstaller-Avalonia/WPILibInstaller-Avalonia/ViewModels/VSCodePageViewModel.cs:line 143

My user directory is /Users/nyjeanne. There is no /Users/runner. I don't know where it is getting that from.

I don't think is relevant, but I had to right click and choose open to get around the Apple cannot check for malicious software/verify the identity of the developer.

Make it need a popup.

We can't depend on the shared runtime to be installed on users systems.

The "drag to dock" text is too long for the default window size:

We want to get the installer signed with an EV cert, but this is harder to do in CI. But, since we only need the EXE signed we can build once, and only update the files for each installer.

Selecting an Invalid ZIP file gives the following exception. The reasonable response would be to tell the user that the zip file is invalid and select a different zip file.

System.NullReferenceException
  HResult=0x80004003
  Message=Object reference not set to an instance of an object.
  Source=WPILibInstaller_Avalonia
  StackTrace:
   at WPILibInstaller_Avalonia.ViewModels.StartPageViewModel.<SelectResourceFilesFunc>d__23.MoveNext() in C:\Users\Dalton Smith\Documents\WPILibInstaller-Avalonia\WPILibInstaller-Avalonia\ViewModels\StartPageViewModel.cs:line 95

On using (StreamReader reader = new StreamReader(entry.Open()))

It should use "$(dirname "$(dirname "$(realpath "$0")")")"/vscode/VSCode-linux-x64/bin/code "$@" instead.

open /path/to/folder will open the folder in Finder.

The wpilib extension should have been installed to the downloaded version of VS Code.

Can we create the extensions folder for RobotBuilder with the installer (either empty or with a dummy file in it) so that users don't have to run Robotbuilder in between installing WPILib and installing something that installs RobotBuilder extensions (e.g. CTRE installer)?

https://usfirst.collab.net/sf/discussion/do/listPosts/projects.frc2021beta/discussion.task_reports.topc2152
Post 6781

System.ComponentModel.Win32Exception
  HResult=0x80004005
  Message=The system cannot find the file specified.
  Source=System.Diagnostics.Process
  StackTrace:
   at System.Diagnostics.Process.StartWithCreateProcess(ProcessStartInfo startInfo)
   at System.Diagnostics.Process.Start()
   at System.Diagnostics.Process.Start(ProcessStartInfo startInfo)
   at WPILibInstaller_Avalonia.ViewModels.InstallPageViewModel.<>c__DisplayClass32_0.<RunVsCodeExtensionsSetup>b__8() in C:\Users\Dalton Smith\Documents\WPILibInstaller-Avalonia\WPILibInstaller-Avalonia\ViewModels\InstallPageViewModel.cs:line 506
   at System.Threading.Tasks.Task`1.InnerInvoke()
   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)

on
Fixing up metadata when I just pressed "Next" without installing VS Code

Sometimes when using the installer on macOS the menubar menu becomes unavailable. When I click on the menu bar, I see the click register but no menu appears and the computer beeps. The computer also beeps when I press a keyboard shortcut (command + q).

The continue button moves around. It should always be in the bottom right. In the example below, the continue button is replaced by the back button.

Are you really sure?
Just checking one more time...
We’d hate to lose you, please take this survey first...

Right now the built DMG is named WPILibInstaller.dmg. It should instead match the other operating systems and be more like WPILib_macOS-2021.1.1-beta-1.dmg

They much be correct, otherwise things will likely not work correctly.

With 2021, the plan is to put the tools into a folder, we should cleanup the 2020 tools and put them in a folder too that way users cannot get confused.

1.51 has some nice new git functionality that I'd like students to be able to take advantage of.

Causes the main thread to freeze, which on slow computers can cause windows to interpret it as "Not Responding"

Should VSCode be optional?

This would be very helpful for install automation. I can try to help implement this, but I am not very sure in my ability to help significantly.

Installed to ~/wpilib/2021/vscode instead of ~/wpilib/2021/vscode/VSCode-linux-x64

One of my students tried using the command to set JAVA_HOME a couple days ago on
Ubuntu 20.04. Before and after reopening the terminal, JAVA_HOME was still
empty.

.desktop files can be installed to ~/.local/share/applications to show up in the launcher.

Feedback from post6733

            try
            {
                var rootDirectory = Directory.GetDirectoryRoot(Environment.GetFolderPath(Environment.SpecialFolder.Personal));

                var driveInfo = new DriveInfo(rootDirectory);

                if (driveInfo.AvailableFreeSpace < 3L * 1000L * 1000L * 1000L)
                {
                    ;
                    // Fail
                }
            }
            catch
            {
                // Do nothing if we couldn't determine the drive
            }

In theory, this might work on unix platforms as well.

If you install just Java and the tools, after installation is complete, it displays "Finished: Use desktop to Open VS Code". The prompt should change if VS Code isn't installed.

As it says on the tin... the built MacOS artifact is not executable.