wpilibsuite / docker-images Goto Github PK

Ran into this issue when trying to have an automated GitHub Action run Spotless formatting on a protected main branch of robot code and trying to follow this workaround to use GitHub deploy keys. In some cases, it may be preferable to use ssh authentication to do this, but this cannot be done as the current Docker images do not include 'ssh-agent'.

I was able to get around this by following the main solution listed (Made a mistake and added the bot to the 'Allow force pushes' list instead of the bypass list), but it might be useful to have this option.

Description of the issue

This issue is directly related to images on docker hub (https://hub.docker.com/r/wpilib/raspbian-cross-ubuntu/)

Users can't pull the image from docker. Missing the image with tag latest
Context information (for bug reports)

Steps to reproduce the issue

1. docker pull wpilib/raspbian-cross-ubuntu
2. Observe the error in terminal

Observed result

The error in terminal

→ docker pull wpilib/raspbian-cross-ubuntu
Using default tag: latest
Error response from daemon: manifest for wpilib/raspbian-cross-ubuntu:latest not found

Suggested solution

In each stable relase push container with the latest tag.

In the current state of how images are named, every image has the ubuntu prefix or suffix. In some cases, this would be fine, especially with software designed around just Ubuntu. But this causes issues when trying to bring in support for Debian. It would be possible to generate another set of containers with a debian prefix/suffix.

Many popular images on Docker Hub use a generic image name, and note any differing changes into the tag. Take the Grafana image for example, it will tag versions and releases with Alpine as its base, and Ubuntu bases with a -ubuntu suffix (latest, latest-ubuntu, 9.0.6, 9.0.6-ubuntu, etc.). Or the Python image, which will put the OS version in the tag name (3.9.13-buster, 3.9.13-bullseye, etc.). Along with the verbose tags, the Python images are also tagged with more generic names to make end-user usage easier (3.10.6-bullseye == 3.10-bullseye == 3-bullseye == bullseye).

I think the images in this repo should follow the Python, along with a specifier of Ubuntu or Debian. But this can also be implied by the name of the tag, as Ubuntu and Debian has never had matching version names.

As you can see by the image names, I also changed the names of raspbian-cross/aarch64-cross to frcvision-cross/jetson-cross as these containers are used for very specialized targets which were not apparent until you look at the tags of the images.

Another design choice, which I do not particularly like, but would follow the design of the current system, can look like the following.

Both versions allow for multiple versions from the same distro, which will bring flexibility to slowly roll out the migration from one LTS release to another.