wp-oop / containers Goto Github PK

The Problem

The SiteMeta class seems to always operate on options of the current site, regardless of site ID.

Possible Cause

It uses network functions, rather than site functions, and uses site ID in place of network ID. This made sense before, as sites were understood as belonging to a network, and so a site would be identified by a site ID and a network ID. This used to work for some small subset of cases, like where there is only one site in a multisite network.

Suggested Solution

Use functions like get_site_meta(), with the correct site ID. This will work because the way sites work is now understood much better. In this new paradigm, all sites differ by site ID, and network ID is only used to group them, which explains why you can move a site between network and relations still work. So, because a site is only identified by site ID, and does not involve network ID, it is fine to use the meta-oriented functions without any network involvement. An interface that exposes meta for a particular site will continue exposing meta for that site even if its network changes.