The mobile version of the homepage isn't preloaded in priority when separate cache for mobile devices is enabled about wp-rocket HOT 6 CLOSED

@MathieuLamiot @vmanthos Updated the AC

from wp-rocket.

@vmanthos, @Mai-Saad, @piotrbak: following Tabrisrp's investigation, he pointed out 2 issues. Would it be interesting to rework the acceptance criteria here? I might not understand everything, but it seems the AC cover the activation part (checking we send the right requests on activation), but not the RUCSS side-effect.
A few e2e scenarios might be needed to cover Tabrisrp's proposal?

from wp-rocket.

Acceptance Criteria:

1. When separate cache for mobiles is enabled when activating the plugin:

• We should send two requests, to desktop and mobile with defined pause between them:

  wp-rocket/inc/Engine/Preload/Controller/PreloadUrl.php

  Line 149 in 7ff6ad0

  $delay_between = apply_filters( 'rocket_preload_delay_between_requests', 500000 );

• The user agent for both requests will be the same as in the preload:

  wp-rocket/inc/Engine/Preload/Controller/PreloadUrl.php

  Line 160 in 7ff6ad0

  protected function get_mobile_user_agent_prefix() {

2. When separate cache for mobiles is enabled when clearing the Used CSS:

• We should send two requests, to desktop and mobile with defined pause between them:

  wp-rocket/inc/Engine/Preload/Controller/PreloadUrl.php

  Line 149 in 7ff6ad0

  $delay_between = apply_filters( 'rocket_preload_delay_between_requests', 500000 );

• The requests should be sent after clearing the cache, so the just preloaded cache is present
• The user agent for both requests will be the same as in the preload:

  wp-rocket/inc/Engine/Preload/Controller/PreloadUrl.php

  Line 160 in 7ff6ad0

  protected function get_mobile_user_agent_prefix() {

3. When separate cache for mobiles is disabled when activating the plugin:

• We should send only desktop request

4. When separate cache for mobiles is disabled when clearing the Used CSS:

• We should send only desktop request after clearing the cache

from wp-rocket.

@vmanthos When clearing the used CSS, did you do it from the admin side or from the front side via the admin bar?

The homepage preload is hooked on the used CSS clear, but only on the admin side.

from wp-rocket.

@Tabrisrp I cleared it using the admin bar menu item while in WP Rocket's dashboard.
I believe the same would happen if the theme is switched or the permalinks are changed.

from wp-rocket.

Reproduce the issue ✅

Reproduced

Identify the root cause ✅

There is 2 different parts in this issue, the activation one and the RUCSS clean one.

For the activation, we do a request to the homepage when activating, but we do not do the request for mobile.

For the RUCSS clean one, I noticed that we do have a method hooked on the related action, but right after in the truncate_used_css_handler() method, there is a call to rocket_clean_domain(), so the preload happens and is deleted right away.

There is only a cache file for the desktop version because there is a manual call to the homepage in the method after.

Scope a solution ✅

in WP_Rocket\Engine\Activation\Activation.php

• remove the call to the homepage
• add a new action rocket_after_activation

in WP_Rocket\Engine\Preload\Activation.php

• Add the PreloadUrl controller as a dependency to the class
• In the activate method, add a new add_action on rocket_after_activation, to preload the homepage
• add a method preload_homepage(), which will call $this->preload_url->preload_url( home_url() );

in WP_Rocket\Engine\Optimization\RUCSS\Admin\Subscriber

• Remove no longer necessary preload calls to the homepage in truncate_used_css_handler(), and truncate_used_css()
• in truncate_used_css_handler(), switch the calls to $this->delete_used_css_rows(); and rocket_clean_domain(); to make sure the clean happens before the preload.

Estimate the effort ✅

Effort [S]

from wp-rocket.