Conflict with ABEConnector plugin, regression of private posts changes about wp-rocket HOT 3 CLOSED

Reproduce the issue

Yes I can reproduce it by having the following snippet:

add_filter( 'the_posts', function( $posts ) {
    ob_start();
    echo 'wordpressfan';
    $final = ob_get_clean();
    return $posts;
} );

Root cause

With this PR: #6218 we created a new function rocket_url_to_postid to get the post ID from url to be able to detect the private urls to be excluded from preload.
We use WP_Query class there to get that post ID, and we have a case that inside our buffer with the hook rocket_after_process_buffer we use this function to check preload exclusions and this fatal error happens because inside the main buffer we are using another buffer.

Provided solution

As mentioned in the issue, we can suppress filters inside this function when using WP_Query class or at least add a new filter to filter the args being passed to WP_Query here:

so without affecting any other user we can provide a helper to suppress filters there.

Estimation

[XS]

What do u think @wp-media/php-team ?

from wp-rocket.

Seems okay to me

from wp-rocket.

For testing we need to:

• Validate the problem here with the mentioned snippet is fixed
• rerun this for regression https://wpmediaqa.testrail.io/index.php?/runs/view/779&group_by=cases:section_id&group_order=asc

from wp-rocket.