Code Monkey home page Code Monkey logo

Comments (7)

wojsmol avatar wojsmol commented on June 6, 2024 1

Hi @holtjohnson
Try to cause checksum error in one of the plugins, if I read code correctly the formatter is run only in error conditions.

from checksum-command.

schlessera avatar schlessera commented on June 6, 2024 1

Right now, it is not easily possible to capture just the JSON/CSV output reliably.

This is one of the basic requirements for making the command scriptable.

from checksum-command.

swissspidy avatar swissspidy commented on June 6, 2024 1

Related: wp-cli/i18n-command#39

I want to make that command scriptable as well and haven't found an ideal solution yet.

However, looking at this issue here I realize that this is a more common problem so it would be great to have a universal solution.

One thought was to just use a different logger that also catches STDOUT/STDERR output.

WP_CLI::error() could still halt the script, everything else would go into a log that's presented at the end.

from checksum-command.

schlessera avatar schlessera commented on June 6, 2024 1

I'll remove this from the v2.1.0 checklist again. Let's rediscuss and plan for v2.2.0.

from checksum-command.

schlessera avatar schlessera commented on June 6, 2024

I do get different output, but only for the issues that were actually detected. The status messages are added as normal STDOUT/STDERR labeled text.
image 2018-07-31 at 6 22 04 pm

I agree that this is less than ideal, and we should discuss how to better present the results for this command.

from checksum-command.

holtjohnson avatar holtjohnson commented on June 6, 2024

Thanks @wojsmol for pointing out the formatter only runs in error conditions. I can now get different output of the checksum errors, but the general warnings, errors, and details such as which plugins passed are not formatted.

@schlessera I would agree it's less than ideal and prevents capturing the output reliably. I'd add to @schlessera's screenshot showing how the warnings are added as STDOUT text. I was trying to get the JSON output from the command, but this is the response I'm greeted with:
screen shot 2018-08-01 at 11 31 20

I was expecting the output of the command would include clean JSON with details about which plugins were skipped, failed, or passed and a list of the failure details.

As always, thanks to all of you who work on this project. I love WP-CLI!

from checksum-command.

swissspidy avatar swissspidy commented on June 6, 2024

Wouldn't using --quiet work for now in this case, when one isn't interested in the warnings or errors, but only the command's actual output?

The thing is, for the i18n-command it wouldn't work. The warnings I use there contain relatively useful information. But I guess I should just use WP_CLI::log() instead.

from checksum-command.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.