Bug Report <input typ

Thank you for replying <a class="user-mention notranslate" data-hovercard-type="user"

The wordpress.org API failed a few more times recently using the <code class="notransl

I confirmed that the return code was a 400</cod

Thank you for the reply <a class="user-mention notranslate" data-hovercard-type="user"

Error: RuntimeException: Failed to get url when using `wp core verify-checksums` about checksum-command HOT 6 OPEN

wp-cli commented on May 27, 2024

Error: RuntimeException: Failed to get url when using `wp core verify-checksums`

from checksum-command.

Comments (6)

danielbachhuber commented on May 27, 2024

Running wp core verify-checksums fails when the .org API server times out and throws a RuntimeException . A timeout should be handled gracefully, and an error or warning thrown instead. Here is the exception error.

@rumspeed Thanks for the report!

I think what you're seeing is WP_CLI:error() handle the RuntimeException:

checksum-command/src/Checksum_Core_Command.php

Lines 84 to 88 in 310c4c5

    
           try { 
        
           	$checksums = $wp_org_api->get_core_checksums( $wp_version, empty( $locale ) ? 'en_US' : $locale ); 
        
           } catch ( Exception $exception ) { 
        
           	WP_CLI::error( $exception ); 
        
           }

https://github.com/wp-cli/wp-cli/blob/e067300a97ab3757e55c3c5beba8cff3d89d3340/php/WP_CLI/WpOrgApi.php#L314-L335

Could you share a bit more detail on the error you'd expect to see?

from checksum-command.

rumspeed commented on May 27, 2024

Thank you for replying @danielbachhuber.

Could you share a bit more detail on the error you'd expect to see?

In the Slack #cli channel on June 30th I was initially questioning if the API service was not working or maybe overloaded based on the Error: RuntimeException: Failed to get url message I was getting.

@schlessera responded to with "The fact that the command throws a RuntimeException in this case is a bug, though." and shortly after that we agreed that I would add an issue to the GitHub repo for a deeper look.

If this isn't a but then go ahead and close this out. :)

from checksum-command.

rumspeed commented on May 27, 2024

The wordpress.org API failed a few more times recently using the wp core verify-checksums command. I confirmed that the return code was a 400. With this being a server issue, as it is reporting RuntimeException: Failed to get url, should this be a 503 Service Unavailable?

from checksum-command.

danielbachhuber commented on May 27, 2024

I confirmed that the return code was a 400. With this being a server issue, as it is reporting RuntimeException: Failed to get url, should this be a 503 Service Unavailable?

@rumspeed Just to confirm, 400 was the return code from wordpress.org?

If this is the case, I think the problem you're referring to would be better fixed upstream.

from checksum-command.

schlessera commented on May 27, 2024

Yes, this is definitely an issue with the upstream server.

However, given this seems a common occurrence with the WP.org APIs, I would also consider adding a retry mechanism to this command, to improve its resilience.

from checksum-command.

rumspeed commented on May 27, 2024

Thank you for the reply @danielbachhuber. The 400 code I am seeing is returned from the WP_CLI::error( $exception ) payload.

@schlessera, is there anything else I can do to help with this?

from checksum-command.

Error: RuntimeException: Failed to get url when using `wp core verify-checksums` about checksum-command HOT 6 OPEN

Comments (6)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	try {
	$checksums = $wp_org_api->get_core_checksums( $wp_version, empty( $locale ) ? 'en_US' : $locale );
	} catch ( Exception $exception ) {
	WP_CLI::error( $exception );
	}