Comments (8)
Before I go about renaming the commands again, I'd like to make sure we're on the same page.
We now have core checksums and plugin checksums (and themes will be aded later as well).
Right now, these are implemented in wp-cli/checksum-command
and are named:
wp checksum core
wp checksum plugin
(in separate branch right now)
What we want is:
wp core verify-checksums
(with aliaswp checksum core
)wp plugin verify-checksums
(with aliaswp checksum plugin
)
These will stay in the wp-cli/checksum-command
repository (instead of splitting them out into the wp-cli/core-command
and wp-cli/extension-command
repositories.
@danielbachhuber Do you agree with all of the above?
from checksum-command.
I just don't think that this should be split amongst multiple commands. There's a lot of code reuse,
We can use PHP inheritance to DRY our code without forcing our naming structure to a specific pattern.
And the same stack with
verify-checksums
instead?
Most commands are wp <noun> <verb>
. I think we should follow this existing pattern for consistency.
from checksum-command.
How about wp verify
?
wp verify core
wp verify plugin --all
wp verify theme --all
wp verify all
from checksum-command.
wp verify
is too ambiguous.
from checksum-command.
And the same stack with verify-checksums
instead?
from checksum-command.
I just don't think that this should be split amongst multiple commands. There's a lot of code reuse, and the most used scenario will probably be verify all the stuff
, once we have implemented that.
from checksum-command.
👍 from me if it seems fine to you
from checksum-command.
I'll put my OCD neatly into a drawer away from the laptop, to ignore the repository name mismatch... ;)
from checksum-command.
Related Issues (20)
- flags ancient files as "should not exist" but should flag as "deprecated, can be deleted" HOT 1
- `Could not retrieve the checksums` still visible with `--skip-plugins=<plugin-name>` HOT 5
- Add `--version` param to `wp plugin verify-checksums` HOT 2
- wp-cli core verify-checksums does not check extra themes HOT 2
- During plugin verify-checksum, failed plugins should be listed HOT 2
- --include-root does not work HOT 1
- Adding an exclusion option to `wp core verify-checksums` ? HOT 1
- Add command to check themes integrity in WP-CLI HOT 1
- Verification checks skipped when plugin missing main PHP file HOT 1
- verify-checksums does not list all added files HOT 9
- Plugin
- WordPress installation doesn't verify against checksums HOT 4
- Flag presence of unexpected files HOT 11
- Add an option to skip additional files check HOT 2
- Core verify-checksums command doesn't catch added files at ABSPATH directory HOT 3
- Flag to turn warnings into errors HOT 1
- Random messages: Could not retrieve the checksums for version x.y.z of plugin-name HOT 7
- Warning: Could not retrieve the checksums HOT 1
- Error: RuntimeException: Failed to get url when using `wp core verify-checksums` HOT 6
- Add --format argument to `wp core verify-checksums` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from checksum-command.