Code Monkey home page Code Monkey logo

wf-grunt's People

Contributors

charliekump-wf avatar mackenzieobleness-wf avatar nathanevans-wf avatar shanesizer-wf avatar teresarevious-wf avatar timmccall-wf avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

wf-grunt's Issues

jasmine-integration task is run whether or not integrationSpecs are in glob

v0.3.2 breaks backward-compatibility because the jasmine-integration task is always run. Try upgrading a v0.3.1 project's package.json and grunt and you will see what I mean.

Added in fb9e7fd by adding jasmine-integration task to default, I believe:

diff --git a/src/tasks/default.js b/src/tasks/default.js
index c37f2ad..9059fdc 100644
--- a/src/tasks/default.js
+++ b/src/tasks/default.js
@@ -25,6 +25,7 @@ module.exports = function(grunt) {
             'connect:run',
             'clean:test',
             'jasmine:test',
+            'jasmine:integration',
             'clean:coverage',
             'jasmine:coverage',
             'clean:docs',

@nathanevans-wf, can you comment on what effect removing this line will have? Will it break existing CI functionality?

npm ERR! peerinvalid Peer [email protected] wants requirejs@~2.1

This repo uses "karma-requirejs": "^0.2.2",, but "karma-requirejs": "0.2.4" is the last version that works. "karma-requirejs": "0.2.5" blows up with this error:

npm ERR! peerinvalid The package requirejs does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer [email protected] wants requirejs@~2.1

This affects all consumers of wf-grunt, potentially :/

See The package karma does not satisfy its siblings' peerDependencies requirements! · Issue #873 · karma-runner/karma

common js jshint

jshint does not allow for CommonJS globals.

var COMMONJS_GLOBALS = {
    module: true,
    require: true,
    __dirname: true,
    __filename: true,
    exports: true
};

Something like that for jshint config file.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.