Code Monkey home page Code Monkey logo

secure-swfupload's Introduction

SWFUpload (Maintained for Security Fixes)

This is a fork of the long-abandoned SWFUpload project, maintained by WordPress and others to ensure that a secure version of SWFUpload exists.

We strongly suggest you do not use SWFUpload. But if you must, use this fork.

WordPress is maintaining a secure version of SWFUpload for use by WordPress plugins that have yet to be updated to use Plupload, our upload library of choice. Plupload is was written and is actively maintained by Moxiecode, the developers of TinyMCE.

We do not condone the use of abandonware. We only wish to make the web a better place by ensuring that developers have access to a secure version of SWFUpload, when the only alternative may be to use insecure code.

Reporting Security Vulnerabilities

If you think you have found a vulnerability in this fork of SWFUpload, we appreciate your help in disclosing it to us responsibly. Please email reports of security vulnerabilities to [email protected]. These reports will be reviewed by the WordPress security team and by contributing security researchers, including Neal Poole and Szymon Gruszecki, who have previously identified vulnerabilities in SWFUpload.

Fixed Vulnerabilities

Acknowledgements

Over the years, a number of individuals and companies have identified security vulnerabilites in SWFUpload. This fork of SWFUpload includes contributions from:

Submitting Bug Fixes and New Features

This fork of SWFUpload is maintained for security features only. Features will not be accepted. (We'll again recommend Plupload.)

Discrete bug fixes could be considered on a case-by-case basis through a pull request. We do not wish to condone any time spent on SWFUpload, as we find that to be time wasted. But, if you have a desire to help maintain SWFUpload, contact [email protected].

Report security vulnerabilities to [email protected].

License

Like the original SWFUpload, this is licensed under MIT.

Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

secure-swfupload's People

Contributors

joelpittet avatar joncave avatar nacin avatar sir-gawain avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

secure-swfupload's Issues

The above copyright notice is missing in Readme

On this repository frontpage readme.md the copyright notice is missing albeit the license terms dictate those to keep to not loose usage rights:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

This is a follow up to #2 as it was closed quickly without further traction.

The original copyright notice is (take from the file /core/swfupload license.txt):

/**
 * SWFUpload: http://www.swfupload.org, http://swfupload.googlecode.com
 *
 * mmSWFUpload 1.0: Flash upload dialog - http://profandesign.se/swfupload/,  http://www.vinterwebb.se/
 *
 * SWFUpload is (c) 2006-2007 Lars Huring, Olov Nilzén and Mammon Media and is released under the MIT License:
 * http://www.opensource.org/licenses/mit-license.php
 *
 * SWFUpload 2 is (c) 2007-2008 Jake Roberts and is released under the MIT License:
 * http://www.opensource.org/licenses/mit-license.php
 *
 */

Please include the copyright notice, currently the license text is misleading as it appears that no copyright notice exists.

Image object injection vulnerability via 'buttonImageURL' parameter

I've received a few reports today of an image object injection problem in swfupload affecting WordPress. I'm filing this public issue here after contacting [email protected] and being asked to do so (as this issue is already public knowledge).

There's an object injection "vulnerability" in swfupload, as shown by this demo URL:

https://wordpress.org/news/wp-includes/js/swfupload/swfupload.swf?buttonImageURL=http://1337day.com/img/logo_green.jpg

Known advisories for this issue:

http://1337day.com/exploit/20669
http://bot24.blogspot.com/2013/04/swfupload-object-injectioncsrf.html

This was tested on WordPress 3.5.2.

As discussed on e-mail, there are three basic options:

  • Remove buttonImageURL
  • Restrict buttonImageURL to same origin
  • Ignore the issue

My recommendation would be to restrict buttonImageURL to the same origin as the blog site, as swfupload is already deprecated, and I'd rather it be secure but slightly broken than have a known issue that could be used for spoofing or other issues.

Thanks!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.