.DS_Store should not be in the repo.

See this S.O. topic https://stackoverflow.com/questions/107701/how-can-i-remove-ds-store-files-from-a-git-repository

The plugin does so much more than Create Themes now, so it might be a good idea to change the button text to something like "Create", but that doesn't really work for the "Overwrite" option.

Maybe "Generate" is a better option.

Perhaps we could consider a "save" option for the theme. If the current option exports a .zip an additional option could be to "save" the theme where the changes get stored in the theme folder rather than exported as a .zip file.

This would allow the development experience of themes to happen in the FSE and be updated in what is my development environment allowing me to skip the export/unpack/copy/delete process that happens whenever I export the theme.

Since it's not currently possible to create a singular or single post without the Gutenberg plugin it would be a more complete experience to create an empty theme if singular were present when generating an empty theme.

This would be a short term need since there should be a mechanism for creating a single post and single CPT template once Gutenberg is merged for 6.1

This is may be related to #67.

When I save changes to a child theme:

• changed templates save as expected to the child templates folder
• but changed template PARTS save to neither child nor parent, but are nonetheless removed from database, and lost

Also, the entire parent theme.json is saved to the child theme.json, which is not what I expected.

I expected only the differences to the parent theme.json to be saved to the child theme.json.

In my case I had only a new color palette in my child theme theme.json, so I expected that upon saving, the child theme.json would still have only the child color palette and nothing else.

My limited understanding is that on page load, objects in the child theme.json overwrite objects in the parent theme.json? If so, my concern is that any later update to the parent theme.json will no longer be visible because a prior version of the parent will have been copied into the child.

Some of the code in the plugin looks similar to the theme export code that exists in core. Could that be re-used in the plugin?

Follow up to this comment: https://github.com/WordPress/create-block-theme/pull/70/files#r901954196

Looks like the settings API would be a better way to handle the form instead:

https://developer.wordpress.org/plugins/settings/using-settings-api/

For a 1.0.0 Release we will ensure that the plugin can do the following tasks:

Export your existing block theme

With a non-child theme activated export your theme to a .zip file. The theme.json in the exported package will include changes made via the FSE Global Styles editor. Any customizations or additions to block templates or block template parts will be included in the exported package.

With a child theme activated export your theme to a .zip file. The changes should be the same as an exported parent theme.

Create a Child theme from the activated Theme

With a non-child theme activated create a new theme and export it to a .zip file. The exported theme will have all of the changed made to templates and global styles.

Clone a non-child theme

Create a new theme based on the current activated theme but with changes made to templates and global styles. Limited resources will have namespaced resources refactored (such as function names in functions.php).

Clone a child theme

Create a new theme based on the current activated theme but with changes made to templates and global styles. (This is called a "sibling" theme). Limited resources will have namespaced resources refactored (such as function names in functions.php). The resulting new theme will be a child of the same theme the currently activated theme is a child of.

Steps:

• Disable Gutenberg
• Create block theme

Expected result

Disable/remove the option when Gutenberg is not enabled.

When CLONING a PARENT or creating a SIBLING theme (cloning a child theme) the resulting resources could be namespaced.

For example functions like this:

function twentytwentytwo_support() {

should be refactored to:

function my_new_theme_support() {

and

wp_register_style('twentytwentytwo-style',...

to

wp_register_style('my-new-theme-style',...

We should consider the following resources when refactoring the namespace:

functions.php
??? what else ???

Steps:

• Activate a child theme such as Quadrat and use override option and export theme.
• Observe that it overrides parent theme blockbase

Overwrite
[Save USER changes as THEME changes and delete the USER changes. Your changes will be saved in the theme on the folder.]

Removes the following:

• "$schema": "https://schemas.wp.org/trunk/theme.json",
• "useRootPaddingAwareAlignments": true, (I think part of this issue is schema has to be updated "Property useRootPaddingAwareAlignments" is not allowed.)

Also puts version key all the way at the bottom of the theme.json?

• "version": 2

I have been following similar setup to https://github.com/WordPress/twentytwentythree/blob/trunk/theme.json

Besides that it works pretty well!

Apologies in advance if this is expected, or if I am doing something wrong, but I discovered that by creating a blank block theme, applying only some styles via the Styles panel in the Site Editor, when I export or clone the theme using Create Block Theme, the theme.json doesn't seem to be updated with the new styles.

However, when I export the theme using the Site Editor Export option, the theme.json is updated as expected.

Steps to reproduce:

1. Create a block theme with only an empty style.css (except for the required header), theme.json with basic content (below), and a blank templates/index.html page.
2. Activate the theme, and only apply some styles like background image, text color, etc via Site Editor, and save.
3. Use the plugin page to either Export or Clone the theme

Original theme.json

{
  "version": 2,
  "settings": {
    "appearanceTools": true
  }
}

Exported/cloned theme.json

{
	"settings": {
		"appearanceTools": true
	},
	"version": 2
}

Expected theme.json (which I get via the Site Editor Export option).

{
	"$schema": "https://schemas.wp.org/wp/6.0/theme.json",
	"settings": {
		"appearanceTools": true
	},
	"styles": {
		"color": {
			"background": "var:preset|color|pale-cyan-blue",
			"text": "var:preset|color|vivid-cyan-blue"
		},
		"elements": {
			"link": {
				"color": {
					"text": "var:preset|color|vivid-purple"
				}
			}
		},
		"spacing": {
			"padding": {
				"bottom": "20px",
				"left": "20px",
				"right": "20px",
				"top": "20px"
			}
		}
	},
	"version": 2
}

Description is missing when clone option used.

Active theme

Author changed to Anonymous and this makes sense.
But the description should get copied.

After exporting a new child theme and trying to upload the zip through the theme importer I get:

”The package could not be installed. PCLZIP_ERR_BAD_FORMAT (-10) : Unable to find End of Central Dir Record signature“

When trying to unzip the file locally, I get:
”The operation couldn’t be completed. Inappropriate file type or format”

I’m working on an iPad Pro with the latest iOS -
the Blockbase theme is installed and activated

The URL for the license currently points to the previous repo.

Typo on this line: https://github.com/WordPress/create-block-theme/blob/trunk/admin/class-create-block-theme-admin.php#L614

<p><?php _e('Export your current block them with changes you made to Templates, Template Parts and Global Styles.', 'create-block-theme'); ?></p>

Reported by @bgardner via Twitter DM.

When the core theme export runs the $schema URI checks for Gutenberg to determine if the trunk version of the schema should be used, if Gutenberg is not present then the URI for the currently installed version of WordPress should be used instead.

Hi !

I tried to make a child theme of Blockbase and I get these errors :

I just modified the header to test a child theme.
Here is what I get in the zip file.

It's a basic WP 5.8.2 without any plugins installed, just for the try.

What am I doing wrong ?

Thanks !

Hi,

When I go to Appearance > Create Blockbase Theme, fill in the fields and click the Create Blockbase Theme button, it just forwards me to WordPress login page.

I should note that the site I am using this on is in a sub directory (i.e. domain.com/site) and upon clicking the button, it forwards to the parent site login page (i.e. domain.com/wp-admin)

I have the following installed:

WordPress 5.82
Blockbase 1.4.3
Gutenberg 11.9.0
(no other plugins)

Any idea what the issue is here?

Thanks,
Troy

With the incoming new default theme being style variation focused, this plugin could have an option to generate Global style changes into a variation instead of creating a new theme. This will help users unfamiliar with theme.json syntax to create a new style variation for a theme.

I recently ran into an issue where Create Block Theme was not showing in the wordpressdotorg user's list of plugins.

Please see this meta ticket for details:

https://meta.trac.wordpress.org/ticket/6539

In exploring the cause, it turns out that there are a couple of issues in the Create Block Theme's readme:

1 - "Author" is not a valid readme field and should be removed entirely:

Author: @wordpressdotorg

2 - Usernames in readme files should not include the @ so they should be removed here:

Contributors: @chaosexanima, @mikachan, @onemaggie, @pbking, @scruffian

3 - chaosexanima is not a WordPress.org username: https://profiles.wordpress.org/chaosexanima/ It should either be swapped out for the correct WP.org username, or removed.

4 - The wordpressdotorg user should be added first to the list of contributors

Thanks for having a look when you're able!

When creating a theme, the generated theme.json does not include the $schema key, and so doesn't automatically format the file.

We should add the following to the start of the generated theme.json:

"$schema": "https://schemas.wp.org/trunk/theme.json"

I would love to have a "Dev mode / Overwrite mode" that would never write any templates to the database, but always save them directly to the theme files instead.

I tested the Gutenberg patch that got dropped in favor of this, and I actually somewhat liked it better to be able to save templates from the editor itself. Not exactly like it was done, I rather just have one button to save all templates. Or, even better, what I suggested above.

As I am developping my first FSE theme, the only option that makes sense to me is to overwrite. And it's an additional hassle to have another tab open and having to manually save the template changes. The menu is very out-of-place IMO, it would be more fitting to have it directly inside the Site Editor, or at least the override option.

We could add empty templates with empty template parts for footer and header so that users can just pick one from the carrousel when that's available from the pattern directory.

I've tried with 5.8.3, 5.9 rc-2 with and without Gutenberg installed. I'm getting a fatal error or just a blank page. The fatal error is the same as in #20

Fatal error: Uncaught Error: Call to undefined function gutenberg_get_block_templates() in /home/digitaldepotco/public_html/betelgeuse/wp-content/plugins/create-blockbase-theme-trunk/index.php:156 Stack trace: #0 /home/digitaldepotco/public_html/betelgeuse/wp-content/plugins/create-blockbase-theme-trunk/index.php(245): gutenberg_edit_site_export_theme_create_zip('/tmp/betelgeuse...', Array) #1 /home/digitaldepotco/public_html/betelgeuse/wp-content/plugins/create-blockbase-theme-trunk/index.php(323): gutenberg_edit_site_export_theme(Array) #2 /home/digitaldepotco/public_html/betelgeuse/wp-includes/class-wp-hook.php(307): blockbase_save_theme('') #3 /home/digitaldepotco/public_html/betelgeuse/wp-includes/class-wp-hook.php(331): WP_Hook->apply_filters(NULL, Array) #4 /home/digitaldepotco/public_html/betelgeuse/wp-includes/plugin.php(474): WP_Hook->do_action(Array) #5 /home/digitaldepotco/public_html/betelgeuse/wp-admin/admin.php(175): do_action('admin_init') #6 /home/digitaldepotco/public_html/betelgeuse/wp-admin/themes.php( in /home/digitaldepotco/public_html/betelgeuse/wp-content/plugins/create-blockbase-theme-trunk/index.php on line 156

Sorry if this question is naive!

What do you think about adding a fifth option to the plugin — create a new boilerplate theme from scratch, maybe based on block-canvas or something like it?

When I meet folks that are new to block theming, the first thing they always ask is for a reference point — a starter, boilerplate block theme. Also the name of this plugin implies it could create a "new" theme, to me, maybe disconnected from the currently active one. (This is the perspective of someone who has used "create-react-app" before coming to WordPress, and using that utility results in a blank application, granted there's more tooling and overhead involved there because of webpack...)

This might make more sense as a CLI or maybe even in Gutenberg itself, but wanted to ask in any case.

It would be helpful if the theme creation options allowed users to upload a unique screenshot that would be packaged with the theme download. This will make the newly created themes look much nicer when they are shared and installed on another WordPress site and make them easier to distinguish from other themes that might have been generated this way.

Hi there !

I'm using blockbase theme and created a child theme with the create blockbase theme plugin.
When I activate my child theme, I don't have a full access to the customizer and the customization I made were not applied (background color, fonts…).

Here is what I see in the child theme :

And in the parent theme (blockbase) :

What am I doing wrong ?

Thanks !

There's a related/similar idea in this issue but we didn't pursue it since it creates some confusion or the average user with reusable blocks.

Since this plugin is meant to be used by theme creators, it would make sense to give them the ability to save their patterns while they are creating them instead of having to go in and register them as a totally separate step.

I think this can be as easy as adding this option to the Group block but I don't have strong feelings about the experience as long as it's available in the actual editor.

Currently the plugin has no mechanism to identify the duplicate fonts, and it lets duplicate fonts to be added.

It can be improved by identifying the duplicates (the google fonts) with name or some other information such as fontID, and disable them to be added again to the theme (and may be a label indicating it already added to the theme, to avoid confusion of why a font is disabled).

I have two proposals to 'Override theme' option:

1. Change the button to 'Override theme' when this option is selected. Now the button is the same that with the other options: Export theme, and the action is really different.
2. Add a Warning when the option 'Override theme' gets selected to inform the user cristal clear that when click the button the active theme will be overridden, not exported

Thanks!

Initially, Create block theme had one theme page. Now it has three.

Is now a good time to move the menu item to its own top-level menu item, after Appearance, to handle the three current pages, and any possible future pages?

I was experimenting with the plugin and making changes to the Blockbase theme. When I import the cloned theme into another local WordPress install, I get several errors regarding missing block pattern templates. For example:

Warning: file_get_contents(www.mytestsite.dev.cc/wp-content/themes/cloneofblockbase/block-template-parts/header-centered.html): failed to open stream: No such file or directory in www.mytestsite.dev.cc\wp-content\themes\cloneofblockbase\inc\block-patterns.php on line 55

Exporting as a child theme seems to be a good workaround at this point.

Here is my error when creating a child theme for the block theme "skatepark" by automattic.
(Win 10, WordPress 6.0, theme skatepark, on localwp (by flywheel)
Help is much appreciated.

Right now we are not validating the form in any capacity. At the very least we need to make the name of the theme required and sanitize all the inputs submitted by the user.

Hi,

First of all, thanks for this plugin. I just installed it, but I already see the benefits for me as a theme developer.

I noticed a small issue: the line-height values in the exported theme's theme.json file were slightly off:

Original:

"line-height": {
	"tiny": 1.1,
	"small": 1.2,
	"medium": 1.4,
	"normal": 1.725
}

Export:

"line-height": {
	"medium": 1.3999999999999999,
	"normal": 1.7250000000000001,
	"small": 1.2,
	"tiny": 1.1000000000000001
}

Apparently they are also sorted different 😜

Thinking about updating the plugin to include non universal themes, the problem with choosing fonts for the theme comes to mind. Here's an idea:

On the form we can include the option to add a specific font, then generate a functions.php file that enqueues that. We would have to add that same font to the theme.json file we are generating too.

How many fonts can a user choose for a theme? How do we handle different weights/styles? Do we include the font files or do we use google fonts links?

When EXPORTING a theme if the theme with changes is installed again (or if something like saving a theme happens) then USER changes are still shown. We may want to consider clearing the user changes when a theme is SAVED (essentially moving that changes from 'user space' to 'theme space' rather than COPYING from 'user space' to 'theme space'.

As we bring changes in it would be fantastic to ship those changes automatically to WordPress.org

This is a good github action to automate this.

This covers the required assets to be added in order for submission to the WP Plugin directory:

• Plugin icon
• Plugin screenshot(s)
• Plugin header image

I noticed that when a theme.json is merged with site editor based data the lineHeight property is set to be a number when it should be a string. It doesn't seem to be happening with the core theme export.

Plugin creates clone of the theme successfully.
But it creates with new directory structure for parts and templates but not for patterns.

block-template-parts => parts
block-templates => templates
inc/patterns => inc/patterns

UI doesn't render the patterns in the newly created theme.

The instructions and descriptions given on the form are not very clear and designed poorly.

Update the form to give clear instructions and descriptions of the options. (What should this be? How should it be designed?)

Update the form to better handle required fields (Name should be required when prompted). Javascript might be necessary to handle this.

We should alert the user when any of the dependencies are not present:

• Check that GB is installed, active and is the latest version (or one we define is needed for the plugin)
• Check that Blockbase is installed. Maybe warn the user if the version is not the latest, but allow them to use it if it's not.
• Check that the active theme is Blockbase or one of its children

This was discovered during @DaisyOlsen WCUS workshop. We created 3 template parts via the Site Editor and there was no parts directory in the theme. Running the Overwrite {Theme Name} Theme command caused a fatal error.

It looks like adding a check for the folder and creating it before trying to write the files would address the issue - https://github.com/WordPress/create-block-theme/blob/trunk/admin/class-create-block-theme-admin.php#L595

Steps to Reproduce

1. Create a custom theme
2. Do not include a parts directory
3. Create a Header and Footer template part via the Site Editor and save.
4. Run the Override functionality.

The uploaded screenshot shows some UI strings cannot be translated, please make the following UI strings translatable.

• Info
• This is a list of your font families listed in the theme.json file of your theme.
• If your theme.json makes reference to fonts providers other than local they may not be displayed correctly.
• These are the fonts currently embedded in your theme
• Weight
• Preview
• Remove Font Family
• Remove
• This action will delete the font definition and the font file assets from your theme.
• Are you sure you want to delete "style-name" variant of "font-name" from your theme?
• Are you sure you want to delete "font-name" from your theme?

As @jffng requested here I guess we should add some documentation on how to contribute with code to the plugin.

Hi,

When I go to Appearance > Create Blockbase Theme, fill in the fields and click the Create Blockbase Theme button, it downloads a .zip file succesfully, but the file is 0 bytes. When I try to unzip it, I get a .zip.cpgz file, which I'm unable to open.

I have the following installed:

WordPress 5.82
Blockbase 1.4.3
Gutenberg 11.9.0
(no other plugins)

Thanks,
Troy

Problem

Site editor changes are not copied in new themes.

Steps

• Create a child theme of Blockbase (call it Blockbase Child) and activate.
• Do edit to post and footer in site editor
• Now create a clone or sibling theme and activate it.
• Observe that only few updates copied to new theme.

Update post content styles

Updated style of index/footer

Now create a clone or sibling theme and activate it.
Observe that only few updates copied to new theme.

Parts is empty and templates has only index.html