woltapp / parallelpbf Goto Github PK

I'm writing a tool to create country-based PBF files from the planet.pbf using parallelpbf for both reading and writing.

When Nodes without tags are writing to the country PBF file, this results in a "corrupt" file. Meaning that PBF file consumers like Osmosis, jOSM but also parallelpbf cannot read.

When in my tool I add a dummy tag to Nodes that don't have a tag the output PBF files are correct.

I think the root cause is in https://github.com/woltapp/parallelpbf/blob/master/src/main/java/com/wolt/osm/parallelpbf/encoder/DenseNodesEncoder.java where it unconditionally adds the tag delimiter. That should most likely only happen when there are tags. At least, that's what I see in the Osmosis implementation.

This happens because of code in line 363 in ParallelBinaryParser :

tasksInFlight = tasksInFlight.stream().filter(f -> !f.isDone()).collect(Collectors.toList());
For a failed Future<?> method isDone() returns true, so some failed futures are lost here. Method .get() will never be invoked on them, so the failures are not anyhow propagated. Also parser execution may not be stopped on failure.

Hi! Quick question… Is this library able to parse the PBF format from an ESRI feature service?

thanks!

hi.

The original osm dependency for Java has a type called WayNode. which is a simple nodeId with latitude and longitude of the node.

In addition to the List<Node> nodes; that each Way has, in osm library the Way type also has a List<WayNode> wayNodes;.

can you guys please add this field to the Way class or it is not possible?

https://github.com/akashihi/parallelpbf/blob/f5c20302b611ee3217bd8679eda5f2da63484c26/src/main/java/org/akashihi/osm/parallelpbf/entity/BoundBox.java#L45

I cannot add this dependency to my project as 0.3.0 version is missing in maven: https://mvnrepository.com/artifact/com.wolt.osm/parallelpbf
When I try 0.2.0 - then crosby.binary:osmpbf:1.2.1 is missing.

I've tried maven, jcenter and google repositories.

Hello, and thanks for the nice lib.

i wonder if there's a way to cancel parsing? For example if you're looking for some specific Node or Way, and once you found it, you don't want to continue parsing the whole thing.