Problem parsing a sample file about mt940 HOT 4 CLOSED

Hrm... I forgot that you actually need to escape the # in this case. I suppose the easiest way would be a manual checkout followed by a pip install -e directory
Next time I'll omit the # :)

I'll take a look at the modified output soon, the mt940 parsing is a bit fragile due to all the (partially) incorrect implementations around

from mt940.

Took a bit of time to investigate further, but I found the problem. This example uses extra (non-swift, indicated by :NS: data) which wasn't supported yet.

Since the entire code assumes that all tags are always numeric, this was a bit of an issue but I believe it will work correctly now :)

from mt940.

Hi @raphaelm

Sorry for breaking the code in your case. Apparently there's another implementation of the MT940 standard I wasn't aware of. Can you test if the hotfix/#23 branch solves your problem?
https://github.com/WoLpH/mt940/tree/hotfix/%2323

from mt940.

Hi,

no worries, as I said thats only an example I use for testing, no real users harmed. Thanks for maintaining this high-quality library!

Yes, your fix removes the exception. Thank you! Just so you now, the output differs slightly from 3.8:

{'customer_reference': '68790452', 'transaction_reference': 'STARTUMS', 'id': 'S051', 'funds_code': 'M', 'currency': 'DEM', 'entry_date': Date(2002, 3, 20), 'extra_details': ':NS:01Verwendungszweck 1', 'bank_reference': None, 'status': 'C', 'amount': <5000.00 DEM>, 'date': Date(2002, 3, 17)}
...
{'customer_reference': '', 'transaction_reference': 'STARTUMS', 'funds_code': 'M', 'currency': 'DEM', 'id': 'S051', 'extra_details': ':NS:01bekannt', 'bank_reference': None, 'status': 'D', 'amount': <-50000.00 DEM>, 'date': Date(2002, 3, 24)}

In 3.8 the extra_details fields have been empty, but that is totally okay to me.

On a side node, it is surprisingly hard to pip install from a git branch that includes a / and a # ;)

from mt940.