Code Monkey home page Code Monkey logo

Comments (4)

wolph avatar wolph commented on July 30, 2024 1

Good point, I'll release a fix soon. This might not be my only package suffering from this issue

from mt940.

wolph avatar wolph commented on July 30, 2024 1

I've uploaded a new release to PyPI :)

from mt940.

MaicoTimmerman avatar MaicoTimmerman commented on July 30, 2024

@wolph I believe somehow this issue is still present.

I've installed a fresh virtual environment and install the latest version:

python -m virtualenv venv
source venv/bin/activate
pip install mt-940==4.23.0
ls venv/lib/python3.10/site-packages/tests

shows the following content:

betterplace/  conftest.py  jejik/  __pycache__/  self-provided/       test_metadata.py  test_processors.py   test_tags.py
cmxl/         __init__.py  mBank/  sberbank/     test_entry_dates.py  test_parse.py     test_sta_parsing.py  test_utils.py

Comparing tests and mt940_tests, I believe these might be leftover local changes that have been included during packaging:

diff -q venv/lib/python3.10/site-packages/tests/ venv/lib/python3.10/site-packages/mt940_tests/
Common subdirectories: venv/lib/python3.10/site-packages/tests/betterplace and venv/lib/python3.10/site-packages/mt940_tests/betterplace
Common subdirectories: venv/lib/python3.10/site-packages/tests/cmxl and venv/lib/python3.10/site-packages/mt940_tests/cmxl
Files venv/lib/python3.10/site-packages/tests/conftest.py and venv/lib/python3.10/site-packages/mt940_tests/conftest.py differ
Common subdirectories: venv/lib/python3.10/site-packages/tests/jejik and venv/lib/python3.10/site-packages/mt940_tests/jejik
Common subdirectories: venv/lib/python3.10/site-packages/tests/mBank and venv/lib/python3.10/site-packages/mt940_tests/mBank
Common subdirectories: venv/lib/python3.10/site-packages/tests/__pycache__ and venv/lib/python3.10/site-packages/mt940_tests/__pycache__
Common subdirectories: venv/lib/python3.10/site-packages/tests/sberbank and venv/lib/python3.10/site-packages/mt940_tests/sberbank
Common subdirectories: venv/lib/python3.10/site-packages/tests/self-provided and venv/lib/python3.10/site-packages/mt940_tests/self-provided
Files venv/lib/python3.10/site-packages/tests/test_parse.py and venv/lib/python3.10/site-packages/mt940_tests/test_parse.py differ
Files venv/lib/python3.10/site-packages/tests/test_processors.py and venv/lib/python3.10/site-packages/mt940_tests/test_processors.py differ
Files venv/lib/python3.10/site-packages/tests/test_tags.py and venv/lib/python3.10/site-packages/mt940_tests/test_tags.py differ

Apart from that, I also feel like shipping and packaging mt940_test test directory is not considered good practice and should be added to the excludes:
https://github.com/WoLpH/mt940/blob/d3f8b44f26b220f5bf97bf448f8960efe4278d3f/setup.py#L98

from mt940.

wolph avatar wolph commented on July 30, 2024

You're right. The tests were still bundled. I've since switched to a new build system and I've pushed a new release without any tests

from mt940.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.