Code Monkey home page Code Monkey logo

customcrafting's Introduction

Hi my name is Gunnar,

aka. Wolfy, WolfyScript

WolfyScripts GitHub Stats

I'm a Computer Science Student and Java Developer.
I first started working on Minecraft mods/plugins in 2015.
Since then I develop mostly Spigot plugins and other side-projects in my freetime.

Social





โš™๏ธ Projects

Minecraft plugins/mods:

Plugins/Mods designed to extend customizability and make content creation easier.

  • CustomCrafting - Makes it easier to create complex custom recipes for Minecraft.
  • WolfyUtils - API that makes it easier to create in-game GUIs, and provides common utilities.
Other Projects:
  • HOCON Dataformat Jackson - HOCON dataformat support for the Jackson JSON library

๐Ÿ’ป Setup

Check out my partner!

customcrafting's People

Contributors

beepowuff avatar eikoocs avatar pavel-gornov avatar snowcutieowo avatar wolfyscript avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

customcrafting's Issues

MMOItems support seems can not work well

What happened?

When I use customcrafting-3.16.3.1 , MMOItems-6.7.2 and Purpur 1.18.1 and create some recipes that contains MMO item, I noticed that the recipe is stored in the json like this:

{
  "@type" : "customcrafting:crafting_shaped",
  "group" : "",
  "hidden" : false,
  "vanillaBook" : false,
  "priority" : "NORMAL",
  "checkNBT" : true,
  "conditions" : {
    "values" : [ ]
  },
  "symmetry" : {
    "horizontal" : false,
    "vertical" : false,
    "rotate" : false
  },
  "shape" : [ "D F", "G I" ],
  "ingredients" : {
    "G" : {
      "items" : [ {
        "custom_amount" : 1,
        "item" : {
          "==" : "org.bukkit.inventory.ItemStack",
          "v" : 2865,
          "type" : "LEATHER"
        }
      } ],
      "tags" : [ ],
      "replaceWithRemains" : true,
      "allowEmpty" : false
    },
    "I" : {
      "items" : [ {
        "custom_amount" : 1,
        "item" : {
          "==" : "org.bukkit.inventory.ItemStack",
          "v" : 2865,
          "type" : "LEATHER"
        }
      } ],
      "tags" : [ ],
      "replaceWithRemains" : true,
      "allowEmpty" : false
    },
    "D" : {
      "items" : [ {
        "custom_amount" : 1,
        "item" : {
          "==" : "org.bukkit.inventory.ItemStack",
          "v" : 2865,
          "type" : "LEATHER"
        }
      } ],
      "tags" : [ ],
      "replaceWithRemains" : true,
      "allowEmpty" : false
    },
    "F" : {
      "items" : [ {
        "custom_amount" : 1,
        "item" : {
          "==" : "org.bukkit.inventory.ItemStack",
          "v" : 2865,
          "type" : "LEATHER"
        }
      } ],
      "tags" : [ ],
      "replaceWithRemains" : true,
      "allowEmpty" : false
    }
  },
  "settings" : {
    "allowVanillaRecipe" : true
  },
  "result" : {
    "items" : [ {
      "custom_amount" : 1,
      "mmoitems" : {
        "type" : "ARMOR",
        "name" : "็šฎ้ฉ้ดๅญ"
      }
    } ],
    "tags" : [ ],
    "extensions" : [ ]
  }
}

But I need to update to 1.18.2 and when I update plugin to customcrafting-spigot-3.16.3.3 and MMOItems-6.7.3, I find that the recipe is stored like this:

{
  "@type" : "customcrafting:crafting_shaped",
  "group" : "",
  "hidden" : false,
  "vanillaBook" : true,
  "priority" : "NORMAL",
  "checkNBT" : false,
  "conditions" : {
    "values" : [ ]
  },
  "symmetry" : {
    "horizontal" : true,
    "vertical" : false,
    "rotate" : false
  },
  "shape" : [ "C", "F", "I" ],
  "ingredients" : {
    "I" : {
      "items" : [ {
        "custom_amount" : 1,
        "item" : {
          "==" : "org.bukkit.inventory.ItemStack",
          "v" : 2975,
          "type" : "STICK"
        }
      } ],
      "tags" : [ ],
      "replaceWithRemains" : true,
      "allowEmpty" : false
    },
    "C" : {
      "items" : [ {
        "custom_amount" : 1,
        "item" : {
          "==" : "org.bukkit.inventory.ItemStack",
          "v" : 2975,
          "type" : "NETHERITE_INGOT"
        }
      } ],
      "tags" : [ ],
      "replaceWithRemains" : true,
      "allowEmpty" : false
    },
    "F" : {
      "items" : [ {
        "custom_amount" : 1,
        "item" : {
          "==" : "org.bukkit.inventory.ItemStack",
          "v" : 2975,
          "type" : "NETHERITE_INGOT"
        }
      } ],
      "tags" : [ ],
      "replaceWithRemains" : true,
      "allowEmpty" : false
    }
  },
  "checkAllNBT" : false,
  "settings" : { },
  "result" : {
    "items" : [ {
      "custom_amount" : 1,
      "item" : {
        "==" : "org.bukkit.inventory.ItemStack",
        "v" : 2975,
        "type" : "STONE_SWORD",
        "meta" : {
          "==" : "ItemMeta",
          "meta-type" : "UNSPECIFIC",
          "display-name" : "{\"italic\":false,\"color\":\"white\",\"text\":\"ๅˆ้‡‘ๅŒ•้ฆ–\"}",
          "lore" : [ "{\"italic\":false,\"text\":\"\"}", "{\"italic\":false,\"extra\":[{\"color\":\"gray\",\"text\":\"็‰ฉๅ“็ฑปๅž‹: \"},{\"color\":\"white\",\"text\":\"ๅŒ•้ฆ–\"}],\"text\":\"\"}", "{\"italic\":false,\"text\":\"\"}", "{\"italic\":false,\"extra\":[{\"color\":\"gray\",\"text\":\"โžธ ๆ”ปๅ‡ปไผคๅฎณ: \"},{\"color\":\"white\",\"text\":\"11\"}],\"text\":\"\"}", "{\"italic\":false,\"extra\":[{\"color\":\"gray\",\"text\":\"โžธ ๆ”ปๅ‡ป้€Ÿๅบฆ: \"},{\"color\":\"white\",\"text\":\"2\"}],\"text\":\"\"}", "{\"italic\":false,\"extra\":[{\"color\":\"gray\",\"text\":\"โ–  ๆšดๅ‡ปๆฆ‚็Ž‡: \"},{\"color\":\"white\",\"text\":\"+20.4%\"}],\"text\":\"\"}", "{\"italic\":false,\"text\":\"\"}", "{\"italic\":false,\"color\":\"gray\",\"text\":\"่€ไน…: 118 / 118\"}" ],
          "custom-model-data" : 10017,
          "attribute-modifiers" : {
            "GENERIC_ATTACK_SPEED" : [ {
              "==" : "org.bukkit.attribute.AttributeModifier",
              "amount" : 0.0,
              "name" : "mmoitemsDecoy",
              "uuid" : "87851e28-af12-43f6-898e-c62bde6bd0ec",
              "operation" : 0
            } ]
          },
          "ItemFlags" : [ "HIDE_ATTRIBUTES" ],
          "internal" : "H4sIAAAAAAAA/+NiYGBjEPP19fcMcfUNjncMCXF09o53cfR1dHd1UGMAAzYGUXQFwQGuri4ODL7v7u+6Z87BIACXB5Hxni4MPE8ndLxsn/i0Z+rLZdM4GHjhCvwcfV0Z+NTSUOUF4fKufs4ejn4hwQxM0bHMDCJw8SDXMM9gT38/kOFAwMwgDpfydYyIdwkNcnTy9PEMiQRKljEzSMFlnUODQ/x94339XVx9gB4LcWRgUFdkRFLg4hns6OTjCrQhwNEzyNPPnZGDQQjVQyGRAa4MbC6O7u6uQRwMfB7BIUGRCJc6VCsFlySWKFkpwYSUdJT83YNL8osqlayiq5UwPBd/eGNxSRFQQ3SsUm1sLQeKP0GugNoICSRGBnkMx0LjIcAxONgzzJWRDUmJc5BniKezo0880JWe3q7xICudXR1M0p9UM3z7wYEUmS6RwNjwdI738Q9yZeiPVgI6W838eefKp5Mbn2/c/XRet5UCMKLAUQSUAss+mrdD4dmU3U/bdz/Zs+Tpus0gFYaGaFIvG+Y/3bUMJGUEkZm2QOHZrC1AmWfLmp73tYNktI0M9ExUYca+aJjwZGerlYKhoYWCPohUimUAADON4l2bAgAA"
        }
      }
    } ],
    "tags" : [ ],
    "extensions" : [ ]
  }
}

It seems that MMO items can not be stored correctly. And the recipe item can not update to the changes in MMOItems anymore.

How can the bug be reproduced?

Update the version and find the problem.

Expected Behaviour?

Item from MMOItems can update in Customcrafting correctly.

Plugin version

wolfyutils-spigot-4.16.0.0 customcrafting-spigot-3.16.3.3

Server software

Purpur 1.18.2

Relevant log output

No response

Submit issue

  • read the Wiki and especially the FaQ, and made sure there is no fix to your issue,
  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

Bug recipes in StoneCutter

What happened?

A bug happened! crafts are swapped.
image

How can the bug be reproduced?

Create a lot of recipes for stonecutter and some blocks will be visually swapped.

Expected Behaviour?

fix pls.

Plugin version

CustomCrafting 3.16.3.1, WolfyUtilites 3.16.3.2

Server software

Purpur 1.18.2

Relevant log output

No response

Submit issue

  • read the Wiki and especially the FaQ, and made sure there is no fix to your issue,
  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

Connection to my plugin

The Problem

I wanna use CC in my plugin, so can I open elite workbench or advanced workbench using your plugin like a dependency or anything like this?

I saw same theme, but it was a several months ago I think, and I decided that something may change.

Solution

Maybe some command for this or method like player.getGuiHandler.open..... or perhaps a more complex way.

Alternatives

Additional Context

Submit issue

  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

Elite Workbench Condition Always Fails

What happened?

Elite Crafting Table recipes with the Elite Crafting Table condition are never craftable even in the correct Elite Crafting Table.

Notes:
The specific comparison that is causing check() to fail is customItem.getApiReference() instanceof WolfyUtilitiesRef as customItem.getApiReference() is actually an instance of VanillaRef.
Removing this check and updating the line below to use customItem directly does allow the recipes to work and be restricted as expected however the restricted recipes still don't show in the recipe book opened from the Elite Crafting Table GUI.

How can the bug be reproduced?

  1. Create or have an existing Elite Crafting Table to restrict the recipe to
  2. Create an Elite Crafting Table recipe
  3. Add the Elite Crafting Table condition to your recipe and limit it to the Elite Crafting Table from step 1

Expected Behaviour?

The Elite Crafting Table recipe should be craftable in the specified Elite Crafting Table

Plugin version

CustomCrafting 3.16.1.0 (dev) WolfyUtilities 3.16.0.0 (dev)

Server software

Paper 1.18.1

Relevant log output

No response

Submit issue

  • read the Wiki and especially the FaQ, and made sure there is no fix to your issue,
  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

Smithing Table recipes reset back to Use Result Item every reload or restart

What happened?

Every time a server restarts every result items gets changed from Material Only to Use Result Item
No console error.

2022-01-22_11 51 10
2022-01-22_11 51 14
2022-01-22_11 51 18

Zipped recipe that is used in the screenshots
toolsandarmorupgrade.zip

How can the bug be reproduced?

  1. Create a smithing table recipe, upgrading iron to diamond sword using a custom item with custom name and NBT for example.
  2. Choose Ignore Meta and set it to Material Only
  3. Test the recipe without reloading or restarting first, it will work just fine
  4. Restart server or reload plugin
  5. Test it again, this time the result item will ignore all NBTs of the material item and only give a regular diamond sword

Expected Behaviour?

The recipe should stay as Material Only

Plugin version

CustomCrafting 3.16
WolfyUtilities 3.16

Server software

Purpur 1.18.1

Relevant log output

No response

Submit issue

  • read the Wiki and especially the FaQ, and made sure there is no fix to your issue,
  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

Cauldrons to include %time% support in recipe book lang

The Problem

Brewing time not shown in cauldron tooltip when hovering, like furnace recipes do. Also no support for the %time% placeholder in lang file to do it yourself.

Solution

Add support for %time% placeholder on cauldrons in lang files, and optionally add something to this effect to the water/true|false strings in en_us lore text:

"&7Brewing Time: &e%time% ticks"

Alternatives

Alternatively, Could add a clock icon (like in recipe creation) that shows time for each type of timed recipe, furnace, campfire, etc to further make time it's own thing, perhaps.

Additional Context

I had some players a bit confused about how to do cauldron recipes on their own, regarding needing to right-click with a bottle and when the recipe is completed. I'm not 100% sure what to say regarding the bottle other than another icon designating which item is needed to interact with the cauldron when recipe is completed, but thought i'd share that.

Submit issue

  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

Custom Items Vanilla Recipe Blocker feature is not working for smelting vanilla recipes

What happened?

Custom Item still can participate in vanilla smelting recipes even if the Vanilla Recipe Blocker is turned on. Tested on Furnace and Blast Furnace (Probably issue still works for Smoker)

How can the bug be reproduced?

Reproduction of a bug is easy:

  1. Configure an item with Item Creator, which can participate in vanilla smelting recipes (For example, a golden helmet)
  2. Turn on Vanilla Recipe Blocker for this item
  3. Put an item in a furnace and it will melt like any same vanilla item

Expected Behaviour?

Vanilla Recipe Blocker setting should really block custom item participation in any vanilla recipe, including smelting.

Plugin version

Custom Crafting 3.16.0.0

Server software

Purpur 1.18.1 (Paper 1.18.1 Fork)

Relevant log output

No response

Submit issue

  • read the Wiki and especially the FaQ, and made sure there is no fix to your issue,
  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

Add a command to open advanced/elite workbench

The Suggestion

Add a command such as /cc advanced /cc elite to open the workbench directly.
In this way we can bind command to NPCs and blocks.

  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

Error when using /customcrafting reload

What happened?

An error will appear when reload plugin

How can the bug be reproduced?

Just reload

Expected Behaviour?

nothing

Plugin version

wolfyutils-spigot-4.16.0.0 customcrafting-spigot-3.16.3.3

Server software

Purpur 1.18.2

Relevant log output

[22:21:01 INFO]: My_Id issued server command: /customcrafting reload
[22:21:01 INFO]: [CustomCrafting] Loaded fallback language "en_US" v6.0.0 translated by WolfyScript
[22:21:01 INFO]: [CustomCrafting] Loaded active language "en_US" v6.0.0 translated by WolfyScript
[22:21:01 INFO]: [CustomCrafting] Loading Recipes & Items
[22:21:01 INFO]: [CustomCrafting] - - - - [Local Storage] - - - -
[22:21:01 INFO]: [CustomCrafting] [LOCAL] Looking through data folder...
[22:21:01 INFO]: [CustomCrafting] [LOCAL] Loading Items
[22:21:01 INFO]: [CustomCrafting] [LOCAL] Loading Recipes
[22:21:01 INFO]: [CustomCrafting] [LOCAL] Loaded 3 recipes; Skipped: 0 error/s, 0 already existing
[22:21:01 INFO]: [CustomCrafting] [LOCAL_OLD] Loaded 0 recipes; Skipped: 0 error/s, 0 already existing
[22:21:01 INFO]: [CustomCrafting] [LOCAL_LEGACY] Loaded 0 recipes; Skipped: 0 error/s, 0 already existing
[22:21:01 INFO]: [CustomCrafting] [LOCAL] Loaded 3 recipes
[22:21:01 INFO]: [CustomCrafting]
[22:21:01 INFO]: [CustomCrafting] Indexing Recipe Book...
[22:21:01 INFO]: [CustomCrafting] Indexed Recipe Book!
[22:21:01 ERROR]: null
org.bukkit.command.CommandException: Unhandled exception executing 'customcrafting reload' in me.wolfyscript.customcrafting.commands.CommandCC(customcrafting)
        at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:182) ~[purpur-api-1.18.2-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.craftbukkit.v1_18_R2.CraftServer.dispatchCommand(CraftServer.java:906) ~[purpur-1.18.2.jar:git-Purpur-1623]
        at net.minecraft.server.network.ServerGamePacketListenerImpl.handleCommand(ServerGamePacketListenerImpl.java:2389) ~[?:?]
        at net.minecraft.server.network.ServerGamePacketListenerImpl.handleChat(ServerGamePacketListenerImpl.java:2200) ~[?:?]
        at net.minecraft.server.network.ServerGamePacketListenerImpl.handleChat(ServerGamePacketListenerImpl.java:2181) ~[?:?]
        at net.minecraft.network.protocol.game.ServerboundChatPacket.handle(ServerboundChatPacket.java:46) ~[?:?]
        at net.minecraft.network.protocol.game.ServerboundChatPacket.a(ServerboundChatPacket.java:6) ~[?:?]
        at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$1(PacketUtils.java:51) ~[?:?]
        at net.minecraft.server.TickTask.run(TickTask.java:18) ~[purpur-1.18.2.jar:git-Purpur-1623]
        at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:153) ~[?:?]
        at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24) ~[?:?]
        at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1426) ~[purpur-1.18.2.jar:git-Purpur-1623]
        at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:188) ~[purpur-1.18.2.jar:git-Purpur-1623]
        at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:126) ~[?:?]
        at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1403) ~[purpur-1.18.2.jar:git-Purpur-1623]
        at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1396) ~[purpur-1.18.2.jar:git-Purpur-1623]
        at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:136) ~[?:?]
        at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1374) ~[purpur-1.18.2.jar:git-Purpur-1623]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1256) ~[purpur-1.18.2.jar:git-Purpur-1623]
        at net.minecraft.server.MinecraftServer.lambda$spin$1(MinecraftServer.java:320) ~[purpur-1.18.2.jar:git-Purpur-1623]
        at java.lang.Thread.run(Thread.java:833) ~[?:?]
Caused by: java.lang.NullPointerException: Cannot invoke "org.bukkit.enchantments.Enchantment.getStartLevel()" because the return value of "org.bukkit.enchantments.EnchantmentWrapper.getEnchantment()" is null
        at org.bukkit.enchantments.EnchantmentWrapper.getStartLevel(EnchantmentWrapper.java:32) ~[purpur-api-1.18.2-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.inventory.ItemStack.addEnchantment(ItemStack.java:407) ~[purpur-api-1.18.2-R0.1-SNAPSHOT.jar:?]
        at me.wolfyscript.utilities.util.inventory.item_builder.AbstractItemBuilder.addEnchantment(AbstractItemBuilder.java:86) ~[wolfyutils-spigot-4.16.0.0.jar:?]
        at me.wolfyscript.customcrafting.gui.item_creator.ButtonArmorSlotToggle.<init>(ButtonArmorSlotToggle.java:49) ~[customcrafting-spigot-3.16.3.3.jar:?]
        at me.wolfyscript.customcrafting.gui.item_creator.tabs.TabArmorSlots.register(TabArmorSlots.java:50) ~[customcrafting-spigot-3.16.3.3.jar:?]
        at me.wolfyscript.customcrafting.gui.item_creator.MenuItemCreator.lambda$onInit$16(MenuItemCreator.java:161) ~[customcrafting-spigot-3.16.3.3.jar:?]
        at java.lang.Iterable.forEach(Iterable.java:75) ~[?:?]
        at me.wolfyscript.customcrafting.gui.item_creator.MenuItemCreator.onInit(MenuItemCreator.java:161) ~[customcrafting-spigot-3.16.3.3.jar:?]
        at me.wolfyscript.utilities.api.inventory.gui.GuiCluster.registerGuiWindow(GuiCluster.java:105) ~[wolfyutils-spigot-4.16.0.0.jar:?]
        at me.wolfyscript.customcrafting.gui.item_creator.ClusterItemCreator.onInit(ClusterItemCreator.java:43) ~[customcrafting-spigot-3.16.3.3.jar:?]
        at me.wolfyscript.utilities.api.inventory.gui.InventoryAPI.lambda$reset$2(InventoryAPI.java:173) ~[wolfyutils-spigot-4.16.0.0.jar:?]
        at java.util.HashMap.forEach(HashMap.java:1421) ~[?:?]
        at me.wolfyscript.utilities.api.inventory.gui.InventoryAPI.reset(InventoryAPI.java:173) ~[wolfyutils-spigot-4.16.0.0.jar:?]
        at me.wolfyscript.customcrafting.commands.cc_subcommands.ReloadSubCommand.onCommand(ReloadSubCommand.java:75) ~[customcrafting-spigot-3.16.3.3.jar:?]
        at me.wolfyscript.customcrafting.commands.IndexCommand.execute(IndexCommand.java:54) ~[customcrafting-spigot-3.16.3.3.jar:?]
        at me.wolfyscript.customcrafting.commands.CommandCC.execute(CommandCC.java:63) ~[customcrafting-spigot-3.16.3.3.jar:?]
        at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:172) ~[purpur-api-1.18.2-R0.1-SNAPSHOT.jar:?]
        ... 20 more

Submit issue

  • read the Wiki and especially the FaQ, and made sure there is no fix to your issue,
  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

Stacked ingredients are replaced with craft remains

The stacks of ingredients, that have craft remains, are always completely replaced by the craft remain.

Vanilla Minecraft:
Craft remains are placed into the inventory of the player.

CustomCrafting:
Ingredients are replaced with the craft remains no matter what. Turning a stack of milk buckets into buckets when it should only consume one.

Recipes in the smithing table eventually get lost after restarting the server or just like that

What happened?

recipes by themselves get lost and are not crafted in a blacksmith's table.

image

MyConfig:

{
  "@type" : "customcrafting:smithing",
  "group" : "",
  "hidden" : false,
  "vanillaBook" : true,
  "priority" : "NORMAL",
  "checkNBT" : false,
  "conditions" : {
    "values" : [ ]
  },
  "base" : {
    "items" : [ {
      "custom_amount" : 1,
      "item" : {
        "==" : "org.bukkit.inventory.ItemStack",
        "v" : 2975,
        "type" : "DIAMOND_HELMET",
        "meta" : {
          "==" : "ItemMeta",
          "meta-type" : "UNSPECIFIC",
          "lore" : [ ]
        }
      }
    } ],
    "tags" : [ ],
    "replaceWithRemains" : true,
    "allowEmpty" : false
  },
  "addition" : {
    "items" : [ {
      "custom_amount" : 1,
      "itemsadder" : "blessedcraft:necromium_ingot"
    } ],
    "tags" : [ ],
    "replaceWithRemains" : true,
    "allowEmpty" : false
  },
  "preserveEnchants" : true,
  "preserveDamage" : true,
  "onlyChangeMaterial" : false,
  "result" : {
    "items" : [ {
      "custom_amount" : 1,
      "eco" : "ecoarmor:set_necromium_helmet"
    } ],
    "tags" : [ ],
    "extensions" : [ ]
  }
}

How can the bug be reproduced?

Create 10 recipes from ItemsAdder or EcoArmors.
damage or enchant the armor and try to craft your custom armor from it, some elements will not be crafted, I don't know what this is related to.

Expected Behaviour?

damage or enchant the armor and try to craft your custom armor from it, some elements will not be crafted, I don't know what this is related to.

Plugin version

CustomCrafting 3.16.3.1, WolfyUtilites 3.16.3.2

Server software

Purpur 1.18.2

Relevant log output

f

Submit issue

  • read the Wiki and especially the FaQ, and made sure there is no fix to your issue,
  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

Anvils makes you lose materials.

Example, you have this crafting:
image
But if you use more than 1 in the first slot:
image
And you try to obtain that 1 output.
image
It takes all materials.
This should left 63 materials in the first slot.
Like this:
image

EcoArmors + CustomCrafting = bug recipe

What happened?

A bug happened!

How can the bug be reproduced?

see video. https://youtu.be/P9I1cnhfsgo

Expected Behaviour?

Fix pls. See video. https://youtu.be/P9I1cnhfsgo

Plugin version

CustomCrafting 3.16.3.1, Wolfy 3.16.3.0

Server software

Purpur 1.18.2

Relevant log output

no logs.

Submit issue

  • read the Wiki and especially the FaQ, and made sure there is no fix to your issue,
  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

Elite Crafting Table Recipe Book Issues

What happened?

Both of the below pertain to opening the Recipe Book using the button in the Elite Crafting Table GUI;

  1. Opening the Recipe Book will display single categories instead of skipping to viewing recipes.
  2. Opening the Recipe Book after previously viewing a recipe will display a blank recipe.

Video: https://puu.sh/IIo5D/81fcec53aa.mp4

Notes:

  1. Looks like this is exactly the same issue as was addressed for the recipe book item in #63. Perhaps that fix should be more centralised to work for all instances of the recipe book being opened.
  2. As far as I can tell this is due to the RECIPE_BOOK button in EliteCraftingCluster not calling recipe.prepareMenu() as clicking the recipe in the recipe book would.

Additional:
Something that may want to be considered as a limitation. If you have elite crafting recipes but no categories to display them, the recipe book from an elite crafting table will basically just be empty.

How can the bug be reproduced?

  1. Configure at least one elite crafting table and recipe.
  2. Configure your recipe book to have only one category that will show your elite crafting table recipe.
  3. Open the elite crafting table GUI and click the recipe book
  4. Note that a single category is shown
  5. Click the category
  6. Click your recipe
  7. Exit the recipe book GUI with escape or similar
  8. Open the elite crafting table and the recipe book again
  9. Note that a blank recipe is shown

Expected Behaviour?

  1. Single recipe book categories will be skipped past and the recipe list displayed
  2. The recipe will be displayed correctly

Plugin version

CustomCrafting 3.16.2.1 (dev) WolfyUtilities 3.16.0.0 (dev)

Server software

Paper 1.18.1

Relevant log output

No response

Submit issue

  • read the Wiki and especially the FaQ, and made sure there is no fix to your issue,
  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

Layout Custimization

The Problem

There is no way for us to custumize the layout of Elite Crafting Tables.

Solution

Adding an option in the gui where you can move things for the Layout of the Elite Crafting table

Alternatives

Even just adding a config.yml option, or even an option in the .json file.

Additional Context

I need this feature due to me wanting to overlay a imagine over to make it look like a custom GUI.

Submit issue

  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

No working custom durability EcoArmors/ItemsAdder

What happened?

NO working custom durability in plugin ItemsAdder/EcoArmors
image

How can the bug be reproduced?

custom durability from my items no working. my custom items - leather armor from textures and custom-model-data.

Expected Behaviour?

it is necessary that the plugin reads the custom strength of the armor.

Plugin version

CustomCrafting 3.16.3.1, WolfyUtilites 3.16.3.2

Server software

Purpur 1.18.2

Relevant log output

No response

Submit issue

  • read the Wiki and especially the FaQ, and made sure there is no fix to your issue,
  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

Furnace recipe requires exact NBT for custom items

What happened?

Impossible to reproduce vanilla armor/tool smelting behaviour for custom items due to furnace recipe requires exact NBT data. Even if item is configured with custom items system, furnace can't recognize renamed/enchanted items.

How can the bug be reproduced?

Bug reproduction is easy:

  1. Configure an item with Item Creator
  2. Give an item with Item List
  3. Make a smelting recipe with given item
  4. That's all. When you rename given configured item or enchant it, recipe won't work anymore (But in vanilla you can smelt any type of same item)

Expected Behaviour?

Exact same behaviour like it works for workbench. Workbench recognizes custom item even if it's enchanted or renamed.

Plugin version

Custom Crafting 3.16.0.0

Server software

Purpur 1.18.1 (Paper 1.18.1 Fork)

Relevant log output

No response

Submit issue

  • read the Wiki and especially the FaQ, and made sure there is no fix to your issue,
  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

Scoreboard Score Crafting Condition

The Problem

No not really, just inconvenience.

Solution

A crafting condition which checks if a player has a certain amount of score in a scoreboard objective.

It might look something like this:
has score?
objective: Skeleton Kills
score: 15

I would also recommend allowing some form of comparators that can be used in the score (if possible). Example:

has score?
objective: Skeleton Kills
score >15

Alternatives

None.

Additional Context

None.

Submit issue

  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

make it easier to edit/delete/view recipes

The Problem

/cc and recipes section just lists the names of the recipes. and if you click on something and exit you get sent to the start. its much harder and more annoying to find something and edit it then in /recipes where i can see each item and from without reading anything what is what. i suggest making so in /recipes you can edit/delete the recipes there or make so the recipes section in /cc shows the items u get for the item displaying the recipe. so im suggesting to replace chests with the item your making to make it eaiser to find the recipe your looking for.

Solution

so im suggesting to replace chests with the item your making to make it eaiser to find the recipe your looking for.

Alternatives

?

Additional Context

none

Submit issue

  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

Weird console error; all custom crafting recipes disabled.

What happened?

All custom crafting recipes are disabled;
2022-04-01_18 00 27
Looks like the following.

How can the bug be reproduced?

After updating the plugin, the error started.

Expected Behaviour?

Not this.

Plugin version

customcrafting-spigot-3.16.3.2, wolfyutilities-3.16.3.2

Server software

Paper-409 (1.17.1)

Relevant log output

https://pastebin.com/uJ2wSmqs
Console log of the bug.

Submit issue

  • read the Wiki and especially the FaQ, and made sure there is no fix to your issue,
  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

"Copy" Merge Adapter

The Problem

Quite a few use cases aren't covered by existing merge adapters such as NBT data from other plugins or custom setups.

Solution

Create a generic "Copy" merge adapter that can copy a configurable set of NBT keys or sub-keys from the source item/s to the target.

Alternatives

N/A

Additional Context

Options could be similar to these;

  • Copy root level keys: "keys": [ "one", "two", "three" ].
  • Copy sub-keys: "keys": { "one": true, "two": [ "a", "b", "c" ] }.

Submit issue

  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

Combining enchantments in SmithingTable!

The Problem

Pls add Combining Enchantments functional broo! Example mod: https://www.9minecraft.net/mining-master-mod/

I use custom 9 ores, and each ore gives its own effect, for example, ruby - fire spell, citrine - luck, peridot - efficiency.
it is necessary that these ores increase each time the level of enchantment to the possible in vanilla mechanics.

image
image

Solution

Pls add Combining Enchantments functional broo! Example mod: https://www.9minecraft.net/mining-master-mod/

I use custom 9 ores, and each ore gives its own effect, for example, ruby - fire spell, citrine - luck, peridot - efficiency.
it is necessary that these ores increase each time the level of enchantment to the possible in vanilla mechanics.

Alternatives

https://www.9minecraft.net/mining-master-mod/

Additional Context

hehe screeeeen UP

Submit issue

  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

Crafting of netherite items

What happened?

I disabled the Crafting of netherite items and I can't craft them, but sometimes players manage to do it, since armor flashes in the crafting window for a second, can this be fixed?

How can the bug be reproduced?

just start crafting the item, if the server offers at this moment, then you can have time to pick it up from the result

Expected Behaviour?

If an item is disabled in crafting, it should not flash in the result window.

Plugin version

CustomCrafting v3.16.3.3 WolfyUtilities v4.16.1.0

Server software

Paper 1.18.2

Relevant log output

No response

Submit issue

  • read the Wiki and especially the FaQ, and made sure there is no fix to your issue,
  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

Some Custom Smoker recipes broken after reload or restart

What happened?

A bug happened!
Few custom Smoker recipes broken after /cc reload or Server restart

How can the bug be reproduced?

Create & Save 2 couple of custom item using same material (eg. 2 seed named Aseed and Bseed , 2 torch named Atorch and Btorch)
create custom smoker recepie like this
Aseed -> Atorch
Atorch -> Bseed
Bseed -> Btorch
in fact , a recipes like these is also affected
Aseed -> Bseed
Bseed -> Cseed,

then u can find that this recipes couldn't be done
they will burn in smoker forever , if fuels enough

And if i disable the recipes and enable them again , they can craft correctly,but the recipe book will broken(can't display anything)

Expected Behaviour?

recipes could be craft correctly

Plugin version

CC 3.16.3.3 WU 4.16.1.0

Server software

Paperspigot 1.17.1

Relevant log output

no error log at all

Submit issue

  • read the Wiki and especially the FaQ, and made sure there is no fix to your issue,
  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

PlaceholderAPI Condition

The Problem

There are many arbitrary conditions that users may want on their recipes that aren't supported by existing conditions and most likely won't be with future conditions if they are super specific.

Solution

In the same vein as #79 it may be worth adding a more generalised comparison condition that instead of comparing scoreboard values can compare the resolved value of a PlaceholderAPI placeholder.
The sheer number of placeholders available via plugins means this could be useful in quite a few different scenarios.

Alternatives

You can achieve similar functionality if you're using LuckPerms by using the ExtraContexts addon with the PlaceholderAPI Context to dynamically assign a permission based on the context which you then use in a recipe permission condition... but that's fairly complicated

Additional Context

An example use case that was brought up in the Discord server was restricting a recipe to only be available during certain real world dates for events, holidays, etc.
In this case the %server_time_<SimpleDateFormat>% placeholder set to just output date without time would be prime for comparisons.

Submit issue

  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

Create please group recipes in vanilla book!

The Problem

Create please group recipes in vanilla book!

Solution

Example groups recipes in Vanilla Book.

image

Alternatives

Example groups recipes in Vanilla Book.

image

Additional Context

Example groups recipes in Vanilla Book.

image

Submit issue

  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

Command to display a specific custom recipe

The Problem

It would be great if it's possible to create a command that allows players to see a specific recipe with a command

Can be a player or console command.

The format would go like this I guess:
/cc lookup (ign)

If it needs more arguments, I am fine with it

Solution

.

Alternatives

.

Additional Context

.

Submit issue

  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

customcrafting plugin + eco = no working register recipes furnace.

What happened?

I created a recipe in the oven for my custom ore so that the remelting from ore to ingot would work. But when I take an item with auto-smelt and break a block of ore, the ingot does not fall out, that is, the recipe is not read.

also, auto-smart does not work on the blocks I set from the creative or survival mode.

image

How can the bug be reproduced?

enchant pickaxe from: infernal_touch or auto-smelt and destroy custom ore - you looting no auto-smelting ore.

Expected Behaviour?

enchant pickaxe from: infernal_touch or auto-smelt and destroy custom ore - you looting no auto-smelting ore.

Plugin version

CustomCrafting 3.16.3.1, WolfyUtilites 3.16.3.2

Server software

Purpur 1.18.2

Relevant log output

No response

Submit issue

  • read the Wiki and especially the FaQ, and made sure there is no fix to your issue,
  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

PlaceHolder

I suggest making it possible to use Placeholder in the Title of all plugin menus. This applies to Elite Workbench, advanced workbench and others. Personally, I need this in order to use custom textures via oraxen.

Cauldron Random Result doesn't work

What happened?

It only gives the same result.

Plugin version

both are 3.16.0.0

Server software

purpur 1.17.1

Relevant log output

No response

Submit issue

  • read the Wiki and especially the FaQ, and made sure there is no fix to your issue,
  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

incorrect xp gained from custom recipe

What happened?

i made a furnace recipe and it gave 1 xp. but when i smelted 50 i only got 1 xp. if i collected them 1 by 1 tho id get 1 xp each time. so i dont think the xp amount you get increases with the amount of times uv smelted the thing

How can the bug be reproduced?

add a furnace recipe or other recipe that gives xp and complete the recipe and you will see it.

Expected Behaviour?

if you for example cook something 64 times and are meant to get 1 xp each time when collecting you will only get 1 xp

Plugin version

newest versions of both

Server software

spigot 1.17

Relevant log output

.

Submit issue

  • read the Wiki and especially the FaQ, and made sure there is no fix to your issue,
  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

Update player items automatically after changing them in CC menu.

The Problem

As of now, there's not really a way to auto-replace the items inside player's inventory when updating such items inside the CC menu.

Solution

Using the already implemented NBT tag system to replace non matching items in a timer would be an interesting way to do this.

Alternatives

To avoid lag, there could also be a global check with commands for items that are not correct.

Additional Context

[none]

Submit issue

  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

color tags not working

What happened?

When editing an item, namely, when you set a name or lore for it, the color tags do not work, see Figure 1

image

How can the bug be reproduced?

change name for item and with color tag

Expected Behaviour?

Colored text

Plugin version

customcrafting-spigot-3.16.3.3, wolfyutilities-3.16.3.2

Server software

Paper 1.17.1, build 409

Relevant log output

No response

Submit issue

  • read the Wiki and especially the FaQ, and made sure there is no fix to your issue,
  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

Add lava option to cauldrons

The Problem

Submitted by request of Beepo on Discord.

I'd love to see lava as a setting for cauldron recipes.
Perhaps, where you click to set water or empty cauldron, there can be an additional setting to allow for a lava cauldron.

Solution

Recipe example: If I put a slime ball in a cauldron, it would come out as a magma cream.
This could also be used as a "super power" furnace, where I could throw in cobble and it comes as magma.
Just examples of the possible uses. Imagination is the limit.

Alternatives

N/A

Additional Context

Original topic:
image

Submit issue

  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

Cauldron Recipes BROKEN

What happened?

Cauldron recipes have been broken since some time, I don't remember exactly how long but, yeah, it would be nice to fix it.

How can the bug be reproduced?

Make a cauldron recipe

item-input: beacon
item-output: slimeball
Output-mode: drop
item-require-hold: N/A

Fire-required: true
Water-required: true
Water-level: 3
Cooking-time: 40
Experience: 2.0
image

After attempting to save

item-input: reset
item-output: saved
Output-mode: reset
item-require-hold: saved

Fire-required: reset
Water-required: reset
Water-level: saved
Cooking-time: saved
Experience: saved
image

Expected Behaviour?

Self-explanatory.

Plugin version

CustomCrafting: 2.16.5.0 WolfyUtilities: 1.8.0.0

Server software

Paper 1.16.5

Relevant log output

No response

Submit issue

  • read the Wiki and especially the FaQ, and made sure there is no fix to your issue,
  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

Smithing table recipes broken after updating from 3.16.0.0 to 3.16.1.0

What happened?

First Image is 3.16.0.0

WAV8G_ 4Q3HE67K3BD{}~EM

Second Image is 3.16.1.0

KZ~LY2Q9HLZVWN7Y_FDOQKS

How can the bug be reproduced?

{
"group" : "",
"hidden" : false,
"priority" : "NORMAL",
"exactItemMeta" : true,
"conditions" : {
"values" : [ ]
},
"preserve_enchants" : true,
"onlyChangeMaterial" : true,
"result" : {
"items" : [ {
"custom_amount" : 1,
"mmoitems" : {
"type" : "ARMOR",
"name" : "้พ™้ณžๅคด็›”"
}
} ],
"tags" : [ ],
"extensions" : [ ]
},
"base" : {
"items" : [ {
"custom_amount" : 1,
"mmoitems" : {
"type" : "ARMOR",
"name" : "ไธ‹็•Œๅˆ้‡‘ๅคด็›”"
}
}, {
"custom_amount" : 1,
"mmoitems" : {
"type" : "ARMOR",
"name" : "้•ถ้‡‘ไธ‹็•Œๅˆ้‡‘ๅคด็›”"
}
} ],
"tags" : [ ],
"replaceWithRemains" : true,
"allowEmpty" : false
},
"addition" : {
"items" : [ {
"custom_amount" : 1,
"itemsadder" : "xiaomomi:dragon_scale"
} ],
"tags" : [ ],
"replaceWithRemains" : true,
"allowEmpty" : false
}
}

Expected Behaviour?

1

Plugin version

3.16.1.0

Server software

purpur 1.17.1

Relevant log output

No response

Submit issue

  • read the Wiki and especially the FaQ, and made sure there is no fix to your issue,
  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

Modify Lore Line

The Problem

None

Solution

When you are going to modify the lore of a item, now you have two options, first add a lore line and second remove a lore line.
My suggestion is create a third option to modify a specific line of the lore of a item.
unknown

Alternatives

None

Additional Context

None

Submit issue

  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

Recipes which can only be crafted during certain times of the real-world year

The Problem

This is based off a suggestion I made on the CustomCrafting discord channel, but I was thinking it would be great to have recipes which can only be crafted during certain months, like being able to set a recipe that could only be crafted during October for Halloween, it would make managing the exclusivity of event specific items easier.

Solution

I think adding an option, perhaps under "conditions" which allows a recipe to correspond to real-world dates (yearly events like Halloween, Christmas, Easter, or even specific random dates like May 9 2020, June 17 2022, or November 2 2024) would make managing recipes for event items much easier.

Alternatives

The main alternative I can think of is manually turning the recipes on and off, which is much more inconvenient, especially for recipes corresponding to yearly events.

Additional Context

I can't really think of any other additional context, but thanks for reading my suggestion!

Submit issue

  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

Changing Recipe Shaped Duplicates JSON File

What happened?

Changing the shaped option of an existing recipe will result in the recipe's JSON file being duplicated on save.
e.g. A shaped recipe saved under crafting_shaped when changed to shapeless will leave the existing file in crafting_shaped but also create a new file in crafting_shapeless.
In the above shaped to shapeless example the plugin will also incorrectly load the shaped recipe on server restarts.

How can the bug be reproduced?

  1. Create and save a shaped crafting recipe
  2. Change the recipe to shapeless and save again

Expected Behaviour?

When changing a recipe's shape the old JSON file should be removed upon save

Plugin version

CustomCrafting 3.16.0.0, WolfyUtilities 3.16.0.0

Server software

Paper 1.18.1

Relevant log output

No response

Submit issue

  • read the Wiki and especially the FaQ, and made sure there is no fix to your issue,
  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

Allow itemsadder blocks and furniture to be used for custom crafting tables

The Problem

itemsadder block are not actual blocks whilst in item form, usually they are paper or another material, so CustomCrafting does not recognize them as blocks in the gui, thus making them unable to be used for an elite workbench.

Solution

A way for customcrafting to hook into IA and recognize custom blocks and furniture. Also an option to count every instance of that block as an elite crafting table, so we can make custom crafting tables that work even when we get the custom item using IA's /iaget command and not through CC's command. And also all already-existing instances of that block will work correctly as well.

Alternatives

there seems to be none

Additional Context

A screenshot of CustomCrafting not recognizing an IA block as a block:

image

Submit issue

  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

Issues using "Mouse Wheelie" Mod's auto-crafting along with CustomCraft

What happened?

When trying to auto-craft every needed resource for an item into the final result by using shift + right click on the recipe from the recipe book it sometimes will not craft but only place the items in the crafting area without crafting the item itself like it usually does. As far as i can tell its every second attempt. It works one time, then you try to auto-craft another item and it will only place the items in the crafting area. If you don't craft the items into the result yourself it won't continue and only place other items in the crafting area when trying to auto-craft. In case do you craft the items into the result yourself the auto-craft will work the next time. Tried several times with crafting planks into crafting table first and then granit, andesite or diorite into the polished version. Seems not to be limited to specific items. When changing sequence and crafting granite, andesite or diorite into the polished version first and then trying to craft planks into crafting table it will place the planks in the crafting area. Just as mentioned before it seems to be every second attempt.

Bug visible at Screenshot bug_auto-craft_v2_result.
v1 & v2 are before using shift + right click and the result what happened after.

bug_auto-craft_v1
bug_auto-craft_v1_result
bug_auto-craft_v2
bug_auto-craft_v2_result

How can the bug be reproduced?

Use "Mouse Wheelie" Fabric Mod and CustomCrafting on a Paper Server (not tested if Paper is necessary),
Get the recipe of at least two different items, have resources to craft both items in your inventory, attemt to craft both.
In one attempt it'll auto-craft the resource into the max possible amount of the item, in the other attempt it will only place the item in the crafting area but won't auto-craft it.

Expected Behaviour?

When deleting CustomCraft and WolfyUtilities (did not test if WolfyUtilities makes a difference) every attempt to auto-craft recipes from the recipe book by shift+ right clicking the item's recipe will have a 100% success rate and always auto-craft the resource into the recipe's result item.

Plugin version

customcrafting-spigot-3.16.0.0-f.jar, wolfyutilities-3.16.0.0.jar

Server software

paper-1.18.1.jar

Relevant log output

-no relevant output-

Submit issue

  • read the Wiki and especially the FaQ, and made sure there is no fix to your issue,
  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

Dupe bug

What happened?

When you are making a recipe and you "SHIFT + Left click" the result slot to get all the items, the items gets duplicated.
This bug seems to be really hard to replicate and always happens when there are more items inside the crafting matrix.

I actually don't understand how and when it happens, but I figured out that spamming "SHIFT + Left click" makes this bug more often.

How can the bug be reproduced?

  1. Make a custom recipe
  2. Place all the items inside the crafting table to make that recipe
  3. Start spam-clicking "SHIFT + Left click" on the result slot
  4. And then it will eventually duplicate the crafting matrix's items

This is an example on how to do it, I sugged you to try with pickaxes too:
https://imgur.com/a/1mfqXgf

Expected Behaviour?

The items inside the crafting matrix should not be duped.

Plugin version

CustomCrafting 3.16.3.3, WolfyUtilities 3.16.3.2

Server software

Purpur 1.16.5

Relevant log output

No response

Submit issue

  • read the Wiki and especially the FaQ, and made sure there is no fix to your issue,
  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

Support for Battlepass plugin

The Problem

I want to use my custom items/recipes that i have made using Customcrafting, to be used as a quest. i want my players to craft a custom item to complete a quest and then after that, use the custom item to craft another item for another quest. The problem is that BattlePass isnt supported by Customcrafting.

Solution

As i've asked the dev of battlepass if customcrafting can be supported by battlepass he sent me this link: https://battlepass.advancedplugins.net/developer-api/developer-api-creating-your-own-quest-types
Unfortunately i dont know how to program and dont even understand what that link is telling me to do.

Alternatives

I tried to look for other customitems plugin that would be supported but unfortunately there isn't any. I thought about making a custom command but realized that will not help prove that someone crafted a custom item so that they can receive a battlepass reward.

Additional Context

in addition told me if i can't program ask the other plugin dev to do it. As bad as it sounded, I beg you to consider this, as I've been trying everyday for the past week but get half a$sed responses from the other dev's discord. Thank you

Submit issue

  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

Bulk-Crafting should behave differently with Extensions

The Problem

When using extensions to recipes, I have a command that runs after crafting an item. When shift-clicking, it still only runs once upon the click, instead of how many times there are crafted items. This is viewed as a bug in my eyes as i have it set to give alchemy xp in mcmmo via command when crafting wands, which doesnโ€™t work right when crafting many vs one

Solution

Either have an option for bulk-crafting extensions vs. single in the config, or integrate MCMMO xp as a reward extension natively via API and have all results considered when providing extended results (receive the xp 64 times for a 64x bulk craft, etc)

Alternatives

Unsure if there is a way to prevent bulk crafting for a specific recipe as well, but have considered that as an alternative.

Additional Context

Original support message:

https://discord.com/channels/477026331096514571/498358213842960394/921737778163753031

Basic Wand Recipe

https://pastebin.com/H8rAX42v

Submit issue

  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

compatibility Epic BackPacks plugin

The Problem

When I create a backpack that takes an item from the ItemsAdder register and place it in the CustomCrafting crafting slot, the NBT tags of the backpack are reset and taken from the ItemsAdder plugin and not from the EpicBackpacks plugin itself, and after that the backpack does not work.

 cool_backpack:
    display_name: '&fCool Backpack'
    item:
      type: ITEMSADDER_ITEM
      name: plastic_bag
    size: 3

Solution

it is necessary that he transfers all nbt tags from the EpicBackpacks plugin

 cool_backpack:
    display_name: '&fCool Backpack'
    item:
      type: ITEMSADDER_ITEM
      name: plastic_bag
    size: 3

Alternatives

nop

Additional Context

nop

Submit issue

  • searched for and ensured there isn't already an open issue regarding this,
  • are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.