Unconditional debug output `console.log(source, material);` may affect performance about aframe-effects HOT 4 OPEN

You're right, I think an approach could be to check if the debug component is set on the a-scene element. Thanks for noticing

from aframe-effects.

an approach could be to check if the debug component is set on the a-scene element.

Querying the browser DOM is slow compared to querying a JS variable. Especially repeatedly.

from aframe-effects.

But of course both approached should be benchmarked to find the most performant.

Using the de-facto standard debug module lets the users to remove the debug calls in production builds. Using the a-scene debug component may require extra dancing to strip that out.

from aframe-effects.

Ok, can you submit a PR?

from aframe-effects.