wizelinelabs / wlemptystate Goto Github PK

Improve Readme adding documentation of how to use the control.

Describe the bug
When using a UICollectionView and the numbers of cells change from zero to any number the EmptyStateView stays in the view hierarchy.

To Reproduce
Steps to reproduce the behavior:

1. Having a 'UICollectionView' implemented.
2. Change the number returned In the method collectionView(_:numberOfItemsInSection:) from zero to any other number.

Expected behavior
The EmptyStateView should be removed from the view hierarchy when the number of items in the UICollectionView goes from zero to any number greater than zero.

Screenshots

Smartphone:

• Device: iPhone 11 Pro
• OS: iOS 13.4
• Version: 3.1.0

Add tests with iOSSnapshotTestCase for Example target.

Describe the bug
Controllers do not deallocate from memory when using this framework

To Reproduce

self.tableView.emptyStateDataSource = self
self.tableView.emptyStateDelegate = self

extension VC: WLEmptyStateDataSource, WLEmptyStateDelegate {

func enableScrollForEmptyState() -> Bool {
    return true
}

func customViewForEmptyState() -> UIView? {
    return UIView()
}

}

Smartphone (please complete the following information):

• Device: 14
• OS: 17

why "self.subviews.count > 1"

In the meantime we're just printing errors, those should be informed in a better way.

Add a Logger dependency or something.

if I want to add WLEmptyState to all my Tableviews in an existing project.
What should I do?
I don't want to set it separately on each viewController

Choose and integrate a CI server that build and run our tests.

Describe the bug
If a UIViewController, which implements UITableViewDataSource does not implement the optional method numberOfSections, the UITableView always shows the empty state, even if the numberOfRownInSection method return a number != 0.

Expected behavior
The empty state should not be shown if the numberOfSections is not implemented, it should be shown if the numberOfSections method is implemented and returns 0.

Smartphone (please complete the following information):

• Device: iPhone6
• OS: iOS 12.2
• Version 1.0.2

Additional context
The problem should be in these lines of UITable+Extensions file:

    private var numberOfItems: Int {
        var items = 0
        let numberOfSections = dataSource?.numberOfSections?(in: self) ?? 0
        for section in 0..<numberOfSections {
            items += dataSource?.tableView(self, numberOfRowsInSection: section) ?? 0
        }
        return items
    }

The numberOfSections method (as UITableViewDataSource protocol documentation) should default to 1 if not implemented, but with this code if numberOfSections is not implemented it defaults to 0.

In several places of the documentation (Readme, repo description, WLEmptyState.swift comments) you say that it works on UITableView without mentioning that it also works on UICollectionView.

To our first release we need to document every public interface within the control.

This should also include MARKS.

Hi,

it would be great if Swift package Manager would also be supported.

I've already forked it https://github.com/benweidig/WLEmptyState/commit/01783571d7cc97f9bd6369d528108a619008b436 and made the necessary changes.

I would also have create a pull request BUT Swift Package Manager doesn't support assets, so either the default image must be removed, or it must be drawn in code.

Cheers,
Ben

• Adding Support for UICollectionView.

Describe the bug
Always the empty state is shown despite the emptyStateDataSource is not implemented in the tableView, causing that swizzledReload method adds the emptyStateView

 if numberOfItems == 0 && self.subviews.count > 1 {
            addSubview(emptyStateView)
            if let emptyStateView = emptyStateView as? EmptyStateView {
                emptyStateView.titleLabel.attributedText = self.emptyStateDataSource?.titleForEmptyDataSet()
                emptyStateView.descriptionLabel.attributedText = self.emptyStateDataSource?.descriptionForEmptyDataSet()
                emptyStateView.image.image = self.emptyStateDataSource?.imageForEmptyDataSet()
            } else {
                emptyStateView.translatesAutoresizingMaskIntoConstraints = false
                emptyStateView.heightAnchor.constraint(equalTo: heightAnchor).isActive = true
                emptyStateView.widthAnchor.constraint(equalTo: widthAnchor).isActive = true
                emptyStateView.centerYAnchor.constraint(equalTo: centerYAnchor).isActive = true
                emptyStateView.centerXAnchor.constraint(equalTo: centerXAnchor).isActive = true
            }
        }

To Reproduce
Steps to reproduce the behavior:

1. Configure the empty state in the AppDelegate
2. Implement a UITableViewController
3. Run and compile the app
4. Click the Debug View Hierarchy button on Xcode and see the emptyStateView at the top

Expected behavior
If the emptyStateDataSource is nil the emptyStateView shouldn't be shown

Screenshots

added to podfile but unable to find it

emptyStateDelegate、emptyStateDataSource
objc_setAssociatedObject(self, &AssociatedKeys.emptyStateDataSource, newValue, .OBJC_ASSOCIATION_RETAIN_NONATOMIC)

->

            objc_setAssociatedObject(self, &AssociatedKeys.emptyStateDataSource, newValue, .OBJC_ASSOCIATION_ASSIGN)