Code Monkey home page Code Monkey logo

Comments (4)

techfg avatar techfg commented on June 26, 2024 1

Thanks @delucis, just submitted PR #1731!

from starlight.

at-the-vr avatar at-the-vr commented on June 26, 2024

not sure why they are facing this issue 🤔, theme switching is working fine on my end
edit: found it(atleast for Chrome+Windows 10) changing Browser Mode from Dark to Light or Vice versa has no effect in starlight theme 😕
image

from starlight.

techfg avatar techfg commented on June 26, 2024

@at-the-vr - Correct 😃 I've edited my OP repro step #4 to my it more clear the issue occurs when changing the browser color mode. The issue is occurring because Starlight isn't listening for media query change events.

from starlight.

delucis avatar delucis commented on June 26, 2024

Thank you for the issue @techfg!

Yes, when implementing this initially, I skipped over this as an edge case. Would be happy to look at a PR adding this if you’d like to have a go. Let me know if you have any questions!

from starlight.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.