Tables in Asides about starlight HOT 15 OPEN

Dear @torn4dom4n.

Thank you for your suggestion.
I adjusted the alpha property so it looks better in dark mode.
What do you think of the new coloring of tables in the aside element?

Best regards,
SnowDingo

from starlight.

@torn4dom4n

Before I create a PR that resolves this issue, would you mind reviewing the rest of the coloring for the other types of Aside elements?

Best Regards,
Snowdingo

from starlight.

@SnowDingo It's too contrast for me

from starlight.

Dear @torn4dom4n.

Thank you for your suggestion about the coloring of the table.
I changed the colors so that it has less contrast with each other.
It is not the official Starlight color pallet so it doesn't look good on both light & dark themes.
What do you think about this?

Sincerely,
Snowdingo.

from starlight.

Thanks for the issue @torn4dom4n! I agree this is not ideal styling. It might be possible to override some colours for tables inside asides. Would be curious to see anyone’s ideas for how best to solve this!

from starlight.

Dear @torn4dom4n.

I am currently working on making PR that resolves this issue and here is what it currently looks like in my local environment.
Are there any changes to the styling you want to make? If not, I will submit my code as a PR so it can be added to the Starlight package.

Thank you

Snowdingo

from starlight.

Dear @torn4dom4n.

I am currently working on making PR that resolves this issue and here is what it currently looks like in my local environment. Are there any changes to the styling you want to make? If not, I will submit my code as a PR so it can be added to the Starlight package.

Thank you

Snowdingo

This is good but I think you should change the background between rows like GitHub markdown:

It made tables to be clear.

from starlight.

@torn4dom4n, thank you for your suggestion on the styling of the table.
Would it be possible for you to expand more on your idea of changing the background between the rows?
I got a little confused about what you are suggesting.

Thank you
@SnowDingo

from starlight.

@torn4dom4n, thank you for your suggestion on the styling of the table. Would it be possible for you to expand more on your idea of changing the background between the rows? I got a little confused about what you are suggesting.

Thank you @SnowDingo

Sure. This is the image:

You can see the second row's background color is different from the third row.

from starlight.

Dear, @torn4dom4n.
Sorry for replying late. I figured out how to change the background colors of tables like the GitHub table.
What do you think about this new version?

Thank you

Best Regards,
Snowdingo

from starlight.

@SnowDingo great work. I like the light mode. Dark mode is still too contrast.

from starlight.

@SnowDingo I love it 👍🏻. Hope the others also like it.

from starlight.

Dear @torn4dom4n.

Thank you for your suggestion. I adjusted the alpha property so it looks better in dark mode. What do you think of the new coloring of tables in the aside element?

Best regards, SnowDingo

Let's create a PR.

from starlight.

@SnowDingo I really love all of them.

from starlight.

Dear @torn4dom4n.
I created a PR that resolves this issue.

#1796

Thank you for contributing to Astro Starlight!

Sincerely,
Snowdingo

from starlight.