wiredcraft / carcass Goto Github PK

Need to add the ability to carcass to log things; eventually allowing to:

• have a different backend for log storage: ex. syslog, file, logstash (can look at existing libraries)
• define log verbosity

Unless argued differently it should be in a separate module, not in carcass core; see carcass-auth for more details.

Properly document the code and include the various required readme to integrate with a regular carcass project.

• Make it usable, with the common methods.
• Class or factory doesn't make a difference, so I'm not sure yet..
• Underscore methods are nice to have.

What do you think about creating a carcass executable which permits to :

• generate a carcass app
• generate a carcass sample app
• running the server in development with supervisor
• ...

Please reassign to the one work on this.

The module carcass-auth is in this repo for now. The one who's working on this will need the permission.

Details:

• Please build and send me pull requests.
• Please use passport-github.
• I only need the login process. Please do not consider session supports.
• Note that the login process involves 3 characters: client, server and Github. You'll need to setup Github first and simulate the client with tests.
• Build an auth plugin in /auth and optionally a test application in /test/fixture/applications to expose some test info.
• The client will need to be redirected and input info on Github. It's not easy to do it with tests so you can test it manually and then do it with tests. Not that the test is a requirement.

I still don't understand what carcass is and what does it do. Would you please help me out?

1. What is carcass?

Is it basic infrastructure for our future web servers? How should it be used? like in ./fixture? is there any code demonstrating the use cases?

I saw carcass-auth but that doesn't help.

I hope there is some picture or sth describes the carcass architecture.

2. What is an application?

Is it some kind of middleware? I can't see what they're used for. Are they designed to run separately? since they seem to use separate express objects.

3. What is a Model?

I can't see where are they used.

4. What's the relation between constructors/Server, factories/Express and servers/Http?

I can see servers/Http extends constructors/Server, but what about constructors/Server and factories/Express?

Of course factories/Express seems to be a factory but I doubt if they have conflicting responsibilities since I see they both use express internally.

5. What does plugin means here? I'm especially confused when I see

    var plugin = this.getApplication(title);

so application is plugin?

Anyway, even I wrote some tests, I'm still totally confused. Sorry for that.

• Tests should cover everything.
• Tests should be name-spaced.
• Some of the tests need to be name-spaced as usecase or something because they are actually use cases.
• Please fork and send me pull requests.

Maybe it can make your life easier if you understand the Express factory. Please do this by building a test for it, in factories.express.mocha.js.

The test should cover:

• Use the factory to get a builder which is a function.
• Use the builder to get an application which is an Express application.
• Initialize function.
• args and options.

Please do this in a new branch (not the same as for the tests).

Currently we have 2 main approach of organizing code: inheritance and factory. Application is using factory, server and model are using inheritance. I'd like to rebuild the server to be a factory, which means for example:

• Server is an abstract factory (currently a constructor), returns a concrete factory.
• http and https are concrete factories (currently constructors extended from Server), return server instances.

This doesn't make it more flexible, but more strict.

What do you think of this change? And do you think you can do this?

Hi,

Sorry, been out of the loop last few weeks dealing with interviews. Do we have a google group or anything to coordinate those who want to work on Carcass but are not actively working with devo-ps? I'm writing up an example application now to use Carcass, but once I'm done I'd like to ask for feedback outside issues for Carcass itself.

Hi @xufeng123,

Can you input something about "Register" in https://github.com/devo-ps/carcass/wiki/Core? Thanks.

Hi @xeodou,

Can you help me improve carcass.utils.machineName? The first things:

• TODOs in it. Please input proper error messages.
• Please replace _.isFunction() and _.isString() with typeof testings and remove underscore from the file.

Please send me pull requests. Thanks.

• Please rename testSession application to login, also change the title and debug info.
• Please use passport local to login. Note that a login should be a POST.
• Please remove /member and:
  • Add another application model.
  • Add 2 endpoints: PUT and GET, to save and read a model.
  • Use memory storage to store the model.
  • Make sure all the things there require login.

• Cradle for couch.
• Elastic search.
• ...

I think we can move the small feather to small module, and use npm to include into carcass. Sometimes if i just want to use a feather like carcass in a small module, carcass is too big for me.

redesign the logo of carcass.

Hi,

I just made some change to the mixin() function, and realized we don't have enough tests for it; only one in carcass.mocha.js and a use case in usecase.eventEmitter.mocha.js.

Please build a new test carcass.mixable.mocha.js with the following:

• An object or a function can be mixable and the others cannot (not sure about array, you tell me).
• A mixable target can mixin from an object or a function, not from the others.
• The prototype of the target is also mixable.
• Only enumerable properties can be merged.

Note that some of your tests can fail because there can be bugs. Please also try to fix it.