Comments (15)
@ghost1372
yes, the problem is definitely in the scale, the black lines that are responsible for the dragging regions were not drawn correctly
I'll try to fix it now
from winuicommunity.
@ghost1372 Could you please publish 3bc38a5 to NuGet?
i will upload it today
from winuicommunity.
@ghost1372
cool, it works) looks great)
Tnx, i uploaded a new version
from winuicommunity.
Tnx Again,
I have applied your changes to the code.
also I must mention that the codes used to customize the title bar in WASDK v1.4 are obsolete and new API have been provided. And in the future, we are going to use new API, but until then, we are using the old api.
Also, if you're interested, here's another bugπ
. If you use windows Snap Layout, drag region will not work!
and It would be great if you could send your changes via pull request
(gif is a little heavy, wait for it)
from winuicommunity.
@ghost1372
I can't reproduce this bug, is this problem reproduced in other applications such as Settings?
from winuicommunity.
@dzhukovsky add a Content or Footer
<wuc:TitleBar.Content>
<AutoSuggestBox PlaceholderText="Search"
QueryIcon="Find" />
</wuc:TitleBar.Content>
from winuicommunity.
@ghost1372
I still can't reproduce it(
can you download this app and check it for yourself? and if the bug is not reproduced, can you send me a link to your sample app so I can look?
https://drive.google.com/file/d/1mNQk4t3IRvxmRJVIkeyAPyX3Msst8joH/view?usp=drive_link
from winuicommunity.
@dzhukovsky Thanks for the example, but it didn't work either.
I checked a little and it seems that the reason is the scale!
I'm using a scale of 125% and that's why it doesn't work. Changing the scale to 100% solves the issue.
In any case, this issue should be solved and work the same on different scales.
Can you confirm that you also have issues with changing scale to 125%?
from winuicommunity.
@ghost1372
I tried to fix it but so far nothing has worked for me.
The problem is probably related to the calculation of the ActualWidth property.
I converted the TitleBar into a UserControl and the problem went away, but the visual effects disappeared(
from winuicommunity.
@dzhukovsky Thank you for your effort, I take a look whenever I have a chance
from winuicommunity.
@ghost1372
Could you please publish 3bc38a5 to NuGet?
from winuicommunity.
@dzhukovsky i fixed issueπ
can you test and confirm it?
Changes-On-4ff466.patch
from winuicommunity.
@ghost1372
cool, it works) looks great)
from winuicommunity.
I found a new, more simple and reliable way to calculate draggable rects, I'll share the changes later.
Also, probably need to think about optimization and remove unnecessary event handlers (like TitleBar_SizeChanged because we have Window_SizeChanged) so that draggable rects are not calculated several times
from winuicommunity.
I found a new, more simple and reliable way to calculate draggable rects, I'll share the changes later. Also, probably need to think about optimization and remove unnecessary event handlers (like TitleBar_SizeChanged because we have Window_SizeChanged) so that draggable rects are not calculated several times
Great!
from winuicommunity.
Related Issues (20)
- i want a demo app to know the real experence but i get 404 HOT 2
- i found a bug with your titlebar HOT 4
- i have a little advice about your document HOT 1
- Additional documentation or samples HOT 4
- [BUG] The drag region in TitleBar control blocks clicking on PART_PaneButton HOT 1
- JsonNavigationViewService HOT 4
- Using the HomeLandingPage in unpackaged app crashes HOT 9
- Cannot change shortcut HOT 1
- Cannot add package into class library project HOT 1
- Feature: Add quick view of the usage code HOT 7
- [SUGGESTION] Rename services and helpers. HOT 1
- [SUGGESTION] TitleBar Improvements HOT 4
- 6.1.0 Has some problems HOT 6
- Growl Global throwing error on Win10 machines. HOT 2
- Reg... Dark Theme. HOT 5
- The SystemBackdrop of the window will turn solid black if it is none, and will not respond to theme changes HOT 1
- [Feature] Implement Navigation Frame with Dependency Injection for Enhanced Navigation HOT 2
- [Bug] NavigationService -Footer navigation doesn't work HOT 1
- Link off HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from winuicommunity.