Code Monkey home page Code Monkey logo

Comments (15)

dzhukovsky avatar dzhukovsky commented on May 29, 2024 2

@ghost1372
yes, the problem is definitely in the scale, the black lines that are responsible for the dragging regions were not drawn correctly
I'll try to fix it now
image

from winuicommunity.

ghost1372 avatar ghost1372 commented on May 29, 2024 1

@ghost1372 Could you please publish 3bc38a5 to NuGet?

i will upload it today

from winuicommunity.

ghost1372 avatar ghost1372 commented on May 29, 2024 1

@ghost1372
cool, it works) looks great)
Recording 2023-11-06 at 20 01 45

Tnx, i uploaded a new version

from winuicommunity.

ghost1372 avatar ghost1372 commented on May 29, 2024

Tnx Again,
I have applied your changes to the code.
also I must mention that the codes used to customize the title bar in WASDK v1.4 are obsolete and new API have been provided. And in the future, we are going to use new API, but until then, we are using the old api.
Also, if you're interested, here's another bugπŸ˜…. If you use windows Snap Layout, drag region will not work!

and It would be great if you could send your changes via pull request

(gif is a little heavy, wait for it)
000000555555

from winuicommunity.

dzhukovsky avatar dzhukovsky commented on May 29, 2024

@ghost1372
I can't reproduce this bug, is this problem reproduced in other applications such as Settings?

Animation

from winuicommunity.

ghost1372 avatar ghost1372 commented on May 29, 2024

@dzhukovsky add a Content or Footer

<wuc:TitleBar.Content>
    <AutoSuggestBox PlaceholderText="Search"
                    QueryIcon="Find" />
</wuc:TitleBar.Content>

from winuicommunity.

dzhukovsky avatar dzhukovsky commented on May 29, 2024

@ghost1372
I still can't reproduce it(
can you download this app and check it for yourself? and if the bug is not reproduced, can you send me a link to your sample app so I can look?

https://drive.google.com/file/d/1mNQk4t3IRvxmRJVIkeyAPyX3Msst8joH/view?usp=drive_link

Recording 2023-11-05 at 12 53 19

from winuicommunity.

ghost1372 avatar ghost1372 commented on May 29, 2024

@dzhukovsky Thanks for the example, but it didn't work either.
I checked a little and it seems that the reason is the scale!
I'm using a scale of 125% and that's why it doesn't work. Changing the scale to 100% solves the issue.
In any case, this issue should be solved and work the same on different scales.
Can you confirm that you also have issues with changing scale to 125%?
Screenshot 2023-11-05 164135

from winuicommunity.

dzhukovsky avatar dzhukovsky commented on May 29, 2024

@ghost1372
I tried to fix it but so far nothing has worked for me.
The problem is probably related to the calculation of the ActualWidth property.
I converted the TitleBar into a UserControl and the problem went away, but the visual effects disappeared(

from winuicommunity.

ghost1372 avatar ghost1372 commented on May 29, 2024

@dzhukovsky Thank you for your effort, I take a look whenever I have a chance

from winuicommunity.

dzhukovsky avatar dzhukovsky commented on May 29, 2024

@ghost1372
Could you please publish 3bc38a5 to NuGet?

from winuicommunity.

ghost1372 avatar ghost1372 commented on May 29, 2024

@dzhukovsky i fixed issueπŸ˜…
can you test and confirm it?
Changes-On-4ff466.patch

from winuicommunity.

dzhukovsky avatar dzhukovsky commented on May 29, 2024

@ghost1372
cool, it works) looks great)
Recording 2023-11-06 at 20 01 45

from winuicommunity.

dzhukovsky avatar dzhukovsky commented on May 29, 2024

I found a new, more simple and reliable way to calculate draggable rects, I'll share the changes later.
Also, probably need to think about optimization and remove unnecessary event handlers (like TitleBar_SizeChanged because we have Window_SizeChanged) so that draggable rects are not calculated several times

from winuicommunity.

ghost1372 avatar ghost1372 commented on May 29, 2024

I found a new, more simple and reliable way to calculate draggable rects, I'll share the changes later. Also, probably need to think about optimization and remove unnecessary event handlers (like TitleBar_SizeChanged because we have Window_SizeChanged) so that draggable rects are not calculated several times

Great!

from winuicommunity.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.