winlibs / libiconv Goto Github PK

Building C++ projects with iconv.h is broken at the moment.

source/include/iconv.h around lines 70-72 has a new
#ifdef __cplusplus
extern "C" {
#endif

but is missing the corresponding closing brace for C++ at line 98:
#ifdef __cplusplus
}
#endif

First of all:
Thanks for this. You've saved me (and many others I'm sure) a lot of time and headache.

I just have a quick question:
I've noticed that no import libraries (iconv*.lib) are produced when building the DLL.
Is this by design?
I only tried the VC2015 solution as this is the only IDE I use.

If not, I could help you make the solutions produce import libraries as well.
Also, it would be cool if you could bump up the platform toolchain for the VC2015 solution as well.
And a visual studio project file for the application (iconv.exe) would be nice as well. 😄

Again, I can help out with these (requests) if needed.

Thanks again and have a nice day

@weltling @cmb69
Yesterday I updated my VS16 to version 16.2.0. This update removed the 14.21.27702 compiler version and replaces it by 14.22.27905. On my systems it retained the previous 14.20.27508 compiler version, because I had selected 'C++/CLI support for v142 build tools (14.20). after the update to VS16 version 16.1

Building PHP extensions with a link.exe that is too new is not recommended:
https://www.apachelounge.com/viewtopic.php?p=38260#38260

So, I decided to compile PHP 7.4 with the 14.20 build tools. Then I ran into this error:

libiconv_a.lib(iconv1.obj) : MSIL .netmodule or module compiled with /GL found; restarting
link with /LTCG; add /LTCG to the link command line to improve linker performance
fatal error C1900: Il mismatch between 'P1' version '20181108' and 'P2' version '20181107'
LINK : fatal error LNK1257: code generation failed
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\
VC\Tools\MSVC\14.20.27508\bin\HostX64\x64\link.exe"' : return code '0x4e9'

I had to recompile libiconv_a.lib to get this running. For the recompilation I used the 14.20 build tools.

@cmb69 I tried the v142 14.20~14.28 build tools referring to #9, but all of them output the same error below.

libiconv_a.lib(iconv1.obj) : MSIL .netmodule または /GL を伴ってコンパイルされたモジュールが見つかりました。/LTCG を使用して再開始してください。リンカーのパフォーマンスを向上させるためには、コマンドラインに /LTCG を追加してください。
fatal error C1900: 'P1' Version '20200803' と 'P2' Version '20190715' が一致しません。
LINK : fatal error LNK1257: コードの生成に失敗しました。
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\bin\HostX64\x64\link.exe"' : リターン コード '0x4e9'
Stop.

Support for Visual Studio 2022 (MSVC17) would be awesome!

lib/aliases.gperf:134: error: ‘__int32’ undeclared here (not in a function)
In file included from ./iconv.c:459:

With master, the following error is thrown (using /MSVC11/libiconv.sln):

error C2632: 'int' followed by 'int' is illegal	
C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\include\wchar.h	
line#1202

Not sure what has changed here recently, as the MSVC11 build was working fine before.