Code Monkey home page Code Monkey logo

Comments (6)

danyeaw avatar danyeaw commented on July 18, 2024 1

Ok cool, would you be interested in making a PR to add Gtkmm to the GTK4 pipeline?

from gvsbuild.

danyeaw avatar danyeaw commented on July 18, 2024

Hi @alexv-ds, thanks for the suggestion! Adding Gtkmm would make sense to me because it is part of the core GTK libraries. However, we would need to add building of Gtkmm as part of our CI/CD pipeline which would slow down the builds. It would also increase the download size of the distributed zip. However, those are probably ok tradeoffs.

Can I ask what you are using Gtkmm for on Windows?

from gvsbuild.

alexv-ds avatar alexv-ds commented on July 18, 2024

Can I ask what you are using Gtkmm for on Windows?

I want to make another email client😅

Currently development is on Linux, but adding gtkmm will reduce the windows headaches🙂

from gvsbuild.

pbor avatar pbor commented on July 18, 2024

This is kind of a slippery slope... let's see the timing with Alex's patch and decide

Maybe we should revise a bit our CI strategy so that:

  1. We do "nightly" builds with a fuller target
  2. We run a smaller target for normal PRs
  3. (optional but it be cool) If the PR contains a [ci target: foo] line we would build that target

The last point would also help with testing PR for libs that are not part of the default target

from gvsbuild.

danyeaw avatar danyeaw commented on July 18, 2024

Hi @pbor, I agree that we should be careful adding too much to the build and to the binaries. It looks like this didn't really change our build time, and it looks like the binaries are about 30mb larger. Maybe we should clearly define what is and what is not part of our core part of GTK4 that we want to provide. For example, libraries like libsoup, glib-networking, and graphene aren't so clear to me - they are definitely GTK related.

I also agree that using something like https://github.com/tj-actions/changed-files to control the pipeline would be really nice to build a much more targeted build for what has changed. Probably for tools updates we'll need to build a wider set of libraries, but we probably don't need to build all of GTK if an unrelated library updates.

from gvsbuild.

danyeaw avatar danyeaw commented on July 18, 2024

Closed by #1348. Thanks @alexv-ds!

from gvsbuild.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.