Include patch to fix pango font rendering about gvsbuild HOT 7 CLOSED

Hi @theCapypara, we could integrate this patch, would you mind creating a PR?

from gvsbuild.

But are you sure we are affected and it is not msys specific? The comment from Fan in the upstream bug report says that he cannot reproduce when building with VS2019

from gvsbuild.

I'm not fully certain. I have some weirdness with font rendering for a few months for one of my GTK3 apps, but its possible it's unrelated to this. I'll do some tests.

from gvsbuild.

Here's the results:

I'm not 100% convinced the "normal" label text looks much better, but at least a bit? The GtkSource text looks 1000x times better though. I'll open a PR.

EDIT: Okay looking at it on a better screen the results for the label text are also much better.

from gvsbuild.

I tried to test this as well, I didn't see any noticeable difference with normal fonts or with GtkSourceview with GTK4. I am not against merging the patch if it is helping you though.

In general, I think the fonts don't look great on Windows. I get Pango-WARNING **: 10:03:29.777: couldn't load font "MyriadPro Not-Rotated 7.654", falling back to "Sans Not-Rotated 7.654", expect ugly output. warnings with and without this patch.

from gvsbuild.

Yeah, this might for some reason only affect GTK 3. I have another app using GTK 4 and didn't notice major font issues there before, but I also didn't check it with this patch yet and I don't use GtkSourceView there.

from gvsbuild.

Hm.... #1328 fixed the GtkSourceView issue. However font quality overall is still poor without #1325.
It is better, but still not great. You can see yellow and blue artifacts.

Here is the same screenshots as above but just with the current main branch, #1328 included (but not my PR):

from gvsbuild.