Comments (7)
Hi @theCapypara, we could integrate this patch, would you mind creating a PR?
from gvsbuild.
But are you sure we are affected and it is not msys specific? The comment from Fan in the upstream bug report says that he cannot reproduce when building with VS2019
from gvsbuild.
I'm not fully certain. I have some weirdness with font rendering for a few months for one of my GTK3 apps, but its possible it's unrelated to this. I'll do some tests.
from gvsbuild.
Here's the results:
I'm not 100% convinced the "normal" label text looks much better, but at least a bit? The GtkSource text looks 1000x times better though. I'll open a PR.
EDIT: Okay looking at it on a better screen the results for the label text are also much better.
from gvsbuild.
I tried to test this as well, I didn't see any noticeable difference with normal fonts or with GtkSourceview with GTK4. I am not against merging the patch if it is helping you though.
In general, I think the fonts don't look great on Windows. I get Pango-WARNING **: 10:03:29.777: couldn't load font "MyriadPro Not-Rotated 7.654", falling back to "Sans Not-Rotated 7.654", expect ugly output.
warnings with and without this patch.
from gvsbuild.
Yeah, this might for some reason only affect GTK 3. I have another app using GTK 4 and didn't notice major font issues there before, but I also didn't check it with this patch yet and I don't use GtkSourceView there.
from gvsbuild.
Hm.... #1328 fixed the GtkSourceView issue. However font quality overall is still poor without #1325.
It is better, but still not great. You can see yellow and blue artifacts.
Here is the same screenshots as above but just with the current main branch, #1328 included (but not my PR):
from gvsbuild.
Related Issues (20)
- 'python3.EXE is not a valid python or it is missing distutils' error when installing PyGObject HOT 7
- Can't run `gvsbuild build gtk4` HOT 2
- It says `pkg-config` is not installed? HOT 1
- Install gvsbuild error HOT 3
- gtk4 build failed HOT 1
- `gvsbuild build libadwaita --enable-gi` does not create Adw*.typelib / Unclear how to build Adw typelib HOT 2
- 2024.2.0 build fails on Windows 10 (runs out of memory) HOT 11
- CERTIFICATE_VERIFY_FAILED on Windows 11 HOT 1
- GTK App crashes with g_atomic_ref_count_dec: assertion 'old_value > 0' failed HOT 2
- nghttp2 update to version 1.60.0 fails
- Building GTK4 fails HOT 4
- Error while building gtk3 HOT 12
- GTK4 build fails HOT 2
- gobject-introspection fails without setuptools on Python 3.12
- Link to binaries HOT 1
- Font rendering issues for GTK4 HOT 2
- adding gtkmm libraries to the next releases HOT 6
- Allow changing meson options for packages
- patch' is not recognized as an internal or external command, operable program or batch file HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gvsbuild.