Making sure a space is fully disposed when unmounting about react-pts-canvas HOT 5 CLOSED

Thanks @tibotiber for the PR. I've patched pts to 0.9.3 and react-pts-canvas to 0.2.8. See if that works 😃

from react-pts-canvas.

@williamngan I've updated to the latest versions and it now works as intended in my app :). Good to close. Thanks for your feedback on this. 🍻

from react-pts-canvas.

Thank you so much @tibotiber !

I actually really like your suggestion on a space.dispose method. Then we can have a single function to manage these. If you can send a PR to Pts repo, that would be awesome 🙏

I think there's only a resize event which we need to take care of. There are a couple of mouse & touch events which are attached to canvas element, but they should be removed automatically when the element unmounts, right?

from react-pts-canvas.

Yes, I guess they should be removed as well. What about the animation frame request in play(), would that need to be cancelled or is it done already?

from react-pts-canvas.

PR opened :)

from react-pts-canvas.