Comments (2)
williamngan
commented on May 31, 2024
Hi @tibotiber - thanks for catching this.
Pts currently doesn't remove listeners automatically when an element unmounts. It's probably worth adding to Pts if it doesn't add a lot of code/complexity.
I'm also fine with fixing this in React only, since it's somewhat an edge case if users are not using Pts as React components.
What do you think?
from react-pts-canvas.
tibotiber
commented on May 31, 2024
Yes, I have never used Pts without React, I've just had a look at your demo repo and it's indeed a lot more intentional about what's registered, bound, etc - so users would expect to clear the listeners themselves I guess. Seems like solving this in React only is a good fit. I'll have a go at it.
from react-pts-canvas.
Related Issues (13)
- How to set canvas size HOT 2
- React hooks / functional components? HOT 12
- Making sure a space is fully disposed when unmounting HOT 5
- 3px space at the bottom HOT 5
- Async onStart method HOT 1
- Performance issue HOT 7
- Dependency tree broken, react ver 17. HOT 3
- Play get called twice? HOT 6
- Invalid use of useLayoutEffect in SSR-env HOT 3
- React 18 support
- Infinite recursion if using a tsup build
- add offscreen and pixelDensity props
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-pts-canvas.